mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-26 09:55:12 +07:00
e1452b607c
Sometimes we would like to revert a particular fix. Currently, this is not easy because we want to keep all other fixes active and we could revert only the last applied patch. One solution would be to apply new patch that implemented all the reverted functions like in the original code. It would work as expected but there will be unnecessary redirections. In addition, it would also require knowing which functions need to be reverted at build time. Another problem is when there are many patches that touch the same functions. There might be dependencies between patches that are not enforced on the kernel side. Also it might be pretty hard to actually prepare the patch and ensure compatibility with the other patches. Atomic replace && cumulative patches: A better solution would be to create cumulative patch and say that it replaces all older ones. This patch adds a new "replace" flag to struct klp_patch. When it is enabled, a set of 'nop' klp_func will be dynamically created for all functions that are already being patched but that will no longer be modified by the new patch. They are used as a new target during the patch transition. The idea is to handle Nops' structures like the static ones. When the dynamic structures are allocated, we initialize all values that are normally statically defined. The only exception is "new_func" in struct klp_func. It has to point to the original function and the address is known only when the object (module) is loaded. Note that we really need to set it. The address is used, for example, in klp_check_stack_func(). Nevertheless we still need to distinguish the dynamically allocated structures in some operations. For this, we add "nop" flag into struct klp_func and "dynamic" flag into struct klp_object. They need special handling in the following situations: + The structures are added into the lists of objects and functions immediately. In fact, the lists were created for this purpose. + The address of the original function is known only when the patched object (module) is loaded. Therefore it is copied later in klp_init_object_loaded(). + The ftrace handler must not set PC to func->new_func. It would cause infinite loop because the address points back to the beginning of the original function. + The various free() functions must free the structure itself. Note that other ways to detect the dynamic structures are not considered safe. For example, even the statically defined struct klp_object might include empty funcs array. It might be there just to run some callbacks. Also note that the safe iterator must be used in the free() functions. Otherwise already freed structures might get accessed. Special callbacks handling: The callbacks from the replaced patches are _not_ called by intention. It would be pretty hard to define a reasonable semantic and implement it. It might even be counter-productive. The new patch is cumulative. It is supposed to include most of the changes from older patches. In most cases, it will not want to call pre_unpatch() post_unpatch() callbacks from the replaced patches. It would disable/break things for no good reasons. Also it should be easier to handle various scenarios in a single script in the new patch than think about interactions caused by running many scripts from older patches. Not to say that the old scripts even would not expect to be called in this situation. Removing replaced patches: One nice effect of the cumulative patches is that the code from the older patches is no longer used. Therefore the replaced patches can be removed. It has several advantages: + Nops' structs will no longer be necessary and might be removed. This would save memory, restore performance (no ftrace handler), allow clear view on what is really patched. + Disabling the patch will cause using the original code everywhere. Therefore the livepatch callbacks could handle only one scenario. Note that the complication is already complex enough when the patch gets enabled. It is currently solved by calling callbacks only from the new cumulative patch. + The state is clean in both the sysfs interface and lsmod. The modules with the replaced livepatches might even get removed from the system. Some people actually expected this behavior from the beginning. After all a cumulative patch is supposed to "completely" replace an existing one. It is like when a new version of an application replaces an older one. This patch does the first step. It removes the replaced patches from the list of patches. It is safe. The consistency model ensures that they are no longer used. By other words, each process works only with the structures from klp_transition_patch. The removal is done by a special function. It combines actions done by __disable_patch() and klp_complete_transition(). But it is a fast track without all the transaction-related stuff. Signed-off-by: Jason Baron <jbaron@akamai.com> [pmladek@suse.com: Split, reuse existing code, simplified] Signed-off-by: Petr Mladek <pmladek@suse.com> Cc: Josh Poimboeuf <jpoimboe@redhat.com> Cc: Jessica Yu <jeyu@kernel.org> Cc: Jiri Kosina <jikos@kernel.org> Cc: Miroslav Benes <mbenes@suse.cz> Acked-by: Miroslav Benes <mbenes@suse.cz> Acked-by: Josh Poimboeuf <jpoimboe@redhat.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
249 lines
8.2 KiB
C
249 lines
8.2 KiB
C
/*
|
|
* livepatch.h - Kernel Live Patching Core
|
|
*
|
|
* Copyright (C) 2014 Seth Jennings <sjenning@redhat.com>
|
|
* Copyright (C) 2014 SUSE
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version 2
|
|
* of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef _LINUX_LIVEPATCH_H_
|
|
#define _LINUX_LIVEPATCH_H_
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/ftrace.h>
|
|
#include <linux/completion.h>
|
|
#include <linux/list.h>
|
|
|
|
#if IS_ENABLED(CONFIG_LIVEPATCH)
|
|
|
|
#include <asm/livepatch.h>
|
|
|
|
/* task patch states */
|
|
#define KLP_UNDEFINED -1
|
|
#define KLP_UNPATCHED 0
|
|
#define KLP_PATCHED 1
|
|
|
|
/**
|
|
* struct klp_func - function structure for live patching
|
|
* @old_name: name of the function to be patched
|
|
* @new_func: pointer to the patched function code
|
|
* @old_sympos: a hint indicating which symbol position the old function
|
|
* can be found (optional)
|
|
* @old_func: pointer to the function being patched
|
|
* @kobj: kobject for sysfs resources
|
|
* @node: list node for klp_object func_list
|
|
* @stack_node: list node for klp_ops func_stack list
|
|
* @old_size: size of the old function
|
|
* @new_size: size of the new function
|
|
* @kobj_added: @kobj has been added and needs freeing
|
|
* @nop: temporary patch to use the original code again; dyn. allocated
|
|
* @patched: the func has been added to the klp_ops list
|
|
* @transition: the func is currently being applied or reverted
|
|
*
|
|
* The patched and transition variables define the func's patching state. When
|
|
* patching, a func is always in one of the following states:
|
|
*
|
|
* patched=0 transition=0: unpatched
|
|
* patched=0 transition=1: unpatched, temporary starting state
|
|
* patched=1 transition=1: patched, may be visible to some tasks
|
|
* patched=1 transition=0: patched, visible to all tasks
|
|
*
|
|
* And when unpatching, it goes in the reverse order:
|
|
*
|
|
* patched=1 transition=0: patched, visible to all tasks
|
|
* patched=1 transition=1: patched, may be visible to some tasks
|
|
* patched=0 transition=1: unpatched, temporary ending state
|
|
* patched=0 transition=0: unpatched
|
|
*/
|
|
struct klp_func {
|
|
/* external */
|
|
const char *old_name;
|
|
void *new_func;
|
|
/*
|
|
* The old_sympos field is optional and can be used to resolve
|
|
* duplicate symbol names in livepatch objects. If this field is zero,
|
|
* it is expected the symbol is unique, otherwise patching fails. If
|
|
* this value is greater than zero then that occurrence of the symbol
|
|
* in kallsyms for the given object is used.
|
|
*/
|
|
unsigned long old_sympos;
|
|
|
|
/* internal */
|
|
void *old_func;
|
|
struct kobject kobj;
|
|
struct list_head node;
|
|
struct list_head stack_node;
|
|
unsigned long old_size, new_size;
|
|
bool kobj_added;
|
|
bool nop;
|
|
bool patched;
|
|
bool transition;
|
|
};
|
|
|
|
struct klp_object;
|
|
|
|
/**
|
|
* struct klp_callbacks - pre/post live-(un)patch callback structure
|
|
* @pre_patch: executed before code patching
|
|
* @post_patch: executed after code patching
|
|
* @pre_unpatch: executed before code unpatching
|
|
* @post_unpatch: executed after code unpatching
|
|
* @post_unpatch_enabled: flag indicating if post-unpatch callback
|
|
* should run
|
|
*
|
|
* All callbacks are optional. Only the pre-patch callback, if provided,
|
|
* will be unconditionally executed. If the parent klp_object fails to
|
|
* patch for any reason, including a non-zero error status returned from
|
|
* the pre-patch callback, no further callbacks will be executed.
|
|
*/
|
|
struct klp_callbacks {
|
|
int (*pre_patch)(struct klp_object *obj);
|
|
void (*post_patch)(struct klp_object *obj);
|
|
void (*pre_unpatch)(struct klp_object *obj);
|
|
void (*post_unpatch)(struct klp_object *obj);
|
|
bool post_unpatch_enabled;
|
|
};
|
|
|
|
/**
|
|
* struct klp_object - kernel object structure for live patching
|
|
* @name: module name (or NULL for vmlinux)
|
|
* @funcs: function entries for functions to be patched in the object
|
|
* @callbacks: functions to be executed pre/post (un)patching
|
|
* @kobj: kobject for sysfs resources
|
|
* @func_list: dynamic list of the function entries
|
|
* @node: list node for klp_patch obj_list
|
|
* @mod: kernel module associated with the patched object
|
|
* (NULL for vmlinux)
|
|
* @kobj_added: @kobj has been added and needs freeing
|
|
* @dynamic: temporary object for nop functions; dynamically allocated
|
|
* @patched: the object's funcs have been added to the klp_ops list
|
|
*/
|
|
struct klp_object {
|
|
/* external */
|
|
const char *name;
|
|
struct klp_func *funcs;
|
|
struct klp_callbacks callbacks;
|
|
|
|
/* internal */
|
|
struct kobject kobj;
|
|
struct list_head func_list;
|
|
struct list_head node;
|
|
struct module *mod;
|
|
bool kobj_added;
|
|
bool dynamic;
|
|
bool patched;
|
|
};
|
|
|
|
/**
|
|
* struct klp_patch - patch structure for live patching
|
|
* @mod: reference to the live patch module
|
|
* @objs: object entries for kernel objects to be patched
|
|
* @replace: replace all actively used patches
|
|
* @list: list node for global list of actively used patches
|
|
* @kobj: kobject for sysfs resources
|
|
* @obj_list: dynamic list of the object entries
|
|
* @kobj_added: @kobj has been added and needs freeing
|
|
* @enabled: the patch is enabled (but operation may be incomplete)
|
|
* @forced: was involved in a forced transition
|
|
* @free_work: patch cleanup from workqueue-context
|
|
* @finish: for waiting till it is safe to remove the patch module
|
|
*/
|
|
struct klp_patch {
|
|
/* external */
|
|
struct module *mod;
|
|
struct klp_object *objs;
|
|
bool replace;
|
|
|
|
/* internal */
|
|
struct list_head list;
|
|
struct kobject kobj;
|
|
struct list_head obj_list;
|
|
bool kobj_added;
|
|
bool enabled;
|
|
bool forced;
|
|
struct work_struct free_work;
|
|
struct completion finish;
|
|
};
|
|
|
|
#define klp_for_each_object_static(patch, obj) \
|
|
for (obj = patch->objs; obj->funcs || obj->name; obj++)
|
|
|
|
#define klp_for_each_object_safe(patch, obj, tmp_obj) \
|
|
list_for_each_entry_safe(obj, tmp_obj, &patch->obj_list, node)
|
|
|
|
#define klp_for_each_object(patch, obj) \
|
|
list_for_each_entry(obj, &patch->obj_list, node)
|
|
|
|
#define klp_for_each_func_static(obj, func) \
|
|
for (func = obj->funcs; \
|
|
func->old_name || func->new_func || func->old_sympos; \
|
|
func++)
|
|
|
|
#define klp_for_each_func_safe(obj, func, tmp_func) \
|
|
list_for_each_entry_safe(func, tmp_func, &obj->func_list, node)
|
|
|
|
#define klp_for_each_func(obj, func) \
|
|
list_for_each_entry(func, &obj->func_list, node)
|
|
|
|
int klp_enable_patch(struct klp_patch *);
|
|
|
|
void arch_klp_init_object_loaded(struct klp_patch *patch,
|
|
struct klp_object *obj);
|
|
|
|
/* Called from the module loader during module coming/going states */
|
|
int klp_module_coming(struct module *mod);
|
|
void klp_module_going(struct module *mod);
|
|
|
|
void klp_copy_process(struct task_struct *child);
|
|
void klp_update_patch_state(struct task_struct *task);
|
|
|
|
static inline bool klp_patch_pending(struct task_struct *task)
|
|
{
|
|
return test_tsk_thread_flag(task, TIF_PATCH_PENDING);
|
|
}
|
|
|
|
static inline bool klp_have_reliable_stack(void)
|
|
{
|
|
return IS_ENABLED(CONFIG_STACKTRACE) &&
|
|
IS_ENABLED(CONFIG_HAVE_RELIABLE_STACKTRACE);
|
|
}
|
|
|
|
typedef int (*klp_shadow_ctor_t)(void *obj,
|
|
void *shadow_data,
|
|
void *ctor_data);
|
|
typedef void (*klp_shadow_dtor_t)(void *obj, void *shadow_data);
|
|
|
|
void *klp_shadow_get(void *obj, unsigned long id);
|
|
void *klp_shadow_alloc(void *obj, unsigned long id,
|
|
size_t size, gfp_t gfp_flags,
|
|
klp_shadow_ctor_t ctor, void *ctor_data);
|
|
void *klp_shadow_get_or_alloc(void *obj, unsigned long id,
|
|
size_t size, gfp_t gfp_flags,
|
|
klp_shadow_ctor_t ctor, void *ctor_data);
|
|
void klp_shadow_free(void *obj, unsigned long id, klp_shadow_dtor_t dtor);
|
|
void klp_shadow_free_all(unsigned long id, klp_shadow_dtor_t dtor);
|
|
|
|
#else /* !CONFIG_LIVEPATCH */
|
|
|
|
static inline int klp_module_coming(struct module *mod) { return 0; }
|
|
static inline void klp_module_going(struct module *mod) {}
|
|
static inline bool klp_patch_pending(struct task_struct *task) { return false; }
|
|
static inline void klp_update_patch_state(struct task_struct *task) {}
|
|
static inline void klp_copy_process(struct task_struct *child) {}
|
|
|
|
#endif /* CONFIG_LIVEPATCH */
|
|
|
|
#endif /* _LINUX_LIVEPATCH_H_ */
|