mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-28 11:18:45 +07:00
fe5192ac81
Currently, we enable the device before we enable the device trigger. At
high frequencies, this can cause interrupts that don't yet have a poll
function associated with them and are thus treated as spurious. At high
frequencies with level interrupts, this can even cause an interrupt storm
of repeated spurious interrupts (~100,000 on my Beagleboard with the
LSM9DS1 magnetometer). If these repeat too much, the interrupt will get
disabled and the device will stop functioning.
To prevent these problems, enable the device prior to enabling the device
trigger, and disable the divec prior to disabling the trigger. This means
there's no window of time during which the device creates interrupts but we
have no trigger to answer them.
Fixes: 90efe05562 ("iio: st_sensors: harden interrupt handling")
Signed-off-by: Martin Kelly <martin@martingkelly.com>
Tested-by: Denis Ciocca <denis.ciocca@st.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
91 lines
2.2 KiB
C
91 lines
2.2 KiB
C
/*
|
|
* STMicroelectronics magnetometers driver
|
|
*
|
|
* Copyright 2012-2013 STMicroelectronics Inc.
|
|
*
|
|
* Denis Ciocca <denis.ciocca@st.com>
|
|
*
|
|
* Licensed under the GPL-2.
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/stat.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/i2c.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/iio/iio.h>
|
|
#include <linux/iio/buffer.h>
|
|
#include <linux/iio/trigger_consumer.h>
|
|
#include <linux/iio/triggered_buffer.h>
|
|
|
|
#include <linux/iio/common/st_sensors.h>
|
|
#include "st_magn.h"
|
|
|
|
int st_magn_trig_set_state(struct iio_trigger *trig, bool state)
|
|
{
|
|
struct iio_dev *indio_dev = iio_trigger_get_drvdata(trig);
|
|
|
|
return st_sensors_set_dataready_irq(indio_dev, state);
|
|
}
|
|
|
|
static int st_magn_buffer_postenable(struct iio_dev *indio_dev)
|
|
{
|
|
int err;
|
|
struct st_sensor_data *mdata = iio_priv(indio_dev);
|
|
|
|
mdata->buffer_data = kmalloc(indio_dev->scan_bytes, GFP_KERNEL);
|
|
if (mdata->buffer_data == NULL) {
|
|
err = -ENOMEM;
|
|
goto allocate_memory_error;
|
|
}
|
|
|
|
err = iio_triggered_buffer_postenable(indio_dev);
|
|
if (err < 0)
|
|
goto st_magn_buffer_postenable_error;
|
|
|
|
return st_sensors_set_enable(indio_dev, true);
|
|
|
|
st_magn_buffer_postenable_error:
|
|
kfree(mdata->buffer_data);
|
|
allocate_memory_error:
|
|
return err;
|
|
}
|
|
|
|
static int st_magn_buffer_predisable(struct iio_dev *indio_dev)
|
|
{
|
|
int err;
|
|
struct st_sensor_data *mdata = iio_priv(indio_dev);
|
|
|
|
err = st_sensors_set_enable(indio_dev, false);
|
|
if (err < 0)
|
|
goto st_magn_buffer_predisable_error;
|
|
|
|
err = iio_triggered_buffer_predisable(indio_dev);
|
|
|
|
st_magn_buffer_predisable_error:
|
|
kfree(mdata->buffer_data);
|
|
return err;
|
|
}
|
|
|
|
static const struct iio_buffer_setup_ops st_magn_buffer_setup_ops = {
|
|
.postenable = &st_magn_buffer_postenable,
|
|
.predisable = &st_magn_buffer_predisable,
|
|
};
|
|
|
|
int st_magn_allocate_ring(struct iio_dev *indio_dev)
|
|
{
|
|
return iio_triggered_buffer_setup(indio_dev, NULL,
|
|
&st_sensors_trigger_handler, &st_magn_buffer_setup_ops);
|
|
}
|
|
|
|
void st_magn_deallocate_ring(struct iio_dev *indio_dev)
|
|
{
|
|
iio_triggered_buffer_cleanup(indio_dev);
|
|
}
|
|
|
|
MODULE_AUTHOR("Denis Ciocca <denis.ciocca@st.com>");
|
|
MODULE_DESCRIPTION("STMicroelectronics magnetometers buffer");
|
|
MODULE_LICENSE("GPL v2");
|