linux_dsm_epyc7002/drivers/net/ethernet/qlogic
Arnd Bergmann e58f95831e qlge: avoid memcpy buffer overflow
gcc-8.0.0 (snapshot) points out that we copy a variable-length string
into a fixed length field using memcpy() with the destination length,
and that ends up copying whatever follows the string:

    inlined from 'ql_core_dump' at drivers/net/ethernet/qlogic/qlge/qlge_dbg.c:1106:2:
drivers/net/ethernet/qlogic/qlge/qlge_dbg.c:708:2: error: 'memcpy' reading 15 bytes from a region of size 14 [-Werror=stringop-overflow=]
  memcpy(seg_hdr->description, desc, (sizeof(seg_hdr->description)) - 1);

Changing it to use strncpy() will instead zero-pad the destination,
which seems to be the right thing to do here.

The bug is probably harmless, but it seems like a good idea to address
it in stable kernels as well, if only for the purpose of building with
gcc-8 without warnings.

Fixes: a61f802613 ("qlge: Add ethtool register dump function.")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-08-24 14:00:57 -07:00
..
netxen netxen: fix incorrect loop counter decrement 2017-08-18 10:58:33 -07:00
qed qed: Fix a memory allocation failure test in 'qed_mcp_cmd_init()' 2017-08-07 14:56:15 -07:00
qede qed*: Set rdma generic functions prefix 2017-06-20 12:34:08 -04:00
qlcnic qlcnic: Fix tunnel offload for 82xx adapters 2017-06-02 14:30:58 -04:00
qlge qlge: avoid memcpy buffer overflow 2017-08-24 14:00:57 -07:00
Kconfig qed: Add support for hardware offloaded FCoE. 2017-02-19 18:10:42 -05:00
Makefile qede: Add basic Network driver 2015-10-27 19:34:47 -07:00
qla3xxx.c net: qlogic: qla3xxx: use new api ethtool_{get|set}_link_ksettings 2017-02-20 10:27:17 -05:00
qla3xxx.h