Saravana Kannan 21c27f0658 driver core: Fix SYNC_STATE_ONLY device link implementation ... When SYNC_STATE_ONLY support was added in commit 05ef983e0d ("driver core: Add device link support for SYNC_STATE_ONLY flag"), device_link_add() incorrectly skipped adding the new SYNC_STATE_ONLY device link to the supplier's and consumer's "device link" list. This causes multiple issues: - The device link is lost forever from driver core if the caller didn't keep track of it (caller typically isn't expected to). This is a memory leak. - The device link is also never visible to any other code path after device_link_add() returns. If we fix the "device link" list handling, that exposes a bunch of issues. 1. The device link "status" state management code rightfully doesn't handle the case where a DL_FLAG_MANAGED device link exists between a supplier and consumer, but the consumer manages to probe successfully before the supplier. The addition of DL_FLAG_SYNC_STATE_ONLY links break this assumption. This causes device_links_driver_bound() to throw a warning when this happens. Since DL_FLAG_SYNC_STATE_ONLY device links are mainly used for creating proxy device links for child device dependencies and aren't useful once the consumer device probes successfully, this patch just deletes DL_FLAG_SYNC_STATE_ONLY device links once its consumer device probes. This way, we avoid the warning, free up some memory and avoid complicating the device links "status" state management code. 2. Creating a DL_FLAG_STATELESS device link between two devices that already have a DL_FLAG_SYNC_STATE_ONLY device link will result in the DL_FLAG_STATELESS flag not getting set correctly. This patch also fixes this. Lastly, this patch also fixes minor whitespace issues. Cc: stable@vger.kernel.org Fixes: 05ef983e0d ("driver core: Add device link support for SYNC_STATE_ONLY flag") Signed-off-by: Saravana Kannan <saravanak@google.com> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Link: https://lore.kernel.org/r/20200519063000.128819-1-saravanak@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2020-05-19 17:01:58 +02:00
..
firmware_loader	firmware_loader: revert removal of the fw_fallback_config export	2020-04-26 10:42:15 +02:00
power	PM: sleep: core: Switch back to async_schedule_dev()	2020-04-22 16:36:18 +02:00
regmap
test
arch_topology.c	arm64 updates for 5.7:	2020-03-31 10:05:01 -07:00
attribute_container.c
base.h
bus.c
cacheinfo.c
class.c
component.c	component: Silence bind error on -EPROBE_DEFER	2020-04-28 17:54:15 +02:00
container.c
core.c	driver core: Fix SYNC_STATE_ONLY device link implementation	2020-05-19 17:01:58 +02:00
cpu.c	CPU (hotplug) updates:	2020-03-30 18:06:39 -07:00
dd.c	driver core: Ensure wait_for_device_probe() waits until the deferred_probe_timeout fires	2020-04-28 17:57:13 +02:00
devcon.c
devcoredump.c
devres.c
devtmpfs.c
driver.c
firmware.c
hypervisor.c
init.c
isa.c
Kconfig
Makefile
map.c
memory.c	mm/memory_hotplug: allow to specify a default online_type	2020-04-07 10:43:41 -07:00
module.c
node.c	mm/sparse: rename pfn_present() to pfn_in_present_section()	2020-04-02 09:35:30 -07:00
pinctrl.c
platform-msi.c
platform.c	driver core: platform: Initialize dma_parms for platform devices	2020-04-28 17:44:33 +02:00
property.c	device property: Export fwnode_get_name()	2020-03-16 07:47:58 +01:00
soc.c
swnode.c	Revert "software node: Simplify software_node_release() function"	2020-03-04 22:31:44 +01:00
syscore.c
topology.c
transport_class.c