Bodo Stroesser f2e6b75f6e scsi: target: Put lun_ref at end of tmr processing ... Testing with Loopback I found that, after a Loopback LUN has executed a TMR, I can no longer unlink the LUN. The rm command hangs in transport_clear_lun_ref() at wait_for_completion(&lun->lun_shutdown_comp) The reason is, that transport_lun_remove_cmd() is not called at the end of target_tmr_work(). It seems, that in other fabrics this call happens implicitly when the fabric drivers call transport_generic_free_cmd() during their ->queue_tm_rsp(). Unfortunately Loopback seems to not comply to the common way of calling transport_generic_free_cmd() from ->queue_*(). Instead it calls transport_generic_free_cmd() from its ->check_stop_free() only. But the ->check_stop_free() is called by transport_cmd_check_stop_to_fabric() after it has reset the se_cmd->se_lun pointer. Therefore the following transport_generic_free_cmd() skips the transport_lun_remove_cmd(). So this patch re-adds the transport_lun_remove_cmd() at the end of target_tmr_work(), which was removed during commit 2c9fa49e10 ("scsi: target/core: Make ABORT and LUN RESET handling synchronous"). For fabrics using transport_generic_free_cmd() in the usual way the double call to transport_lun_remove_cmd() doesn't harm, as transport_lun_remove_cmd() checks for this situation and does not release lun_ref twice. Link: https://lore.kernel.org/r/20200513153443.3554-1-bstroesser@ts.fujitsu.com Fixes: 2c9fa49e10 ("scsi: target/core: Make ABORT and LUN RESET handling synchronous") Cc: stable@vger.kernel.org Tested-by: Bryant G. Ly <bryangly@gmail.com> Reviewed-by: Bart van Assche <bvanassche@acm.org> Signed-off-by: Bodo Stroesser <bstroesser@ts.fujitsu.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>		2020-05-14 20:27:05 -04:00
..
iscsi	SCSI misc on 20200402	2020-04-02 17:03:53 -07:00
loopback
sbp
tcm_fc	scsi: libfc: remove unnecessary assertion on ep variable	2019-12-19 22:08:55 -05:00
Kconfig
Makefile
target_core_alua.c
target_core_alua.h
target_core_configfs.c	scsi: target: use an enum to track emulate_ua_intlck_ctrl	2020-02-21 17:37:16 -05:00
target_core_device.c	scsi: target: use an enum to track emulate_ua_intlck_ctrl	2020-02-21 17:37:16 -05:00
target_core_fabric_configfs.c
target_core_fabric_lib.c	scsi: target: fix PR IN / READ FULL STATUS for FC	2020-04-13 14:00:41 -04:00
target_core_file.c
target_core_file.h
target_core_hba.c
target_core_iblock.c	scsi: target/iblock: fix WRITE SAME zeroing	2020-04-22 00:02:13 -04:00
target_core_iblock.h
target_core_internal.h
target_core_pr.c
target_core_pr.h
target_core_pscsi.c
target_core_pscsi.h
target_core_rd.c
target_core_rd.h
target_core_sbc.c
target_core_spc.c	scsi: target: use an enum to track emulate_ua_intlck_ctrl	2020-02-21 17:37:16 -05:00
target_core_stat.c
target_core_tmr.c	scsi: target: convert boolean se_dev_attrib types to bool	2020-02-21 17:37:14 -05:00
target_core_tpg.c	scsi: target: Remove tpg_list and se_portal_group.se_tpg_node	2019-10-03 22:00:09 -04:00
target_core_transport.c	scsi: target: Put lun_ref at end of tmr processing	2020-05-14 20:27:05 -04:00
target_core_ua.c	scsi: target: use an enum to track emulate_ua_intlck_ctrl	2020-02-21 17:37:16 -05:00
target_core_ua.h
target_core_user.c	scsi: target: tcmu: reset_ring should reset TCMU_DEV_BIT_BROKEN	2020-04-13 14:03:20 -04:00
target_core_xcopy.c	scsi: target: use the stack for XCOPY passthrough cmds	2020-03-29 18:10:59 -04:00
target_core_xcopy.h	scsi: target: use the stack for XCOPY passthrough cmds	2020-03-29 18:10:59 -04:00