linux_dsm_epyc7002/net/nfc/nci
Johan Hovold 20777bc57c NFC: fix broken device allocation
Commit 7eda8b8e96 ("NFC: Use IDR library to assing NFC devices IDs")
moved device-id allocation and struct-device initialisation from
nfc_allocate_device() to nfc_register_device().

This broke just about every nfc-device-registration error path, which
continue to call nfc_free_device() that tries to put the device
reference of the now uninitialised (but zeroed) struct device:

kobject: '(null)' (ce316420): is not initialized, yet kobject_put() is being called.

The late struct-device initialisation also meant that various work
queues whose names are derived from the nfc device name were also
misnamed:

  421 root         0 SW<  [(null)_nci_cmd_]
  422 root         0 SW<  [(null)_nci_rx_w]
  423 root         0 SW<  [(null)_nci_tx_w]

Move the id-allocation and struct-device initialisation back to
nfc_allocate_device() and fix up the single call site which did not use
nfc_free_device() in its error path.

Fixes: 7eda8b8e96 ("NFC: Use IDR library to assing NFC devices IDs")
Cc: stable <stable@vger.kernel.org>     # 3.8
Cc: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
2017-06-18 23:57:58 +02:00
..
core.c NFC: fix broken device allocation 2017-06-18 23:57:58 +02:00
data.c networking: make skb_push & __skb_push return void pointers 2017-06-16 11:48:40 -04:00
hci.c networking: add and use skb_put_u8() 2017-06-16 11:48:40 -04:00
Kconfig NFC: NCI: move generic spi driver to a module 2015-10-27 04:21:38 +01:00
lib.c nfc: Fix FSF address in file headers 2013-12-11 10:56:21 -05:00
Makefile NFC: NCI: move generic spi driver to a module 2015-10-27 04:21:38 +01:00
ntf.c nfc: nci: Add an additional parameter to identify a connection id 2016-05-04 01:43:21 +02:00
rsp.c nfc: nci: Add an additional parameter to identify a connection id 2016-05-04 01:43:21 +02:00
spi.c networking: add and use skb_put_u8() 2017-06-16 11:48:40 -04:00
uart.c networking: add and use skb_put_u8() 2017-06-16 11:48:40 -04:00