linux_dsm_epyc7002/drivers/net/ethernet/intel
Alexander Duyck 1f4702aa25 ixgbe: Fix possible memory leak in ixgbe_set_ringparam
We were not correctly freeing the temporary rings on error in
ixgbe_set_ring_param.  In order to correct this I am unwinding a number of
changes that were made in order to get things back to the original working
form with modification for the current ring layouts.

This approach has multiple advantages including a smaller memory footprint,
and the fact that the interface is stopped while we are allocating the rings
meaning that there is less potential for some sort of memory corruption on the
ring.

The only disadvantage I see with this approach is that on a Rx allocation
failure we will report an error and only update the Tx rings.  However the
adapter should be fully functional in this state and the likelihood of such
an error is very low.  In addition it is not unreasonable to expect the
user to need to recheck the ring configuration should they experience an
error setting the ring sizes.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
2012-10-22 21:17:19 -07:00
..
e1000 Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next 2012-10-02 13:38:27 -07:00
e1000e e1000e: Change wthresh to 1 to avoid possible Tx stalls 2012-10-10 22:59:18 -04:00
igb igb: Split igb_update_dca into separate Tx and Rx functions 2012-10-19 04:42:13 -07:00
igbvf netdev: make pci_error_handlers const 2012-09-07 16:35:00 -06:00
ixgb netdev: make pci_error_handlers const 2012-09-07 16:35:00 -06:00
ixgbe ixgbe: Fix possible memory leak in ixgbe_set_ringparam 2012-10-22 21:17:19 -07:00
ixgbevf ixgbevf: Add VF DCB + SR-IOV support 2012-10-22 21:15:35 -07:00
e100.c netdev: make pci_error_handlers const 2012-09-07 16:35:00 -06:00
Kconfig Kconfig: Fix Kconfig for Intel ixgbe and igb PTP support. 2012-06-20 00:52:54 -07:00
Makefile intel: Move the Intel wired LAN drivers 2011-08-10 20:03:27 -07:00