mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2025-02-25 05:11:18 +07:00
199af8a06d
commit b65ba0c362be665192381cc59e3ac3ef6f0dd1e1 upstream.
In commit 92af4fc6ec33 ("usb: musb: Fix suspend with devices
connected for a64"), the logic to support the
MUSB_QUIRK_B_DISCONNECT_99 quirk was modified to only conditionally
schedule the musb->irq_work delayed work.
This commit badly breaks ECM Gadget on AM335X. Indeed, with this
commit, one can observe massive packet loss:
$ ping 192.168.0.100
...
15 packets transmitted, 3 received, 80% packet loss, time 14316ms
Reverting this commit brings back a properly functioning ECM
Gadget. An analysis of the commit seems to indicate that a mistake was
made: the previous code was not falling through into the
MUSB_QUIRK_B_INVALID_VBUS_91, but now it is, unless the condition is
taken.
Changing the logic to be as it was before the problematic commit *and*
only conditionally scheduling musb->irq_work resolves the regression:
$ ping 192.168.0.100
...
64 packets transmitted, 64 received, 0% packet loss, time 64475ms
Fixes: 92af4fc6ec33 ("usb: musb: Fix suspend with devices connected for a64")
Cc: stable@vger.kernel.org
Tested-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Tested-by: Drew Fustini <drew@beagleboard.org>
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Link: https://lore.kernel.org/r/20210528140446.278076-1-thomas.petazzoni@bootlin.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
||
|---|---|---|
| .. | ||
| am35x.c | ||
| cppi_dma.c | ||
| cppi_dma.h | ||
| da8xx.c | ||
| davinci.c | ||
| davinci.h | ||
| jz4740.c | ||
| Kconfig | ||
| Makefile | ||
| mediatek.c | ||
| musb_core.c | ||
| musb_core.h | ||
| musb_cppi41.c | ||
| musb_debug.h | ||
| musb_debugfs.c | ||
| musb_dma.h | ||
| musb_dsps.c | ||
| musb_gadget_ep0.c | ||
| musb_gadget.c | ||
| musb_gadget.h | ||
| musb_host.c | ||
| musb_host.h | ||
| musb_io.h | ||
| musb_regs.h | ||
| musb_trace.c | ||
| musb_trace.h | ||
| musb_virthub.c | ||
| musbhsdma.c | ||
| omap2430.c | ||
| omap2430.h | ||
| sunxi.c | ||
| tusb6010_omap.c | ||
| tusb6010.c | ||
| tusb6010.h | ||
| ux500_dma.c | ||
| ux500.c | ||