Oleg Nesterov 201d3dfa4d dlm: kill the unnecessary and wrong device_close()->recalc_sigpending() ... device_close()->recalc_sigpending() is not needed, sigprocmask() takes care of TIF_SIGPENDING correctly. And without ->siglock it is racy and wrong, it can wrongly clear TIF_SIGPENDING and miss a signal. But even with this patch device_close() is still buggy: 1. sigprocmask() should not be used, we have set_task_blocked(), but this is minor. 2. We should never block SIGKILL or SIGSTOP, and this is what the code tries to do. 3. This can't protect against SIGKILL or SIGSTOP anyway. Another thread can do signal_wake_up(), say, do_signal_stop() or complete_signal() or debugger. 4. sigprocmask(SIG_BLOCK, allsigs) doesn't necessarily clears TIF_SIGPENDING, say, freezing() or ->jobctl. 5. device_write() looks equally wrong by the same reason. Looks like, this tries to protect some wait_event_interruptible() logic from signals, it should be turned into uninterruptible wait. Or we need to implement something like signals_stop/start for such a use-case. Signed-off-by: Oleg Nesterov <oleg@redhat.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2013-08-09 10:48:20 -07:00
..
ast.c
ast.h
config.c	dlm: config: using strlcpy instead of strncpy	2013-06-25 12:53:06 -05:00
config.h
debug_fs.c
dir.c
dir.h
dlm_internal.h	dlm: avoid scanning unchanged toss lists	2013-01-07 12:02:49 -06:00
Kconfig	fs/dlm: remove CONFIG_EXPERIMENTAL	2012-11-01 15:27:24 -05:00
lock.c	dlm: Avoid LVB truncation	2013-06-26 11:38:02 -05:00
lock.h
lockspace.c	dlm: log an error for unmanaged lockspaces	2013-06-25 12:53:20 -05:00
lockspace.h
lowcomms.c	dlm: remove duplicated include from lowcomms.c	2013-06-19 09:52:09 -05:00
lowcomms.h
lvb_table.h
main.c
Makefile
member.c
member.h
memory.c
memory.h
midcomms.c
midcomms.h
netlink.c
plock.c	dlm: avoid unnecessary posix unlock	2013-04-08 12:03:15 -05:00
rcom.c
rcom.h
recover.c	dlm: convert to idr_alloc()	2013-02-27 19:10:19 -08:00
recover.h
recoverd.c
recoverd.h
requestqueue.c
requestqueue.h
user.c	dlm: kill the unnecessary and wrong device_close()->recalc_sigpending()	2013-08-09 10:48:20 -07:00
user.h
util.c
util.h