Milton Miller 1b0ff89852 tg3: Avoid NULL pointer dereference in tg3_io_error_detected() ... While the driver is probing the adapter, an error may occur before the netdev structure is allocated and attached to pci_dev. In this case, not only netdev isn't available, but the tg3 private structure is also not available as it is just math from the NULL pointer, so dereferences must be skipped. The following trace is seen when the error is triggered: [1.402247] Unable to handle kernel paging request for data at address 0x00001a99 [1.402410] Faulting instruction address: 0xc0000000007e33f8 [1.402450] Oops: Kernel access of bad area, sig: 11 [#1] [1.402481] SMP NR_CPUS=2048 NUMA PowerNV [1.402513] Modules linked in: [1.402545] CPU: 0 PID: 651 Comm: eehd Not tainted 4.4.0-36-generic #55-Ubuntu [1.402591] task: c000001fe4e42a20 ti: c000001fe4e88000 task.ti: c000001fe4e88000 [1.402742] NIP: c0000000007e33f8 LR: c0000000007e3164 CTR: c000000000595ea0 [1.402787] REGS: c000001fe4e8b790 TRAP: 0300 Not tainted (4.4.0-36-generic) [1.402832] MSR: 9000000100009033 <SF,HV,EE,ME,IR,DR,RI,LE> CR: 28000422 XER: 20000000 [1.403058] CFAR: c000000000008468 DAR: 0000000000001a99 DSISR: 42000000 SOFTE: 1 GPR00: c0000000007e3164 c000001fe4e8ba10 c0000000015c5e00 0000000000000000 GPR04: 0000000000000001 0000000000000000 0000000000000039 0000000000000299 GPR08: 0000000000000000 0000000000000001 c000001fe4e88000 0000000000000006 GPR12: 0000000000000000 c00000000fb40000 c0000000000e6558 c000003ca1bffd00 GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 GPR20: 0000000000000000 0000000000000000 0000000000000000 c000000000d52768 GPR24: c000000000d52740 0000000000000100 c000003ca1b52000 0000000000000002 GPR28: 0000000000000900 0000000000000000 c00000000152a0c0 c000003ca1b52000 [1.404226] NIP [c0000000007e33f8] tg3_io_error_detected+0x308/0x340 [1.404265] LR [c0000000007e3164] tg3_io_error_detected+0x74/0x340 This patch avoids the NULL pointer dereference by moving the access after the netdev NULL pointer check on tg3_io_error_detected(). Also, we add a check for netdev being NULL on tg3_io_resume() [suggested by Michael Chan]. Fixes: 0486a063b1 ("tg3: prevent ifup/ifdown during PCI error recovery") Fixes: dfc8f37031 ("net/tg3: Release IRQs on permanent error") Tested-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com> Signed-off-by: Milton Miller <miltonm@us.ibm.com> Signed-off-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com> Acked-by: Michael Chan <michael.chan@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2016-09-30 01:27:27 -04:00
..
bnx2x	bnx2x: don't reset chip on cleanup if PCI function is offline	2016-09-01 22:49:49 -07:00
bnxt	bnxt_en: Fix TX push operation on ARM64.	2016-09-06 13:59:17 -07:00
genet	Revert "net: ethernet: bcmgenet: use phydev from struct net_device"	2016-09-27 07:41:12 -04:00
b44.c	phy: Add API for {un}registering an mdio device to a bus.	2016-01-07 14:31:26 -05:00
b44.h	b44: Utilize BRCM_PSEUDO_PHY_ADDR	2015-06-10 23:33:58 -07:00
bcm63xx_enet.c	net: bcm63xx: avoid possible null pointer dereference	2016-08-01 13:32:51 -07:00
bcm63xx_enet.h	bcm63xx_enet: add support Broadcom BCM6345 Ethernet	2013-06-13 17:22:08 -07:00
bcmsysport.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2016-07-06 10:35:22 -07:00
bcmsysport.h	net: ethernet: bcmsysport: use phydev from struct net_device	2016-06-19 16:15:55 -07:00
bgmac-bcma-mdio.c	net: ethernet: bgmac: Add platform device support	2016-07-09 18:10:41 -04:00
bgmac-bcma.c	net: bgmac: fix reversed check for MII registration error	2016-08-18 23:23:41 -07:00
bgmac-platform.c	net: ethernet: bgmac: Remove redundant dev_err call in bgmac_probe()	2016-07-13 18:07:56 -07:00
bgmac.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2016-07-24 00:53:32 -04:00
bgmac.h	net: ethernet: bgmac: Add platform device support	2016-07-09 18:10:41 -04:00
bnx2_fw.h	bnx2-cnic: Driver Rebranding Changes	2015-02-20 15:46:49 -05:00
bnx2.c	bnx2: Reset device during driver initialization	2016-09-13 11:24:29 -04:00
bnx2.h	BNX2: fix a Null Pointer for stats_blk	2015-10-11 05:06:21 -07:00
cnic_defs.h	cnic: Rebranding cnic driver.	2014-06-25 16:27:27 -07:00
cnic_if.h	cnic: Add the interfaces to get FC-NPIV table.	2015-08-06 21:54:12 -07:00
cnic.c	cnic: call cp->stop_hw() in cnic_start_hw() on allocation failure	2016-05-06 15:44:54 -04:00
cnic.h	cnic: Rebranding cnic driver.	2014-06-25 16:27:27 -07:00
Kconfig	net: ethernet: bgmac: Add platform device support	2016-07-09 18:10:41 -04:00
Makefile	net: ethernet: bgmac: Add platform device support	2016-07-09 18:10:41 -04:00
sb1250-mac.c	treewide: replace dev->trans_start update with helper	2016-05-04 14:16:49 -04:00
tg3.c	tg3: Avoid NULL pointer dereference in tg3_io_error_detected()	2016-09-30 01:27:27 -04:00
tg3.h	mdio: Move allocation of interrupts into core	2016-01-07 14:31:26 -05:00