Francois Romieu 307723255a e1000: remove dead e1000_init_eeprom_params calls ... The device probe method e1000_probe calls e1000_init_eeprom_params itself so there's no reason to call it again from e1000_do_write_eeprom or e1000_do_read_eeprom. The sentence above assumes that e1000_init_eeprom_params is effective. e1000_init_eeprom_params depends mostly on hw->mac_type and e1000_probe bails out early if it can't set mac_type (see e1000_init_hw_struct, then e1000_set_mac_type), qed. Btw, if effective, the removed paths would had been deadlock prone when e1000_eeprom_spi was set: -> e1000_write_eeprom (takes e1000_eeprom_lock) -> e1000_do_write_eeprom -> e1000_init_eeprom_params -> e1000_read_eeprom (takes e1000_eeprom_lock) (same narrative with e1000_read_eeprom -> e1000_do_read_eeprom etc.) As a final note, the candidate deadlock above can't happen in e1000_probe due to the way eeprom->word_size is set / tested. Signed-off-by: Francois Romieu <romieu@fr.zoreil.com> Tested-by: Aaron Brown <aaron.f.brown@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>		2015-09-22 15:58:28 -07:00
..
e1000_ethtool.c	e1000: fix time comparison	2015-01-22 18:10:15 -08:00
e1000_hw.c	e1000: remove dead e1000_init_eeprom_params calls	2015-09-22 15:58:28 -07:00
e1000_hw.h	e1000: move e1000_tbi_adjust_stats to where its used	2014-09-12 00:51:10 -07:00
e1000_main.c	e1000: Replace e1000_free_frag with skb_free_frag	2015-05-12 10:39:27 -04:00
e1000_osdep.h
e1000_param.c	e1000: fix whitespace issues and multi-line comments	2013-02-15 21:46:37 -08:00
e1000.h	e1000: convert to build_skb	2014-09-12 02:16:46 -07:00
Makefile