Julian Wiedmann 7c4046b1c5 Revert "net: sched: make newly activated qdiscs visible" ... This reverts commit 4cda75275f from net-next. Brown bag time. Michal noticed that this change doesn't work at all when netif_set_real_num_tx_queues() gets called prior to an initial dev_activate(), as for instance igb does. Doing so dies with: [ 40.579142] BUG: kernel NULL pointer dereference, address: 0000000000000400 [ 40.586922] #PF: supervisor read access in kernel mode [ 40.592668] #PF: error_code(0x0000) - not-present page [ 40.598405] PGD 0 P4D 0 [ 40.601234] Oops: 0000 [#1] PREEMPT SMP PTI [ 40.605909] CPU: 18 PID: 1681 Comm: wickedd Tainted: G E 5.6.0-rc3-ethnl.50-default #1 [ 40.616205] Hardware name: Intel Corporation S2600CP/S2600CP, BIOS RMLSDP.86I.R3.27.D685.1305151734 05/15/2013 [ 40.627377] RIP: 0010:qdisc_hash_add.part.22+0x2e/0x90 [ 40.633115] Code: 00 55 53 89 f5 48 89 fb e8 2f 9b fb ff 85 c0 74 44 48 8b 43 40 48 8b 08 69 43 38 47 86 c8 61 c1 e8 1c 48 83 e8 80 48 8d 14 c1 <48> 8b 04 c1 48 8d 4b 28 48 89 53 30 48 89 43 28 48 85 c0 48 89 0a [ 40.654080] RSP: 0018:ffffb879864934d8 EFLAGS: 00010203 [ 40.659914] RAX: 0000000000000080 RBX: ffffffffb8328d80 RCX: 0000000000000000 [ 40.667882] RDX: 0000000000000400 RSI: 0000000000000000 RDI: ffffffffb831faa0 [ 40.675849] RBP: 0000000000000000 R08: ffffa0752c8b9088 R09: ffffa0752c8b9208 [ 40.683816] R10: 0000000000000006 R11: 0000000000000000 R12: ffffa0752d734000 [ 40.691783] R13: 0000000000000008 R14: 0000000000000000 R15: ffffa07113c18000 [ 40.699750] FS: 00007f94548e5880(0000) GS:ffffa0752e980000(0000) knlGS:0000000000000000 [ 40.708782] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 40.715189] CR2: 0000000000000400 CR3: 000000082b6ae006 CR4: 00000000001606e0 [ 40.723156] Call Trace: [ 40.725888] dev_qdisc_set_real_num_tx_queues+0x61/0x90 [ 40.731725] netif_set_real_num_tx_queues+0x94/0x1d0 [ 40.737286] __igb_open+0x19a/0x5d0 [igb] [ 40.741767] __dev_open+0xbb/0x150 [ 40.745567] __dev_change_flags+0x157/0x1a0 [ 40.750240] dev_change_flags+0x23/0x60 [...] Fixes: 4cda75275f ("net: sched: make newly activated qdiscs visible") Reported-by: Michal Kubecek <mkubecek@suse.cz> CC: Michal Kubecek <mkubecek@suse.cz> CC: Eric Dumazet <edumazet@google.com> CC: Jamal Hadi Salim <jhs@mojatatu.com> CC: Cong Wang <xiyou.wangcong@gmail.com> CC: Jiri Pirko <jiri@resnulli.us> Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2020-03-12 11:19:24 -07:00
..
6lowpan
9p
802	net: 802: psnap.c: Use built-in RCU list checking	2020-02-24 13:02:53 -08:00
8021q	net: vlan: suppress "failed to kill vid" warnings	2020-02-17 14:30:54 -08:00
appletalk
atm
ax25
batman-adv	batman-adv: Replace zero-length array with flexible-array member	2020-02-17 22:43:42 +01:00
bluetooth
bpf	bpf/tests: Use migrate disable instead of preempt disable	2020-02-24 16:20:09 -08:00
bpfilter
bridge	net: bridge: fix stale eth hdr pointer in br_dev_xmit	2020-02-24 11:11:19 -08:00
caif
can
ceph
core	Revert "net: sched: make newly activated qdiscs visible"	2020-03-12 11:19:24 -07:00
dcb
dccp	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next	2020-02-29 15:53:35 -08:00
decnet
dns_resolver
dsa	flow_offload: check for basic action hw stats type	2020-03-08 21:07:48 -07:00
ethernet
ethtool	ethtool: add infrastructure for centralized checking of coalescing parameters	2020-03-05 12:12:34 -08:00
hsr	hsr: fix refcnt leak of hsr slave interface	2020-03-05 11:59:47 -08:00
ieee802154
ife
ipv4	tcp: Add missing annotation for tcp_child_process()	2020-03-11 23:19:41 -07:00
ipv6	ipv6: Use math to point per net sysctls into the appropriate struct net	2020-03-03 14:50:08 -08:00
iucv
kcm	bpf: Use bpf_prog_run_pin_on_cpu() at simple call sites.	2020-02-24 16:20:09 -08:00
key
l2tp	l2tp: Replace zero-length array with flexible-array member	2020-02-28 12:08:37 -08:00
l3mdev
lapb
llc	af_llc: fix if-statement empty body warning	2020-02-26 20:38:13 -08:00
mac80211	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-02-27 18:31:39 -08:00
mac802154
mpls	net: mpls: Replace zero-length array with flexible-array member	2020-02-28 12:08:37 -08:00
mptcp	net: mptcp: don't hang before sending 'MP capable with data'	2020-03-11 23:59:11 -07:00
ncsi
netfilter	netfilter: xt_hashlimit: unregister proc file before releasing mutex	2020-02-26 23:25:07 +01:00
netlabel	netlabel_domainhash.c: Use built-in RCU list checking	2020-02-18 12:44:23 -08:00
netlink	net: Add missing annotation for *netlink_seq_start()	2020-03-11 23:19:41 -07:00
netrom	net: netrom: Add missing annotation for nr_neigh_stop()	2020-02-24 13:26:49 -08:00
nfc	NFC: digital: Replace zero-length array with flexible-array member	2020-02-17 19:05:05 -08:00
nsh
openvswitch	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-02-21 13:39:34 -08:00
packet
phonet
psample
qrtr	net: qrtr: Fix FIXME related to qrtr_ns_init()	2020-03-03 17:52:21 -08:00
rds	net/rds: Track user mapped pages through special API	2020-02-16 18:37:09 -08:00
rfkill
rose
rxrpc
sched	Revert "net: sched: make newly activated qdiscs visible"	2020-03-12 11:19:24 -07:00
sctp	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next	2020-02-29 15:53:35 -08:00
smc	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-02-27 18:31:39 -08:00
strparser
sunrpc
switchdev	net: switchdev: do not propagate bridge updates across bridges	2020-02-26 20:58:33 -08:00
tipc
tls	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next	2020-02-21 15:22:45 -08:00
unix	net: datagram: drop 'destructor' argument from several helpers	2020-02-28 12:12:53 -08:00
vmw_vsock	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-02-27 18:31:39 -08:00
wimax
wireless	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-02-27 18:31:39 -08:00
x25	net: x25: convert to list_for_each_entry_safe()	2020-02-16 18:59:42 -08:00
xdp	xdp: Replace zero-length array with flexible-array member	2020-02-28 12:08:37 -08:00
xfrm	net: datagram: drop 'destructor' argument from several helpers	2020-02-28 12:12:53 -08:00
compat.c
Kconfig	net: disable BRIDGE_NETFILTER by default	2020-02-20 15:02:02 -08:00
Makefile
socket.c
sysctl_net.c