David Lebrun 191f86ca8e ipv6: sr: fix scheduling in RCU when creating seg6 lwtunnel state ... The seg6_build_state() function is called with RCU read lock held, so we cannot use GFP_KERNEL. This patch uses GFP_ATOMIC instead. [ 92.770271] ============================= [ 92.770628] WARNING: suspicious RCU usage [ 92.770921] 4.16.0-rc4+ #12 Not tainted [ 92.771277] ----------------------------- [ 92.771585] ./include/linux/rcupdate.h:302 Illegal context switch in RCU read-side critical section! [ 92.772279] [ 92.772279] other info that might help us debug this: [ 92.772279] [ 92.773067] [ 92.773067] rcu_scheduler_active = 2, debug_locks = 1 [ 92.773514] 2 locks held by ip/2413: [ 92.773765] #0: (rtnl_mutex){+.+.}, at: [<00000000e5461720>] rtnetlink_rcv_msg+0x441/0x4d0 [ 92.774377] #1: (rcu_read_lock){....}, at: [<00000000df4f161e>] lwtunnel_build_state+0x59/0x210 [ 92.775065] [ 92.775065] stack backtrace: [ 92.775371] CPU: 0 PID: 2413 Comm: ip Not tainted 4.16.0-rc4+ #12 [ 92.775791] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1.fc27 04/01/2014 [ 92.776608] Call Trace: [ 92.776852] dump_stack+0x7d/0xbc [ 92.777130] __schedule+0x133/0xf00 [ 92.777393] ? unwind_get_return_address_ptr+0x50/0x50 [ 92.777783] ? __sched_text_start+0x8/0x8 [ 92.778073] ? rcu_is_watching+0x19/0x30 [ 92.778383] ? kernel_text_address+0x49/0x60 [ 92.778800] ? __kernel_text_address+0x9/0x30 [ 92.779241] ? unwind_get_return_address+0x29/0x40 [ 92.779727] ? pcpu_alloc+0x102/0x8f0 [ 92.780101] _cond_resched+0x23/0x50 [ 92.780459] __mutex_lock+0xbd/0xad0 [ 92.780818] ? pcpu_alloc+0x102/0x8f0 [ 92.781194] ? seg6_build_state+0x11d/0x240 [ 92.781611] ? save_stack+0x9b/0xb0 [ 92.781965] ? __ww_mutex_wakeup_for_backoff+0xf0/0xf0 [ 92.782480] ? seg6_build_state+0x11d/0x240 [ 92.782925] ? lwtunnel_build_state+0x1bd/0x210 [ 92.783393] ? ip6_route_info_create+0x687/0x1640 [ 92.783846] ? ip6_route_add+0x74/0x110 [ 92.784236] ? inet6_rtm_newroute+0x8a/0xd0 Fixes: 6c8702c60b ("ipv6: sr: add support for SRH encapsulation and injection with lwtunnels") Signed-off-by: David Lebrun <dlebrun@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2018-03-22 12:21:11 -04:00
..
ila	rhashtable: Change rhashtable_walk_start to return void	2017-12-11 09:58:38 -05:00
netfilter	net: rename skb_gso_validate_mtu -> skb_gso_validate_network_len	2018-03-04 17:49:17 -05:00
addrconf_core.c	net: ipv6: Make inet6addr_validator a blocking notifier	2017-10-20 13:15:07 +01:00
addrconf.c	ipv6: addrconf: break critical section in addrconf_verify_rtnl()	2018-01-29 14:23:38 -05:00
addrlabel.c	rtnetlink: ipv6: convert remaining users to rtnl_register_module	2017-12-04 13:35:36 -05:00
af_inet6.c	ipv6: Fix SO_REUSEPORT UDP socket with implicit sk_ipv6only	2018-01-29 11:37:40 -05:00
ah6.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2017-11-15 11:56:19 -08:00
anycast.c	net: delete /proc THIS_MODULE references	2018-01-16 15:01:33 -05:00
calipso.c	net, calipso: convert calipso_doi.refcount from atomic_t to refcount_t	2017-07-04 22:35:16 +01:00
datagram.c	ipv6: old_dport should be a __be16 in __ip6_datagram_connect()	2018-03-20 12:43:43 -04:00
esp6_offload.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-01-23 13:51:56 -05:00
esp6.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-01-17 00:10:42 -05:00
exthdrs_core.c	net: ipv6: remove unused code in ipv6_find_hdr()	2017-10-05 21:53:02 -07:00
exthdrs_offload.c	ipv6: fix exthdrs offload registration in out_rt path	2015-09-02 15:31:00 -07:00
exthdrs.c	ipv6: sr: fix TLVs not being copied using setsockopt	2018-01-10 16:03:55 -05:00
fib6_notifier.c	net: Add module reference to FIB notifiers	2017-09-01 20:33:42 -07:00
fib6_rules.c	net: ipv6: avoid overhead when no custom FIB rules are installed	2017-08-08 21:40:08 -07:00
fou6.c	fou: make local function static	2017-05-21 13:42:36 -04:00
icmp.c	ipv6: mark expected switch fall-throughs	2017-10-18 14:13:08 +01:00
inet6_connection_sock.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-01-28 10:33:06 -05:00
inet6_hashtables.c	inet: Add a 2nd listener hashtable (port+addr)	2017-12-03 10:18:28 -05:00
ip6_checksum.c	udplite: fix partial checksum initialization	2018-02-16 15:57:42 -05:00
ip6_fib.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-01-19 22:59:33 -05:00
ip6_flowlabel.c	net: delete /proc THIS_MODULE references	2018-01-16 15:01:33 -05:00
ip6_gre.c	ip6erspan: make sure enough headroom at xmit.	2018-03-09 13:03:57 -05:00
ip6_icmp.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ip6_input.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-04-20 10:35:33 -04:00
ip6_offload.c	gso: fix payload length when gso_size is zero	2017-10-08 10:12:15 -07:00
ip6_offload.h	udp: Add GRO functions to UDP socket	2016-04-07 16:53:29 -04:00
ip6_output.c	net: rename skb_gso_validate_mtu -> skb_gso_validate_network_len	2018-03-04 17:49:17 -05:00
ip6_tunnel.c	ip6_tunnel: fix IFLA_MTU ignored on NEWLINK	2018-02-27 14:36:28 -05:00
ip6_udp_tunnel.c	ip6_udp_tunnel: remove unused IPCB related codes	2016-11-02 15:18:36 -04:00
ip6_vti.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-01-29 10:15:51 -05:00
ip6mr.c	ip6mr: fix stale iterator	2018-01-31 10:26:30 -05:00
ipcomp6.c	net: inet: Support UID-based routing in IP protocols.	2016-11-04 14:45:23 -04:00
ipv6_sockglue.c	netfilter: drop outermost socket lock in getsockopt()	2018-02-14 20:44:42 +01:00
Kconfig	ipv6: sr: add helper functions for seg6local	2017-08-25 17:10:24 -07:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
mcast_snoop.c	net: fix wrong skb_get() usage / crash in IGMP/MLD parsing code	2015-08-13 17:08:39 -07:00
mcast.c	build_bug.h: remove BUILD_BUG_ON_NULL()	2018-02-06 18:32:46 -08:00
mip6.c	ktime: Get rid of ktime_equal()	2016-12-25 17:21:23 +01:00
ndisc.c	ipv6: fix access to non-linear packet in ndisc_fill_redirect_hdr_option()	2018-03-09 11:16:19 -05:00
netfilter.c	netfilter: use skb_to_full_sk in ip6_route_me_harder	2018-02-25 20:51:13 +01:00
output_core.c	net: accept UFO datagrams from tuntap and packet	2017-11-24 01:37:35 +09:00
ping.c	net/ipv6: Convert icmpv6_push_pending_frames to void	2017-10-06 09:52:31 -07:00
proc.c	net: delete /proc THIS_MODULE references	2018-01-16 15:01:33 -05:00
protocol.c	net: Add sysctl to toggle early demux for tcp and udp	2017-03-24 13:17:07 -07:00
raw.c	Currently, hardened usercopy performs dynamic bounds checking on slab	2018-02-03 16:25:42 -08:00
reassembly.c	inet: frags: Convert timers to use timer_setup()	2017-10-18 12:39:55 +01:00
route.c	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec	2018-03-13 10:38:07 -04:00
seg6_hmac.c	ipv6: sr: Use ARRAY_SIZE macro	2017-09-01 18:35:23 -07:00
seg6_iptunnel.c	ipv6: sr: fix scheduling in RCU when creating seg6 lwtunnel state	2018-03-22 12:21:11 -04:00
seg6_local.c	ipv6: use ARRAY_SIZE for array sizing calculation on array seg6_action_table	2018-01-09 11:40:46 -05:00
seg6.c	rhashtable: Change rhashtable_walk_start to return void	2017-12-11 09:58:38 -05:00
sit.c	sit: fix IFLA_MTU ignored on NEWLINK	2018-02-27 14:36:28 -05:00
syncookies.c	tcp: Namespace-ify sysctl_tcp_workaround_signed_windows	2017-10-28 19:24:38 +09:00
sysctl_net_ipv6.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-11-04 09:26:51 +09:00
tcp_ipv6.c	tcp: tracepoint: only call trace_tcp_send_reset with full socket	2018-02-07 22:00:42 -05:00
tcpv6_offload.c	gso: validate gso_type in GSO handlers	2018-01-22 16:01:30 -05:00
tunnel6.c	ipv6: fix tunnel error handling	2015-11-03 10:52:13 -05:00
udp_impl.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
udp_offload.c	gso: validate gso_type in GSO handlers	2018-01-22 16:01:30 -05:00
udp.c	net: delete /proc THIS_MODULE references	2018-01-16 15:01:33 -05:00
udplite.c	net: delete /proc THIS_MODULE references	2018-01-16 15:01:33 -05:00
xfrm6_input.c	xfrm: Reinject transport-mode packets through tasklet	2017-12-19 08:23:21 +01:00
xfrm6_mode_beet.c	networking: make skb_pull & friends return void pointers	2017-06-16 11:48:39 -04:00
xfrm6_mode_ro.c	ipv6: xfrm: Handle errors reported by xfrm6_find_1stfragopt()	2017-06-02 13:57:27 -04:00
xfrm6_mode_transport.c	ipv6: xfrm: Handle errors reported by xfrm6_find_1stfragopt()	2017-06-02 13:57:27 -04:00
xfrm6_mode_tunnel.c	xfrm: Verify MAC header exists before overwriting eth_hdr(skb)->h_proto	2018-03-07 10:54:29 +01:00
xfrm6_output.c	net: xfrm: use skb_gso_validate_network_len() to check gso sizes	2018-03-04 17:49:17 -05:00
xfrm6_policy.c	xfrm: reuse uncached_list to track xdsts	2018-02-16 07:03:33 +01:00
xfrm6_protocol.c	xfrm: input: constify xfrm_input_afinfo	2017-02-09 10:22:17 +01:00
xfrm6_state.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xfrm6_tunnel.c	xfrm6_tunnel: exit_net cleanup check added	2017-11-14 15:46:17 +09:00