mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-06 02:56:44 +07:00
fc27fe7e8d
ALSA sequencer core has a mechanism to load the enumerated devices automatically, and it's performed in an off-load work. This seems causing some race when a sequencer is removed while the pending autoload work is running. As syzkaller spotted, it may lead to some use-after-free: BUG: KASAN: use-after-free in snd_rawmidi_dev_seq_free+0x69/0x70 sound/core/rawmidi.c:1617 Write of size 8 at addr ffff88006c611d90 by task kworker/2:1/567 CPU: 2 PID: 567 Comm: kworker/2:1 Not tainted 4.13.0+ #29 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 Workqueue: events autoload_drivers Call Trace: __dump_stack lib/dump_stack.c:16 [inline] dump_stack+0x192/0x22c lib/dump_stack.c:52 print_address_description+0x78/0x280 mm/kasan/report.c:252 kasan_report_error mm/kasan/report.c:351 [inline] kasan_report+0x230/0x340 mm/kasan/report.c:409 __asan_report_store8_noabort+0x1c/0x20 mm/kasan/report.c:435 snd_rawmidi_dev_seq_free+0x69/0x70 sound/core/rawmidi.c:1617 snd_seq_dev_release+0x4f/0x70 sound/core/seq_device.c:192 device_release+0x13f/0x210 drivers/base/core.c:814 kobject_cleanup lib/kobject.c:648 [inline] kobject_release lib/kobject.c:677 [inline] kref_put include/linux/kref.h:70 [inline] kobject_put+0x145/0x240 lib/kobject.c:694 put_device+0x25/0x30 drivers/base/core.c:1799 klist_devices_put+0x36/0x40 drivers/base/bus.c:827 klist_next+0x264/0x4a0 lib/klist.c:403 next_device drivers/base/bus.c:270 [inline] bus_for_each_dev+0x17e/0x210 drivers/base/bus.c:312 autoload_drivers+0x3b/0x50 sound/core/seq_device.c:117 process_one_work+0x9fb/0x1570 kernel/workqueue.c:2097 worker_thread+0x1e4/0x1350 kernel/workqueue.c:2231 kthread+0x324/0x3f0 kernel/kthread.c:231 ret_from_fork+0x25/0x30 arch/x86/entry/entry_64.S:425 The fix is simply to assure canceling the autoload work at removing the device. Reported-by: Andrey Konovalov <andreyknvl@google.com> Tested-by: Andrey Konovalov <andreyknvl@google.com> Cc: <stable@vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>
319 lines
7.8 KiB
C
319 lines
7.8 KiB
C
/*
|
|
* ALSA sequencer device management
|
|
* Copyright (c) 1999 by Takashi Iwai <tiwai@suse.de>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*
|
|
*
|
|
*----------------------------------------------------------------
|
|
*
|
|
* This device handler separates the card driver module from sequencer
|
|
* stuff (sequencer core, synth drivers, etc), so that user can avoid
|
|
* to spend unnecessary resources e.g. if he needs only listening to
|
|
* MP3s.
|
|
*
|
|
* The card (or lowlevel) driver creates a sequencer device entry
|
|
* via snd_seq_device_new(). This is an entry pointer to communicate
|
|
* with the sequencer device "driver", which is involved with the
|
|
* actual part to communicate with the sequencer core.
|
|
* Each sequencer device entry has an id string and the corresponding
|
|
* driver with the same id is loaded when required. For example,
|
|
* lowlevel codes to access emu8000 chip on sbawe card are included in
|
|
* emu8000-synth module. To activate this module, the hardware
|
|
* resources like i/o port are passed via snd_seq_device argument.
|
|
*
|
|
*/
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/init.h>
|
|
#include <linux/module.h>
|
|
#include <sound/core.h>
|
|
#include <sound/info.h>
|
|
#include <sound/seq_device.h>
|
|
#include <sound/seq_kernel.h>
|
|
#include <sound/initval.h>
|
|
#include <linux/kmod.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/mutex.h>
|
|
|
|
MODULE_AUTHOR("Takashi Iwai <tiwai@suse.de>");
|
|
MODULE_DESCRIPTION("ALSA sequencer device management");
|
|
MODULE_LICENSE("GPL");
|
|
|
|
/*
|
|
* bus definition
|
|
*/
|
|
static int snd_seq_bus_match(struct device *dev, struct device_driver *drv)
|
|
{
|
|
struct snd_seq_device *sdev = to_seq_dev(dev);
|
|
struct snd_seq_driver *sdrv = to_seq_drv(drv);
|
|
|
|
return strcmp(sdrv->id, sdev->id) == 0 &&
|
|
sdrv->argsize == sdev->argsize;
|
|
}
|
|
|
|
static struct bus_type snd_seq_bus_type = {
|
|
.name = "snd_seq",
|
|
.match = snd_seq_bus_match,
|
|
};
|
|
|
|
/*
|
|
* proc interface -- just for compatibility
|
|
*/
|
|
#ifdef CONFIG_SND_PROC_FS
|
|
static struct snd_info_entry *info_entry;
|
|
|
|
static int print_dev_info(struct device *dev, void *data)
|
|
{
|
|
struct snd_seq_device *sdev = to_seq_dev(dev);
|
|
struct snd_info_buffer *buffer = data;
|
|
|
|
snd_iprintf(buffer, "snd-%s,%s,%d\n", sdev->id,
|
|
dev->driver ? "loaded" : "empty",
|
|
dev->driver ? 1 : 0);
|
|
return 0;
|
|
}
|
|
|
|
static void snd_seq_device_info(struct snd_info_entry *entry,
|
|
struct snd_info_buffer *buffer)
|
|
{
|
|
bus_for_each_dev(&snd_seq_bus_type, NULL, buffer, print_dev_info);
|
|
}
|
|
#endif
|
|
|
|
/*
|
|
* load all registered drivers (called from seq_clientmgr.c)
|
|
*/
|
|
|
|
#ifdef CONFIG_MODULES
|
|
/* flag to block auto-loading */
|
|
static atomic_t snd_seq_in_init = ATOMIC_INIT(1); /* blocked as default */
|
|
|
|
static int request_seq_drv(struct device *dev, void *data)
|
|
{
|
|
struct snd_seq_device *sdev = to_seq_dev(dev);
|
|
|
|
if (!dev->driver)
|
|
request_module("snd-%s", sdev->id);
|
|
return 0;
|
|
}
|
|
|
|
static void autoload_drivers(struct work_struct *work)
|
|
{
|
|
/* avoid reentrance */
|
|
if (atomic_inc_return(&snd_seq_in_init) == 1)
|
|
bus_for_each_dev(&snd_seq_bus_type, NULL, NULL,
|
|
request_seq_drv);
|
|
atomic_dec(&snd_seq_in_init);
|
|
}
|
|
|
|
static DECLARE_WORK(autoload_work, autoload_drivers);
|
|
|
|
static void queue_autoload_drivers(void)
|
|
{
|
|
schedule_work(&autoload_work);
|
|
}
|
|
|
|
void snd_seq_autoload_init(void)
|
|
{
|
|
atomic_dec(&snd_seq_in_init);
|
|
#ifdef CONFIG_SND_SEQUENCER_MODULE
|
|
/* initial autoload only when snd-seq is a module */
|
|
queue_autoload_drivers();
|
|
#endif
|
|
}
|
|
EXPORT_SYMBOL(snd_seq_autoload_init);
|
|
|
|
void snd_seq_autoload_exit(void)
|
|
{
|
|
atomic_inc(&snd_seq_in_init);
|
|
}
|
|
EXPORT_SYMBOL(snd_seq_autoload_exit);
|
|
|
|
void snd_seq_device_load_drivers(void)
|
|
{
|
|
queue_autoload_drivers();
|
|
flush_work(&autoload_work);
|
|
}
|
|
EXPORT_SYMBOL(snd_seq_device_load_drivers);
|
|
#define cancel_autoload_drivers() cancel_work_sync(&autoload_work)
|
|
#else
|
|
#define queue_autoload_drivers() /* NOP */
|
|
#define cancel_autoload_drivers() /* NOP */
|
|
#endif
|
|
|
|
/*
|
|
* device management
|
|
*/
|
|
static int snd_seq_device_dev_free(struct snd_device *device)
|
|
{
|
|
struct snd_seq_device *dev = device->device_data;
|
|
|
|
cancel_autoload_drivers();
|
|
put_device(&dev->dev);
|
|
return 0;
|
|
}
|
|
|
|
static int snd_seq_device_dev_register(struct snd_device *device)
|
|
{
|
|
struct snd_seq_device *dev = device->device_data;
|
|
int err;
|
|
|
|
err = device_add(&dev->dev);
|
|
if (err < 0)
|
|
return err;
|
|
if (!dev->dev.driver)
|
|
queue_autoload_drivers();
|
|
return 0;
|
|
}
|
|
|
|
static int snd_seq_device_dev_disconnect(struct snd_device *device)
|
|
{
|
|
struct snd_seq_device *dev = device->device_data;
|
|
|
|
device_del(&dev->dev);
|
|
return 0;
|
|
}
|
|
|
|
static void snd_seq_dev_release(struct device *dev)
|
|
{
|
|
struct snd_seq_device *sdev = to_seq_dev(dev);
|
|
|
|
if (sdev->private_free)
|
|
sdev->private_free(sdev);
|
|
kfree(sdev);
|
|
}
|
|
|
|
/*
|
|
* register a sequencer device
|
|
* card = card info
|
|
* device = device number (if any)
|
|
* id = id of driver
|
|
* result = return pointer (NULL allowed if unnecessary)
|
|
*/
|
|
int snd_seq_device_new(struct snd_card *card, int device, const char *id,
|
|
int argsize, struct snd_seq_device **result)
|
|
{
|
|
struct snd_seq_device *dev;
|
|
int err;
|
|
static struct snd_device_ops dops = {
|
|
.dev_free = snd_seq_device_dev_free,
|
|
.dev_register = snd_seq_device_dev_register,
|
|
.dev_disconnect = snd_seq_device_dev_disconnect,
|
|
};
|
|
|
|
if (result)
|
|
*result = NULL;
|
|
|
|
if (snd_BUG_ON(!id))
|
|
return -EINVAL;
|
|
|
|
dev = kzalloc(sizeof(*dev) + argsize, GFP_KERNEL);
|
|
if (!dev)
|
|
return -ENOMEM;
|
|
|
|
/* set up device info */
|
|
dev->card = card;
|
|
dev->device = device;
|
|
dev->id = id;
|
|
dev->argsize = argsize;
|
|
|
|
device_initialize(&dev->dev);
|
|
dev->dev.parent = &card->card_dev;
|
|
dev->dev.bus = &snd_seq_bus_type;
|
|
dev->dev.release = snd_seq_dev_release;
|
|
dev_set_name(&dev->dev, "%s-%d-%d", dev->id, card->number, device);
|
|
|
|
/* add this device to the list */
|
|
err = snd_device_new(card, SNDRV_DEV_SEQUENCER, dev, &dops);
|
|
if (err < 0) {
|
|
put_device(&dev->dev);
|
|
return err;
|
|
}
|
|
|
|
if (result)
|
|
*result = dev;
|
|
|
|
return 0;
|
|
}
|
|
EXPORT_SYMBOL(snd_seq_device_new);
|
|
|
|
/*
|
|
* driver registration
|
|
*/
|
|
int __snd_seq_driver_register(struct snd_seq_driver *drv, struct module *mod)
|
|
{
|
|
if (WARN_ON(!drv->driver.name || !drv->id))
|
|
return -EINVAL;
|
|
drv->driver.bus = &snd_seq_bus_type;
|
|
drv->driver.owner = mod;
|
|
return driver_register(&drv->driver);
|
|
}
|
|
EXPORT_SYMBOL_GPL(__snd_seq_driver_register);
|
|
|
|
void snd_seq_driver_unregister(struct snd_seq_driver *drv)
|
|
{
|
|
driver_unregister(&drv->driver);
|
|
}
|
|
EXPORT_SYMBOL_GPL(snd_seq_driver_unregister);
|
|
|
|
/*
|
|
* module part
|
|
*/
|
|
|
|
static int __init seq_dev_proc_init(void)
|
|
{
|
|
#ifdef CONFIG_SND_PROC_FS
|
|
info_entry = snd_info_create_module_entry(THIS_MODULE, "drivers",
|
|
snd_seq_root);
|
|
if (info_entry == NULL)
|
|
return -ENOMEM;
|
|
info_entry->content = SNDRV_INFO_CONTENT_TEXT;
|
|
info_entry->c.text.read = snd_seq_device_info;
|
|
if (snd_info_register(info_entry) < 0) {
|
|
snd_info_free_entry(info_entry);
|
|
return -ENOMEM;
|
|
}
|
|
#endif
|
|
return 0;
|
|
}
|
|
|
|
static int __init alsa_seq_device_init(void)
|
|
{
|
|
int err;
|
|
|
|
err = bus_register(&snd_seq_bus_type);
|
|
if (err < 0)
|
|
return err;
|
|
err = seq_dev_proc_init();
|
|
if (err < 0)
|
|
bus_unregister(&snd_seq_bus_type);
|
|
return err;
|
|
}
|
|
|
|
static void __exit alsa_seq_device_exit(void)
|
|
{
|
|
#ifdef CONFIG_MODULES
|
|
cancel_work_sync(&autoload_work);
|
|
#endif
|
|
#ifdef CONFIG_SND_PROC_FS
|
|
snd_info_free_entry(info_entry);
|
|
#endif
|
|
bus_unregister(&snd_seq_bus_type);
|
|
}
|
|
|
|
subsys_initcall(alsa_seq_device_init)
|
|
module_exit(alsa_seq_device_exit)
|