mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-17 15:47:39 +07:00
f0f59a00a1
Make I915_READ and I915_WRITE more type safe by wrapping the register offset in a struct. This should eliminate most of the fumbles we've had with misplaced parens. This only takes care of normal mmio registers. We could extend the idea to other register types and define each with its own struct. That way you wouldn't be able to accidentally pass the wrong thing to a specific register access function. The gpio_reg setup is probably the ugliest thing left. But I figure I'd just leave it for now, and wait for some divine inspiration to strike before making it nice. As for the generated code, it's actually a bit better sometimes. Eg. looking at i915_irq_handler(), we can see the following change: lea 0x70024(%rdx,%rax,1),%r9d mov $0x1,%edx - movslq %r9d,%r9 - mov %r9,%rsi - mov %r9,-0x58(%rbp) - callq *0xd8(%rbx) + mov %r9d,%esi + mov %r9d,-0x48(%rbp) callq *0xd8(%rbx) So previously gcc thought the register offset might be signed and decided to sign extend it, just in case. The rest appears to be mostly just minor shuffling of instructions. v2: i915_mmio_reg_{offset,equal,valid}() helpers added s/_REG/_MMIO/ in the register defines mo more switch statements left to worry about ring_emit stuff got sorted in a prep patch cmd parser, lrc context and w/a batch buildup also in prep patch vgpu stuff cleaned up and moved to a prep patch all other unrelated changes split out v3: Rebased due to BXT DSI/BLC, MOCS, etc. v4: Rebased due to churn, s/i915_mmio_reg_t/i915_reg_t/ Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Link: http://patchwork.freedesktop.org/patch/msgid/1447853606-2751-1-git-send-email-ville.syrjala@linux.intel.com
140 lines
4.2 KiB
C
140 lines
4.2 KiB
C
/*
|
|
* Copyright © 2006 Eric Anholt
|
|
*
|
|
* Permission to use, copy, modify, distribute, and sell this software and its
|
|
* documentation for any purpose is hereby granted without fee, provided that
|
|
* the above copyright notice appear in all copies and that both that copyright
|
|
* notice and this permission notice appear in supporting documentation, and
|
|
* that the name of the copyright holders not be used in advertising or
|
|
* publicity pertaining to distribution of the software without specific,
|
|
* written prior permission. The copyright holders make no representations
|
|
* about the suitability of this software for any purpose. It is provided "as
|
|
* is" without express or implied warranty.
|
|
*
|
|
* THE COPYRIGHT HOLDERS DISCLAIM ALL WARRANTIES WITH REGARD TO THIS SOFTWARE,
|
|
* INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS, IN NO
|
|
* EVENT SHALL THE COPYRIGHT HOLDERS BE LIABLE FOR ANY SPECIAL, INDIRECT OR
|
|
* CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE,
|
|
* DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER
|
|
* TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE
|
|
* OF THIS SOFTWARE.
|
|
*/
|
|
|
|
#ifndef _INTEL_DVO_H
|
|
#define _INTEL_DVO_H
|
|
|
|
#include <linux/i2c.h>
|
|
#include <drm/drmP.h>
|
|
#include <drm/drm_crtc.h>
|
|
#include "intel_drv.h"
|
|
|
|
struct intel_dvo_device {
|
|
const char *name;
|
|
int type;
|
|
/* DVOA/B/C output register */
|
|
i915_reg_t dvo_reg;
|
|
i915_reg_t dvo_srcdim_reg;
|
|
/* GPIO register used for i2c bus to control this device */
|
|
u32 gpio;
|
|
int slave_addr;
|
|
|
|
const struct intel_dvo_dev_ops *dev_ops;
|
|
void *dev_priv;
|
|
struct i2c_adapter *i2c_bus;
|
|
};
|
|
|
|
struct intel_dvo_dev_ops {
|
|
/*
|
|
* Initialize the device at startup time.
|
|
* Returns NULL if the device does not exist.
|
|
*/
|
|
bool (*init)(struct intel_dvo_device *dvo,
|
|
struct i2c_adapter *i2cbus);
|
|
|
|
/*
|
|
* Called to allow the output a chance to create properties after the
|
|
* RandR objects have been created.
|
|
*/
|
|
void (*create_resources)(struct intel_dvo_device *dvo);
|
|
|
|
/*
|
|
* Turn on/off output.
|
|
*
|
|
* Because none of our dvo drivers support an intermediate power levels,
|
|
* we don't expose this in the interfac.
|
|
*/
|
|
void (*dpms)(struct intel_dvo_device *dvo, bool enable);
|
|
|
|
/*
|
|
* Callback for testing a video mode for a given output.
|
|
*
|
|
* This function should only check for cases where a mode can't
|
|
* be supported on the output specifically, and not represent
|
|
* generic CRTC limitations.
|
|
*
|
|
* \return MODE_OK if the mode is valid, or another MODE_* otherwise.
|
|
*/
|
|
int (*mode_valid)(struct intel_dvo_device *dvo,
|
|
struct drm_display_mode *mode);
|
|
|
|
/*
|
|
* Callback for preparing mode changes on an output
|
|
*/
|
|
void (*prepare)(struct intel_dvo_device *dvo);
|
|
|
|
/*
|
|
* Callback for committing mode changes on an output
|
|
*/
|
|
void (*commit)(struct intel_dvo_device *dvo);
|
|
|
|
/*
|
|
* Callback for setting up a video mode after fixups have been made.
|
|
*
|
|
* This is only called while the output is disabled. The dpms callback
|
|
* must be all that's necessary for the output, to turn the output on
|
|
* after this function is called.
|
|
*/
|
|
void (*mode_set)(struct intel_dvo_device *dvo,
|
|
const struct drm_display_mode *mode,
|
|
const struct drm_display_mode *adjusted_mode);
|
|
|
|
/*
|
|
* Probe for a connected output, and return detect_status.
|
|
*/
|
|
enum drm_connector_status (*detect)(struct intel_dvo_device *dvo);
|
|
|
|
/*
|
|
* Probe the current hw status, returning true if the connected output
|
|
* is active.
|
|
*/
|
|
bool (*get_hw_state)(struct intel_dvo_device *dev);
|
|
|
|
/**
|
|
* Query the device for the modes it provides.
|
|
*
|
|
* This function may also update MonInfo, mm_width, and mm_height.
|
|
*
|
|
* \return singly-linked list of modes or NULL if no modes found.
|
|
*/
|
|
struct drm_display_mode *(*get_modes)(struct intel_dvo_device *dvo);
|
|
|
|
/**
|
|
* Clean up driver-specific bits of the output
|
|
*/
|
|
void (*destroy) (struct intel_dvo_device *dvo);
|
|
|
|
/**
|
|
* Debugging hook to dump device registers to log file
|
|
*/
|
|
void (*dump_regs)(struct intel_dvo_device *dvo);
|
|
};
|
|
|
|
extern struct intel_dvo_dev_ops sil164_ops;
|
|
extern struct intel_dvo_dev_ops ch7xxx_ops;
|
|
extern struct intel_dvo_dev_ops ivch_ops;
|
|
extern struct intel_dvo_dev_ops tfp410_ops;
|
|
extern struct intel_dvo_dev_ops ch7017_ops;
|
|
extern struct intel_dvo_dev_ops ns2501_ops;
|
|
|
|
#endif /* _INTEL_DVO_H */
|