Li Jun 1449cb2c22 usb: host: xhci-plat: keep runtime active when removing host ... While removing the host (e.g. for USB role switch from host to device), if runtime pm is enabled by user, below oops occurs on dwc3 and cdns3 platforms. Keeping the xhci-plat device active during host removal, and disabling runtime pm before calling pm_runtime_set_suspended() fixes them. oops1: Unable to handle kernel NULL pointer dereference at virtual address 0000000000000240 Internal error: Oops: 96000004 [#1] PREEMPT SMP Modules linked in: CPU: 0 PID: 5 Comm: kworker/0:0 Not tainted 5.4.3-00107-g64d454a-dirty Hardware name: FSL i.MX8MP EVK (DT) Workqueue: pm pm_runtime_work pstate: 60000005 (nZCv daif -PAN -UAO) pc : xhci_suspend+0x34/0x698 lr : xhci_plat_runtime_suspend+0x2c/0x38 sp : ffff800011ddbbc0 Call trace: xhci_suspend+0x34/0x698 xhci_plat_runtime_suspend+0x2c/0x38 pm_generic_runtime_suspend+0x28/0x40 __rpm_callback+0xd8/0x138 rpm_callback+0x24/0x98 rpm_suspend+0xe0/0x448 rpm_idle+0x124/0x140 pm_runtime_work+0xa0/0xf8 process_one_work+0x1dc/0x370 worker_thread+0x48/0x468 kthread+0xf0/0x120 ret_from_fork+0x10/0x1c oops2: usb 2-1: USB disconnect, device number 2 xhci-hcd xhci-hcd.1.auto: remove, state 4 usb usb2: USB disconnect, device number 1 xhci-hcd xhci-hcd.1.auto: USB bus 2 deregistered xhci-hcd xhci-hcd.1.auto: remove, state 4 usb usb1: USB disconnect, device number 1 Unable to handle kernel NULL pointer dereference at virtual address 0000000000000138 Internal error: Oops: 96000004 [#1] PREEMPT SMP Modules linked in: CPU: 2 PID: 7 Comm: kworker/u8:0 Not tainted 5.6.0-rc4-next-20200304-03578 Hardware name: Freescale i.MX8QXP MEK (DT) Workqueue: 1-0050 tcpm_state_machine_work pstate: 20000005 (nzCv daif -PAN -UAO) pc : xhci_free_dev+0x214/0x270 lr : xhci_plat_runtime_resume+0x78/0x88 sp : ffff80001006b5b0 Call trace: xhci_free_dev+0x214/0x270 xhci_plat_runtime_resume+0x78/0x88 pm_generic_runtime_resume+0x30/0x48 __rpm_callback+0x90/0x148 rpm_callback+0x28/0x88 rpm_resume+0x568/0x758 rpm_resume+0x260/0x758 rpm_resume+0x260/0x758 __pm_runtime_resume+0x40/0x88 device_release_driver_internal+0xa0/0x1c8 device_release_driver+0x1c/0x28 bus_remove_device+0xd4/0x158 device_del+0x15c/0x3a0 usb_disable_device+0xb0/0x268 usb_disconnect+0xcc/0x300 usb_remove_hcd+0xf4/0x1dc xhci_plat_remove+0x78/0xe0 platform_drv_remove+0x30/0x50 device_release_driver_internal+0xfc/0x1c8 device_release_driver+0x1c/0x28 bus_remove_device+0xd4/0x158 device_del+0x15c/0x3a0 platform_device_del.part.0+0x20/0x90 platform_device_unregister+0x28/0x40 cdns3_host_exit+0x20/0x40 cdns3_role_stop+0x60/0x90 cdns3_role_set+0x64/0xd8 usb_role_switch_set_role.part.0+0x3c/0x68 usb_role_switch_set_role+0x20/0x30 tcpm_mux_set+0x60/0xf8 tcpm_reset_port+0xa4/0xf0 tcpm_detach.part.0+0x28/0x50 tcpm_state_machine_work+0x12ac/0x2360 process_one_work+0x1c8/0x470 worker_thread+0x50/0x428 kthread+0xfc/0x128 ret_from_fork+0x10/0x18 Code: c8037c02 35ffffa3 17ffe7c3 f9800011 (c85f7c01) ---[ end trace 45b1a173d2679e44 ]--- [minor commit message cleanup -Mathias] Cc: Baolin Wang <baolin.wang@linaro.org> Cc: <stable@vger.kernel.org> Fixes: b0c69b4bac ("usb: host: plat: Enable xHCI plat runtime PM") Reviewed-by: Peter Chen <peter.chen@nxp.com> Tested-by: Peter Chen <peter.chen@nxp.com> Signed-off-by: Li Jun <jun.li@nxp.com> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com> Link: https://lore.kernel.org/r/20200514110432.25564-3-mathias.nyman@linux.intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2020-05-14 13:44:37 +02:00
..
atm	USB: atm: Use the correct style for SPDX License Identifier	2020-03-17 20:03:28 +01:00
c67x00	USB: c67x00: Use the correct style for SPDX License Identifier	2020-03-17 20:03:28 +01:00
cdns3	usb: cdns3: gadget: prev_req->trb is NULL for ep0	2020-05-09 11:05:08 +03:00
chipidea	usb: chipidea: msm: Ensure proper controller reset using role switch API	2020-05-07 08:46:35 +02:00
class	cdc-acm: introduce a cool down	2020-04-16 14:59:49 +02:00
common	usb: common: usb-conn-gpio: Don't log an error on probe deferral	2019-12-10 11:41:20 +01:00
core	usb: usbfs: correct kernel->user page attribute mismatch	2020-05-05 13:06:46 +02:00
dwc2	usb: dwc2: convert to devm_platform_get_and_ioremap_resource	2020-03-24 12:09:39 +01:00
dwc3	usb: dwc3: select USB_ROLE_SWITCH	2020-05-09 11:05:09 +03:00
early	USB: early: Handle AMD's spec-compliant identifiers, too	2020-04-16 14:46:00 +02:00
gadget	usb: raw-gadget: fix return value of ep read ioctls	2020-05-09 11:05:09 +03:00
host	usb: host: xhci-plat: keep runtime active when removing host	2020-05-14 13:44:37 +02:00
image	Merge 5.4-rc3 into usb-next	2019-10-14 07:09:59 +02:00
isp1760	remove ioremap_nocache and devm_ioremap_nocache	2020-01-06 09:45:59 +01:00
misc	USB: sisusbvga: Change port variable from signed to unsigned	2020-04-23 15:26:17 +02:00
mon	USB: mon: Use scnprintf() for avoiding potential buffer overflow	2020-03-12 09:49:28 +01:00
mtu3	usb: roles: Provide the switch drivers handle to the switch in the API	2020-03-04 11:12:50 +01:00
musb	usb: musb: tusb6010: fix a possible missing data type replacement	2020-03-17 20:03:28 +01:00
phy	usb: phy: twl6030-usb: Fix a resource leak in an error handling path in 'twl6030_usb_probe()'	2020-05-09 11:05:08 +03:00
renesas_usbhs	phy: for 5.6	2020-01-17 07:52:26 +01:00
roles	usb: roles: Allow the role switches to be named	2020-03-04 11:12:50 +01:00
serial	USB: serial: qcserial: Add DW5816e support	2020-05-04 18:23:54 +02:00
storage	USB: uas: add quirk for LaCie 2Big Quadra	2020-04-30 09:28:43 +02:00
typec	usb: typec: mux: intel: Fix DP_HPD_LVL bit field	2020-05-13 14:33:51 +02:00
usbip	usbip: Fix error path of vhci_recv_ret_submit()	2019-12-17 16:36:33 +01:00
Kconfig	usb: common: create Kconfig file	2019-09-03 19:00:39 +02:00
Makefile	USB: Changes for v5.4 merge window	2019-09-02 19:20:57 +02:00
usb-skeleton.c	USB: usb-skeleton: drop redundant in-urb check	2019-10-10 12:41:19 +02:00