mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-26 18:35:26 +07:00
a25b988ff8
Most bridge drivers create a DRM connector to model the connector at the
output of the bridge. This model is historical and has worked pretty
well so far, but causes several issues:
- It prevents supporting more complex display pipelines where DRM
connector operations are split over multiple components. For instance a
pipeline with a bridge connected to the DDC signals to read EDID data,
and another one connected to the HPD signal to detect connection and
disconnection, will not be possible to support through this model.
- It requires every bridge driver to implement similar connector
handling code, resulting in code duplication.
- It assumes that a bridge will either be wired to a connector or to
another bridge, but doesn't support bridges that can be used in both
positions very well (although there is some ad-hoc support for this in
the analogix_dp bridge driver).
In order to solve these issues, ownership of the connector should be
moved to the display controller driver (where it can be implemented
using helpers provided by the core).
Extend the bridge API to allow disabling connector creation in bridge
drivers as a first step towards the new model. The new flags argument to
the bridge .attach() operation allows instructing the bridge driver to
skip creating a connector. Unconditionally set the new flags argument to
0 for now to keep the existing behaviour, and modify all existing bridge
drivers to return an error when connector creation is not requested as
they don't support this feature yet.
The change is based on the following semantic patch, with manual review
and edits.
@ rule1 @
identifier funcs;
identifier fn;
@@
struct drm_bridge_funcs funcs = {
...,
.attach = fn
};
@ depends on rule1 @
identifier rule1.fn;
identifier bridge;
statement S, S1;
@@
int fn(
struct drm_bridge *bridge
+ , enum drm_bridge_attach_flags flags
)
{
... when != S
+ if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) {
+ DRM_ERROR("Fix bridge driver to make connector optional!");
+ return -EINVAL;
+ }
+
S1
...
}
@ depends on rule1 @
identifier rule1.fn;
identifier bridge, flags;
expression E1, E2, E3;
@@
int fn(
struct drm_bridge *bridge,
enum drm_bridge_attach_flags flags
) {
<...
drm_bridge_attach(E1, E2, E3
+ , flags
)
...>
}
@@
expression E1, E2, E3;
@@
drm_bridge_attach(E1, E2, E3
+ , 0
)
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Tested-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200226112514.12455-10-laurent.pinchart@ideasonboard.com
112 lines
2.4 KiB
C
112 lines
2.4 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (c) 2014-2015, The Linux Foundation. All rights reserved.
|
|
*/
|
|
|
|
#include "edp.h"
|
|
|
|
struct edp_bridge {
|
|
struct drm_bridge base;
|
|
struct msm_edp *edp;
|
|
};
|
|
#define to_edp_bridge(x) container_of(x, struct edp_bridge, base)
|
|
|
|
void edp_bridge_destroy(struct drm_bridge *bridge)
|
|
{
|
|
}
|
|
|
|
static void edp_bridge_pre_enable(struct drm_bridge *bridge)
|
|
{
|
|
struct edp_bridge *edp_bridge = to_edp_bridge(bridge);
|
|
struct msm_edp *edp = edp_bridge->edp;
|
|
|
|
DBG("");
|
|
msm_edp_ctrl_power(edp->ctrl, true);
|
|
}
|
|
|
|
static void edp_bridge_enable(struct drm_bridge *bridge)
|
|
{
|
|
DBG("");
|
|
}
|
|
|
|
static void edp_bridge_disable(struct drm_bridge *bridge)
|
|
{
|
|
DBG("");
|
|
}
|
|
|
|
static void edp_bridge_post_disable(struct drm_bridge *bridge)
|
|
{
|
|
struct edp_bridge *edp_bridge = to_edp_bridge(bridge);
|
|
struct msm_edp *edp = edp_bridge->edp;
|
|
|
|
DBG("");
|
|
msm_edp_ctrl_power(edp->ctrl, false);
|
|
}
|
|
|
|
static void edp_bridge_mode_set(struct drm_bridge *bridge,
|
|
const struct drm_display_mode *mode,
|
|
const struct drm_display_mode *adjusted_mode)
|
|
{
|
|
struct drm_device *dev = bridge->dev;
|
|
struct drm_connector *connector;
|
|
struct edp_bridge *edp_bridge = to_edp_bridge(bridge);
|
|
struct msm_edp *edp = edp_bridge->edp;
|
|
|
|
DBG("set mode: " DRM_MODE_FMT, DRM_MODE_ARG(mode));
|
|
|
|
list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
|
|
struct drm_encoder *encoder = connector->encoder;
|
|
struct drm_bridge *first_bridge;
|
|
|
|
if (!connector->encoder)
|
|
continue;
|
|
|
|
first_bridge = drm_bridge_chain_get_first_bridge(encoder);
|
|
if (bridge == first_bridge) {
|
|
msm_edp_ctrl_timing_cfg(edp->ctrl,
|
|
adjusted_mode, &connector->display_info);
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
static const struct drm_bridge_funcs edp_bridge_funcs = {
|
|
.pre_enable = edp_bridge_pre_enable,
|
|
.enable = edp_bridge_enable,
|
|
.disable = edp_bridge_disable,
|
|
.post_disable = edp_bridge_post_disable,
|
|
.mode_set = edp_bridge_mode_set,
|
|
};
|
|
|
|
/* initialize bridge */
|
|
struct drm_bridge *msm_edp_bridge_init(struct msm_edp *edp)
|
|
{
|
|
struct drm_bridge *bridge = NULL;
|
|
struct edp_bridge *edp_bridge;
|
|
int ret;
|
|
|
|
edp_bridge = devm_kzalloc(edp->dev->dev,
|
|
sizeof(*edp_bridge), GFP_KERNEL);
|
|
if (!edp_bridge) {
|
|
ret = -ENOMEM;
|
|
goto fail;
|
|
}
|
|
|
|
edp_bridge->edp = edp;
|
|
|
|
bridge = &edp_bridge->base;
|
|
bridge->funcs = &edp_bridge_funcs;
|
|
|
|
ret = drm_bridge_attach(edp->encoder, bridge, NULL, 0);
|
|
if (ret)
|
|
goto fail;
|
|
|
|
return bridge;
|
|
|
|
fail:
|
|
if (bridge)
|
|
edp_bridge_destroy(bridge);
|
|
|
|
return ERR_PTR(ret);
|
|
}
|