Mark Rutland 027d0c7101 arm64: hugetlb: avoid potential NULL dereference ... The static analyzer in GCC 10 spotted that in huge_pte_alloc() we may pass a NULL pmdp into pte_alloc_map() when pmd_alloc() returns NULL: | CC arch/arm64/mm/pageattr.o | CC arch/arm64/mm/hugetlbpage.o | from arch/arm64/mm/hugetlbpage.c:10: | arch/arm64/mm/hugetlbpage.c: In function ‘huge_pte_alloc’: | ./arch/arm64/include/asm/pgtable-types.h:28:24: warning: dereference of NULL ‘pmdp’ [CWE-690] [-Wanalyzer-null-dereference] | ./arch/arm64/include/asm/pgtable.h:436:26: note: in expansion of macro ‘pmd_val’ | arch/arm64/mm/hugetlbpage.c:242:10: note: in expansion of macro ‘pte_alloc_map’ | |arch/arm64/mm/hugetlbpage.c:232:10: | |./arch/arm64/include/asm/pgtable-types.h:28:24: | ./arch/arm64/include/asm/pgtable.h:436:26: note: in expansion of macro ‘pmd_val’ | arch/arm64/mm/hugetlbpage.c:242:10: note: in expansion of macro ‘pte_alloc_map’ This can only occur when the kernel cannot allocate a page, and so is unlikely to happen in practice before other systems start failing. We can avoid this by bailing out if pmd_alloc() fails, as we do earlier in the function if pud_alloc() fails. Fixes: 66b3923a1a ("arm64: hugetlb: add support for PTE contiguous bit") Signed-off-by: Mark Rutland <mark.rutland@arm.com> Reported-by: Kyrill Tkachov <kyrylo.tkachov@arm.com> Cc: <stable@vger.kernel.org> # 4.5.x- Cc: Will Deacon <will@kernel.org> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>		2020-05-07 09:24:15 +01:00
..
cache.S	arm64: mm: Use modern annotations for assembly functions	2020-01-08 12:23:38 +00:00
context.c	arm64 updates for 5.7:	2020-03-31 10:05:01 -07:00
copypage.c
dma-mapping.c
dump.c	x86: mm: avoid allocating struct mm_struct on the stack	2020-02-04 03:05:25 +00:00
extable.c
fault.c	mm/vma: introduce VM_ACCESS_FLAGS	2020-04-10 15:36:21 -07:00
flush.c
hugetlbpage.c	arm64: hugetlb: avoid potential NULL dereference	2020-05-07 09:24:15 +01:00
init.c	mm: hugetlb: optionally allocate gigantic hugepages using cma	2020-04-10 15:36:21 -07:00
ioremap.c
kasan_init.c
Makefile	arm64: mm: convert mm/dump.c to use walk_page_range()	2020-02-04 03:05:25 +00:00
mmap.c
mmu.c	mm/memory_hotplug: add pgprot_t to mhp_params	2020-04-10 15:36:21 -07:00
numa.c
pageattr.c	mm: change_memory_common: add spaces for * operator	2020-01-08 17:30:33 +00:00
pgd.c
physaddr.c
proc.S	Merge branch 'for-next/kernel-ptrauth' into for-next/core	2020-03-25 11:11:08 +00:00
ptdump_debugfs.c	arm64/mm: Hold memory hotplug lock while walking for kernel page table dump	2020-03-04 15:35:22 +00:00