Vladis Dronov d5468d7afa [media] usbvision: revert commit 588afcc1 ... Commit 588afcc1c0 ("[media] usbvision fix overflow of interfaces array")' should be reverted, because: * "!dev->actconfig->interface[ifnum]" won't catch a case where the value is not NULL but some garbage. This way the system may crash later with GPF. * "(ifnum >= USB_MAXINTERFACES)" does not cover all the error conditions. "ifnum" should be compared to "dev->actconfig-> desc.bNumInterfaces", i.e. compared to the number of "struct usb_interface" kzalloc()-ed, not to USB_MAXINTERFACES. * There is a "struct usb_device" leak in this error path, as there is usb_get_dev(), but no usb_put_dev() on this path. * There is a bug of the same type several lines below with number of endpoints. The code is accessing hard-coded second endpoint ("interface->endpoint[1].desc") which may not exist. It would be great to handle this in the same patch too. * All the concerns above are resolved by already-accepted commit fa52bd50 ("[media] usbvision: fix crash on detecting device with invalid configuration") * Mailing list message: http://www.spinics.net/lists/linux-media/msg94832.html Signed-off-by: Vladis Dronov <vdronov@redhat.com> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Cc: <stable@vger.kernel.org> # for v4.5 Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>		2016-04-20 15:58:54 -03:00
..
Kconfig
Makefile
usbvision-cards.c
usbvision-cards.h
usbvision-core.c	[media] include/media: split I2C headers from V4L2 core	2015-11-17 06:57:11 -02:00
usbvision-i2c.c	[media] usbvision: fix DMA from stack warnings	2015-08-11 06:54:22 -03:00
usbvision-video.c	[media] usbvision: revert commit 588afcc1	2016-04-20 15:58:54 -03:00
usbvision.h	[media] usbvision: frequency fixes	2015-08-11 06:52:31 -03:00