Johannes Berg 634fef6107 networking: add and use skb_put_u8() ... Joe and Bjørn suggested that it'd be nicer to not have the cast in the fairly common case of doing *(u8 *)skb_put(skb, 1) = c; Add skb_put_u8() for this case, and use it across the code, using the following spatch: @@ expression SKB, C, S; typedef u8; identifier fn = {skb_put}; fresh identifier fn2 = fn ## "_u8"; @@ - *(u8 *)fn(SKB, S) = C; + fn2(SKB, C); Note that due to the "S", the spatch isn't perfect, it should have checked that S is 1, but there's also places that use a sizeof expression like sizeof(var) or sizeof(u8) etc. Turns out that nobody ever did something like *(u8 *)skb_put(skb, 2) = c; which would be wrong anyway since the second byte wouldn't be initialized. Suggested-by: Joe Perches <joe@perches.com> Suggested-by: Bjørn Mork <bjorn@mork.no> Signed-off-by: Johannes Berg <johannes.berg@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2017-06-16 11:48:40 -04:00
..
capi.c	networking: add and use skb_put_u8()	2017-06-16 11:48:40 -04:00
capidrv.c	networking: introduce and use skb_put_data()	2017-06-16 11:48:37 -04:00
capidrv.h
capilib.c
capiutil.c	isdn/capi: correct argument types of command_2_index	2014-12-10 15:06:10 -05:00
kcapi_proc.c
kcapi.c	isdn: kcapi: avoid uninitialized data	2017-03-28 17:59:33 -07:00
kcapi.h
Kconfig	isdn/capi: fix (middleware) device nodes	2014-06-04 23:13:41 -07:00
Makefile