Xin Long db5f1c6f77 sctp: fix a SCTP_MIB_CURRESTAB leak in sctp_sf_do_dupcook_b ... [ Upstream commit f282df0391267fb2b263da1cc3233aa6fb81defc ] Normally SCTP_MIB_CURRESTAB is always incremented once asoc enter into ESTABLISHED from the state < ESTABLISHED and decremented when the asoc is being deleted. However, in sctp_sf_do_dupcook_b(), the asoc's state can be changed to ESTABLISHED from the state >= ESTABLISHED where it shouldn't increment SCTP_MIB_CURRESTAB. Otherwise, one asoc may increment MIB_CURRESTAB multiple times but only decrement once at the end. I was able to reproduce it by using scapy to do the 4-way shakehands, after that I replayed the COOKIE-ECHO chunk with 'peer_vtag' field changed to different values, and SCTP_MIB_CURRESTAB was incremented multiple times and never went back to 0 even when the asoc was freed. This patch is to fix it by only incrementing SCTP_MIB_CURRESTAB when the state < ESTABLISHED in sctp_sf_do_dupcook_b(). Fixes: 1da177e4c3 ("Linux-2.6.12-rc2") Reported-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> Signed-off-by: Xin Long <lucien.xin@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-05-19 10:13:06 +02:00
..
associola.c
auth.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-10-08 15:44:50 -07:00
bind_addr.c
chunk.c
debug.c
diag.c
endpointola.c
input.c	sctp: change to hold/put transport for proto_unreach_timer	2020-11-14 11:57:12 -08:00
inqueue.c
ipv6.c	net-ipv6: bugfix - raw & sctp - switch to ipv6_can_nonlocal_bind()	2021-04-14 08:42:02 +02:00
Kconfig
Makefile
objcnt.c
offload.c
output.c
outqueue.c
primitive.c
proc.c	net: fix iteration for sctp transport seq_files	2021-02-17 11:02:29 +01:00
protocol.c
sm_make_chunk.c	sctp: Fix out-of-bounds warning in sctp_process_asconf_param()	2021-05-19 10:12:57 +02:00
sm_sideeffect.c	sctp: change to hold/put transport for proto_unreach_timer	2020-11-14 11:57:12 -08:00
sm_statefuns.c	sctp: fix a SCTP_MIB_CURRESTAB leak in sctp_sf_do_dupcook_b	2021-05-19 10:13:06 +02:00
sm_statetable.c
socket.c	sctp: delay auto_asconf init until binding the first addr	2021-05-14 09:50:46 +02:00
stream_interleave.c
stream_sched_prio.c
stream_sched_rr.c
stream_sched.c
stream.c
sysctl.c
transport.c	sctp: change to hold/put transport for proto_unreach_timer	2020-11-14 11:57:12 -08:00
tsnmap.c
ulpevent.c
ulpqueue.c