mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-28 11:18:45 +07:00
2d2924af96
This patch fixes following (similar) warning reported by kbuild test robot:
In function ‘memcpy’,
inlined from ‘smsc75xx_init_mac_address’ at drivers/net/usb/smsc75xx.c:778:3,
inlined from ‘smsc75xx_bind’ at drivers/net/usb/smsc75xx.c:1501:2:
./include/linux/string.h:355:9: warning: argument 2 null where non-null expected [-Wnonnull]
return __builtin_memcpy(p, q, size);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/usb/smsc75xx.c: In function ‘smsc75xx_bind’:
./include/linux/string.h:355:9: note: in a call to built-in function ‘__builtin_memcpy’
I've replaced the offending memcpy with ether_addr_copy, because I'm
100% sure, that of_get_mac_address can't return NULL as it returns valid
pointer or ERR_PTR encoded value, nothing else.
I'm hesitant to just change IS_ERR into IS_ERR_OR_NULL check, as this
would make the warning disappear also, but it would be confusing to
check for impossible return value just to make a compiler happy.
I'm now changing all occurencies of memcpy to ether_addr_copy after the
of_get_mac_address call, as it's very likely, that we're going to get
similar reports from kbuild test robot in the future.
Fixes:
|
||
|---|---|---|
| .. | ||
| dpaa | ||
| dpaa2 | ||
| enetc | ||
| fman | ||
| fs_enet | ||
| fec_main.c | ||
| fec_mpc52xx_phy.c | ||
| fec_mpc52xx.c | ||
| fec_mpc52xx.h | ||
| fec_ptp.c | ||
| fec.h | ||
| fsl_pq_mdio.c | ||
| gianfar_ethtool.c | ||
| gianfar.c | ||
| gianfar.h | ||
| Kconfig | ||
| Makefile | ||
| ucc_geth_ethtool.c | ||
| ucc_geth.c | ||
| ucc_geth.h | ||
| xgmac_mdio.c | ||