mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-25 11:22:33 +07:00
99a3eb3845
seqlock_init() needs to use spin_lock_init() for dynamic locks, so that lockdep is notified about the presence of a new lock. (this is a fallout of the recent networking merge, which started using the so-far unused seqlock_init() API.) This fix solves the following lockdep-internal warning on current -git: INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. __lock_acquire+0x10c/0x9f9 lock_acquire+0x56/0x72 _spin_lock+0x35/0x42 neigh_destroy+0x9d/0x12e neigh_periodic_timer+0x10a/0x15c run_timer_softirq+0x126/0x18e __do_softirq+0x6b/0xe6 do_softirq+0x64/0xd2 ksoftirqd+0x82/0x138 Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
186 lines
4.7 KiB
C
186 lines
4.7 KiB
C
#ifndef __LINUX_SEQLOCK_H
|
|
#define __LINUX_SEQLOCK_H
|
|
/*
|
|
* Reader/writer consistent mechanism without starving writers. This type of
|
|
* lock for data where the reader wants a consitent set of information
|
|
* and is willing to retry if the information changes. Readers never
|
|
* block but they may have to retry if a writer is in
|
|
* progress. Writers do not wait for readers.
|
|
*
|
|
* This is not as cache friendly as brlock. Also, this will not work
|
|
* for data that contains pointers, because any writer could
|
|
* invalidate a pointer that a reader was following.
|
|
*
|
|
* Expected reader usage:
|
|
* do {
|
|
* seq = read_seqbegin(&foo);
|
|
* ...
|
|
* } while (read_seqretry(&foo, seq));
|
|
*
|
|
*
|
|
* On non-SMP the spin locks disappear but the writer still needs
|
|
* to increment the sequence variables because an interrupt routine could
|
|
* change the state of the data.
|
|
*
|
|
* Based on x86_64 vsyscall gettimeofday
|
|
* by Keith Owens and Andrea Arcangeli
|
|
*/
|
|
|
|
#include <linux/spinlock.h>
|
|
#include <linux/preempt.h>
|
|
|
|
typedef struct {
|
|
unsigned sequence;
|
|
spinlock_t lock;
|
|
} seqlock_t;
|
|
|
|
/*
|
|
* These macros triggered gcc-3.x compile-time problems. We think these are
|
|
* OK now. Be cautious.
|
|
*/
|
|
#define __SEQLOCK_UNLOCKED(lockname) \
|
|
{ 0, __SPIN_LOCK_UNLOCKED(lockname) }
|
|
|
|
#define SEQLOCK_UNLOCKED \
|
|
__SEQLOCK_UNLOCKED(old_style_seqlock_init)
|
|
|
|
#define seqlock_init(x) \
|
|
do { \
|
|
(x)->sequence = 0; \
|
|
spin_lock_init(&(x)->lock); \
|
|
} while (0)
|
|
|
|
#define DEFINE_SEQLOCK(x) \
|
|
seqlock_t x = __SEQLOCK_UNLOCKED(x)
|
|
|
|
/* Lock out other writers and update the count.
|
|
* Acts like a normal spin_lock/unlock.
|
|
* Don't need preempt_disable() because that is in the spin_lock already.
|
|
*/
|
|
static inline void write_seqlock(seqlock_t *sl)
|
|
{
|
|
spin_lock(&sl->lock);
|
|
++sl->sequence;
|
|
smp_wmb();
|
|
}
|
|
|
|
static inline void write_sequnlock(seqlock_t *sl)
|
|
{
|
|
smp_wmb();
|
|
sl->sequence++;
|
|
spin_unlock(&sl->lock);
|
|
}
|
|
|
|
static inline int write_tryseqlock(seqlock_t *sl)
|
|
{
|
|
int ret = spin_trylock(&sl->lock);
|
|
|
|
if (ret) {
|
|
++sl->sequence;
|
|
smp_wmb();
|
|
}
|
|
return ret;
|
|
}
|
|
|
|
/* Start of read calculation -- fetch last complete writer token */
|
|
static __always_inline unsigned read_seqbegin(const seqlock_t *sl)
|
|
{
|
|
unsigned ret = sl->sequence;
|
|
smp_rmb();
|
|
return ret;
|
|
}
|
|
|
|
/* Test if reader processed invalid data.
|
|
* If initial values is odd,
|
|
* then writer had already started when section was entered
|
|
* If sequence value changed
|
|
* then writer changed data while in section
|
|
*
|
|
* Using xor saves one conditional branch.
|
|
*/
|
|
static __always_inline int read_seqretry(const seqlock_t *sl, unsigned iv)
|
|
{
|
|
smp_rmb();
|
|
return (iv & 1) | (sl->sequence ^ iv);
|
|
}
|
|
|
|
|
|
/*
|
|
* Version using sequence counter only.
|
|
* This can be used when code has its own mutex protecting the
|
|
* updating starting before the write_seqcountbeqin() and ending
|
|
* after the write_seqcount_end().
|
|
*/
|
|
|
|
typedef struct seqcount {
|
|
unsigned sequence;
|
|
} seqcount_t;
|
|
|
|
#define SEQCNT_ZERO { 0 }
|
|
#define seqcount_init(x) do { *(x) = (seqcount_t) SEQCNT_ZERO; } while (0)
|
|
|
|
/* Start of read using pointer to a sequence counter only. */
|
|
static inline unsigned read_seqcount_begin(const seqcount_t *s)
|
|
{
|
|
unsigned ret = s->sequence;
|
|
smp_rmb();
|
|
return ret;
|
|
}
|
|
|
|
/* Test if reader processed invalid data.
|
|
* Equivalent to: iv is odd or sequence number has changed.
|
|
* (iv & 1) || (*s != iv)
|
|
* Using xor saves one conditional branch.
|
|
*/
|
|
static inline int read_seqcount_retry(const seqcount_t *s, unsigned iv)
|
|
{
|
|
smp_rmb();
|
|
return (iv & 1) | (s->sequence ^ iv);
|
|
}
|
|
|
|
|
|
/*
|
|
* Sequence counter only version assumes that callers are using their
|
|
* own mutexing.
|
|
*/
|
|
static inline void write_seqcount_begin(seqcount_t *s)
|
|
{
|
|
s->sequence++;
|
|
smp_wmb();
|
|
}
|
|
|
|
static inline void write_seqcount_end(seqcount_t *s)
|
|
{
|
|
smp_wmb();
|
|
s->sequence++;
|
|
}
|
|
|
|
/*
|
|
* Possible sw/hw IRQ protected versions of the interfaces.
|
|
*/
|
|
#define write_seqlock_irqsave(lock, flags) \
|
|
do { local_irq_save(flags); write_seqlock(lock); } while (0)
|
|
#define write_seqlock_irq(lock) \
|
|
do { local_irq_disable(); write_seqlock(lock); } while (0)
|
|
#define write_seqlock_bh(lock) \
|
|
do { local_bh_disable(); write_seqlock(lock); } while (0)
|
|
|
|
#define write_sequnlock_irqrestore(lock, flags) \
|
|
do { write_sequnlock(lock); local_irq_restore(flags); } while(0)
|
|
#define write_sequnlock_irq(lock) \
|
|
do { write_sequnlock(lock); local_irq_enable(); } while(0)
|
|
#define write_sequnlock_bh(lock) \
|
|
do { write_sequnlock(lock); local_bh_enable(); } while(0)
|
|
|
|
#define read_seqbegin_irqsave(lock, flags) \
|
|
({ local_irq_save(flags); read_seqbegin(lock); })
|
|
|
|
#define read_seqretry_irqrestore(lock, iv, flags) \
|
|
({ \
|
|
int ret = read_seqretry(lock, iv); \
|
|
local_irq_restore(flags); \
|
|
ret; \
|
|
})
|
|
|
|
#endif /* __LINUX_SEQLOCK_H */
|