Jiri Pirko 0f2d2b2736 mlxsw: spectrum_router: Fix error path in mlxsw_sp_vr_create ... Since mlxsw_sp_fib_create() and mlxsw_sp_mr_table_create() use ERR_PTR macro to propagate int err through return of a pointer, the return value is not NULL in case of failure. So if one of the calls fails, one of vr->fib4, vr->fib6 or vr->mr4_table is not NULL and mlxsw_sp_vr_is_used wrongly assumes that vr is in use which leads to crash like following one: [ 1293.949291] BUG: unable to handle kernel NULL pointer dereference at 00000000000006c9 [ 1293.952729] IP: mlxsw_sp_mr_table_flush+0x15/0x70 [mlxsw_spectrum] Fix this by using local variables to hold the pointers and set vr->* only in case everything went fine. Fixes: 76610ebbde ("mlxsw: spectrum_router: Refactor virtual router handling") Fixes: a3d9bc506d ("mlxsw: spectrum_router: Extend virtual routers with IPv6 support") Fixes: d42b0965b1 ("mlxsw: spectrum_router: Add multicast routes notification handling functionality") Signed-off-by: Jiri Pirko <jiri@mellanox.com> Reviewed-by: Ido Schimmel <idosch@mellanox.com> Signed-off-by: Jiri Pirko <jiri@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2018-02-13 12:22:29 -05:00
..
mlx4	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2018-01-31 14:31:10 -08:00
mlx5/core	Second pull request for 4.16 merge window	2018-02-06 11:09:45 -08:00
mlxfw	net/mlxfw: Properly handle dependancy with non-loadable mlx5	2017-07-03 02:32:25 -07:00
mlxsw	mlxsw: spectrum_router: Fix error path in mlxsw_sp_vr_create	2018-02-13 12:22:29 -05:00
Kconfig	Change Kconfig description	2017-08-14 11:18:16 -07:00
Makefile	Add the mlxfw module for Mellanox firmware flash process	2017-05-25 17:46:17 -04:00