Willem de Bruijn 0c19f846d5 net: accept UFO datagrams from tuntap and packet ... Tuntap and similar devices can inject GSO packets. Accept type VIRTIO_NET_HDR_GSO_UDP, even though not generating UFO natively. Processes are expected to use feature negotiation such as TUNSETOFFLOAD to detect supported offload types and refrain from injecting other packets. This process breaks down with live migration: guest kernels do not renegotiate flags, so destination hosts need to expose all features that the source host does. Partially revert the UFO removal from 182e0b6b5846~1..d9d30adf5677. This patch introduces nearly(*) no new code to simplify verification. It brings back verbatim tuntap UFO negotiation, VIRTIO_NET_HDR_GSO_UDP insertion and software UFO segmentation. It does not reinstate protocol stack support, hardware offload (NETIF_F_UFO), SKB_GSO_UDP tunneling in SKB_GSO_SOFTWARE or reception of VIRTIO_NET_HDR_GSO_UDP packets in tuntap. To support SKB_GSO_UDP reappearing in the stack, also reinstate logic in act_csum and openvswitch. Achieve equivalence with v4.13 HEAD by squashing in commit 939912216f ("net: skb_needs_check() removes CHECKSUM_UNNECESSARY check for tx.") and reverting commit 8d63bee643 ("net: avoid skb_warn_bad_offload false positives on UFO"). (*) To avoid having to bring back skb_shinfo(skb)->ip6_frag_id, ipv6_proxy_select_ident is changed to return a __be32 and this is assigned directly to the frag_hdr. Also, SKB_GSO_UDP is inserted at the end of the enum to minimize code churn. Tested Booted a v4.13 guest kernel with QEMU. On a host kernel before this patch `ethtool -k eth0` shows UFO disabled. After the patch, it is enabled, same as on a v4.13 host kernel. A UFO packet sent from the guest appears on the tap device: host: nc -l -p -u 8000 & tcpdump -n -i tap0 guest: dd if=/dev/zero of=payload.txt bs=1 count=2000 nc -u 192.16.1.1 8000 < payload.txt Direct tap to tap transmission of VIRTIO_NET_HDR_GSO_UDP succeeds, packets arriving fragmented: ./with_tap_pair.sh ./tap_send_ufo tap0 tap1 (from https://github.com/wdebruij/kerneltools/tree/master/tests) Changes v1 -> v2 - simplified set_offload change (review comment) - documented test procedure Link: http://lkml.kernel.org/r/<CAF=yD-LuUeDuL9YWPJD9ykOZ0QCjNeznPDr6whqZ9NGMNF12Mw@mail.gmail.com> Fixes: fb652fdfe8 ("macvlan/macvtap: Remove NETIF_F_UFO advertisement.") Reported-by: Michal Kubecek <mkubecek@suse.cz> Signed-off-by: Willem de Bruijn <willemb@google.com> Acked-by: Jason Wang <jasowang@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2017-11-24 01:37:35 +09:00
..
acpi	TTY/Serial patches for 4.15-rc1	2017-11-13 21:05:31 -08:00
asm-generic	include/asm-generic/topology.h: remove unused parent_node() macro	2017-11-17 16:10:05 -08:00
clocksource	arm64 updates for 4.15	2017-11-15 10:56:56 -08:00
crypto	Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6	2017-11-14 10:52:09 -08:00
drm	amdgpu DC display code for Vega.	2017-11-17 14:34:42 -08:00
dt-bindings	We have two changes to the core framework this time around. The first being a	2017-11-17 20:04:24 -08:00
keys
kvm
lib
linux	net: accept UFO datagrams from tuntap and packet	2017-11-24 01:37:35 +09:00
math-emu
media	media updates for v4.15-rc1	2017-11-15 20:30:12 -08:00
memory
misc
net	net: accept UFO datagrams from tuntap and packet	2017-11-24 01:37:35 +09:00
pcmcia
ras
rdma	Updates for 4.15 kernel merge window	2017-11-15 14:54:53 -08:00
scsi	SCSI misc on 20171114	2017-11-14 16:23:44 -08:00
soc	We have two changes to the core framework this time around. The first being a	2017-11-17 20:04:24 -08:00
sound	ASoC: Updates for v4.15	2017-11-13 15:45:57 +01:00
target	A couple of configfs cleanups:	2017-11-14 14:44:04 -08:00
trace	Lots of good bugfixes, including:	2017-11-18 11:22:04 -08:00
uapi	platform-drivers-x86 for v4.15-1	2017-11-18 10:26:57 -08:00
video	fbdev changes for v4.15:	2017-11-20 21:50:24 -10:00
xen	xen: features and fixes for v4.15-rc1	2017-11-16 13:06:27 -08:00