Jeff Layton 0c0e0d3c09 nfs: revert "nfs4: queue free_lock_state job submission to nfsiod" ... This reverts commit 49a4bda22e. Christoph reported an oops due to the above commit: generic/089 242s ...[ 2187.041239] general protection fault: 0000 [#1] SMP [ 2187.042899] Modules linked in: [ 2187.044000] CPU: 0 PID: 11913 Comm: kworker/0:1 Not tainted 3.16.0-rc6+ #1151 [ 2187.044287] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2007 [ 2187.044287] Workqueue: nfsiod free_lock_state_work [ 2187.044287] task: ffff880072b50cd0 ti: ffff88007a4ec000 task.ti: ffff88007a4ec000 [ 2187.044287] RIP: 0010:[<ffffffff81361ca6>] [<ffffffff81361ca6>] free_lock_state_work+0x16/0x30 [ 2187.044287] RSP: 0018:ffff88007a4efd58 EFLAGS: 00010296 [ 2187.044287] RAX: 6b6b6b6b6b6b6b6b RBX: ffff88007a947ac0 RCX: 8000000000000000 [ 2187.044287] RDX: ffffffff826af9e0 RSI: ffff88007b093c00 RDI: ffff88007b093db8 [ 2187.044287] RBP: ffff88007a4efd58 R08: ffffffff832d3e10 R09: 000001c40efc0000 [ 2187.044287] R10: 0000000000000000 R11: 0000000000059e30 R12: ffff88007fc13240 [ 2187.044287] R13: ffff88007fc18b00 R14: ffff88007b093db8 R15: 0000000000000000 [ 2187.044287] FS: 0000000000000000(0000) GS:ffff88007fc00000(0000) knlGS:0000000000000000 [ 2187.044287] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b [ 2187.044287] CR2: 00007f93ec33fb80 CR3: 0000000079dc2000 CR4: 00000000000006f0 [ 2187.044287] Stack: [ 2187.044287] ffff88007a4efdd8 ffffffff810cc877 ffffffff810cc80d ffff88007fc13258 [ 2187.044287] 000000007a947af0 0000000000000000 ffffffff8353ccc8 ffffffff82b6f3d0 [ 2187.044287] 0000000000000000 ffffffff82267679 ffff88007a4efdd8 ffff88007fc13240 [ 2187.044287] Call Trace: [ 2187.044287] [<ffffffff810cc877>] process_one_work+0x1c7/0x490 [ 2187.044287] [<ffffffff810cc80d>] ? process_one_work+0x15d/0x490 [ 2187.044287] [<ffffffff810cd569>] worker_thread+0x119/0x4f0 [ 2187.044287] [<ffffffff810fbbad>] ? trace_hardirqs_on+0xd/0x10 [ 2187.044287] [<ffffffff810cd450>] ? init_pwq+0x190/0x190 [ 2187.044287] [<ffffffff810d3c6f>] kthread+0xdf/0x100 [ 2187.044287] [<ffffffff810d3b90>] ? __init_kthread_worker+0x70/0x70 [ 2187.044287] [<ffffffff81d9873c>] ret_from_fork+0x7c/0xb0 [ 2187.044287] [<ffffffff810d3b90>] ? __init_kthread_worker+0x70/0x70 [ 2187.044287] Code: 0f 1f 44 00 00 31 c0 5d c3 66 66 66 2e 0f 1f 84 00 00 00 00 00 55 48 8d b7 48 fe ff ff 48 8b 87 58 fe ff ff 48 89 e5 48 8b 40 30 <48> 8b 00 48 8b 10 48 89 c7 48 8b 92 90 03 00 00 ff 52 28 5d c3 [ 2187.044287] RIP [<ffffffff81361ca6>] free_lock_state_work+0x16/0x30 [ 2187.044287] RSP <ffff88007a4efd58> [ 2187.103626] ---[ end trace 0f11326d28e5d8fa ]--- The original reason for this patch was because the fl_release_private operation couldn't sleep. With commit ed9814d858 (locks: defer freeing locks in locks_delete_lock until after i_lock has been dropped), this is no longer a problem so we can revert this patch. Reported-by: Christoph Hellwig <hch@infradead.org> Signed-off-by: Jeff Layton <jlayton@primarydata.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Tested-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>		2014-09-08 17:00:32 -07:00
..
blocklayout	FS/NFS: replace count*size kzalloc by kcalloc	2014-06-25 19:02:14 -04:00
filelayout	NFS client updates for Linux 3.17	2014-08-13 18:13:19 -06:00
objlayout	nfs: remove unused writeverf code	2014-06-24 18:47:00 -04:00
cache_lib.c	NFS: simplify and clean cache library	2013-02-15 10:43:36 -05:00
cache_lib.h	NFS: simplify and clean cache library	2013-02-15 10:43:36 -05:00
callback_proc.c	NFSv4.1: Minor optimisation in get_layout_by_fh_locked()	2014-02-19 21:21:06 -05:00
callback_xdr.c	Merge branch 'labeled-nfs' into linux-next	2013-06-28 16:29:51 -04:00
callback.c	nfs4: copy acceptor name from context to nfs_client	2014-07-12 18:41:25 -04:00
callback.h	NFS: Add in v4.2 callback operation	2013-06-08 16:20:18 -04:00
client.c	nfs: fix kernel warning when removing proc entry	2014-09-08 16:41:36 -07:00
delegation.c	nfs4: add nfs4_check_delegation	2014-07-12 18:22:58 -04:00
delegation.h	nfs4: add nfs4_check_delegation	2014-07-12 18:22:58 -04:00
dir.c	NFS: fix two problems in lookup_revalidate in RCU-walk	2014-08-04 09:22:08 -04:00
direct.c	Merge branch 'bugfixes' into linux-next	2014-07-13 15:22:02 -04:00
dns_resolve.c	NFS: Enabling v4.2 should not recompile nfsd and lockd	2013-11-19 16:20:40 -05:00
dns_resolve.h	NFS: DNS resolver cache per network namespace context introduced	2012-01-31 18:20:26 -05:00
file.c	sched: Remove proliferation of wait_on_bit() action functions	2014-07-16 15:10:39 +02:00
fscache-index.c	NFS: Use the inode->i_version to cache NFSv4 change attribute information	2011-10-18 09:14:34 -07:00
fscache.c	NFS: Use i_writecount to control whether to get an fscache cookie in nfs_open()	2013-09-27 18:40:25 +01:00
fscache.h	NFS: Use i_writecount to control whether to get an fscache cookie in nfs_open()	2013-09-27 18:40:25 +01:00
getroot.c	dcache: d_obtain_alias callers don't all want DISCONNECTED	2014-08-07 14:40:10 -04:00
idmap.c	Merge branch 'keys-fixes' into keys-next	2014-07-22 21:55:45 +01:00
inode.c	NFS client updates for Linux 3.17	2014-08-13 18:13:19 -06:00
internal.h	NFS client updates for Linux 3.17	2014-08-13 18:13:19 -06:00
iostat.h	NFS: Squelch compiler warning in nfs_add_server_stats()	2010-05-14 15:09:31 -04:00
Kconfig	nfs: fix pnfs Kconfig defaults	2013-11-15 13:41:43 -05:00
Makefile	Push the file layout driver into a subdirectory	2014-05-29 20:21:56 -04:00
mount_clnt.c	nfs: have nfs_mount fake up a auth_flavs list when the server didn't provide it	2013-06-28 15:51:51 -04:00
namespace.c	nfs: use %p[dD] instead of open-coded (and often racy) equivalents	2013-10-24 23:34:50 -04:00
netns.h	NFS: Fix /proc/fs/nfsfs/servers and /proc/fs/nfsfs/volumes	2014-08-04 09:28:32 -07:00
nfs2super.c	NFS: Convert v2 into a module	2012-07-30 19:06:41 -04:00
nfs2xdr.c	NFS: Create a common results structure for reads and writes	2014-05-28 18:12:43 -04:00
nfs3acl.c	NFSv3: Fix another acl regression	2014-08-26 16:17:48 -04:00
nfs3client.c	NFS: Only initialize the ACL client in the v3 case	2012-07-30 19:05:54 -04:00
nfs3proc.c	Merge branch 'bugfixes' into linux-next	2014-07-13 15:22:02 -04:00
nfs3super.c	nfs: use generic posix ACL infrastructure for v3 Posix ACLs	2014-01-26 08:26:20 -05:00
nfs3xdr.c	NFS: Create a common results structure for reads and writes	2014-05-28 18:12:43 -04:00
nfs4_fs.h	nfs: revert "nfs4: queue free_lock_state job submission to nfsiod"	2014-09-08 17:00:32 -07:00
nfs4client.c	nfsv4: set hostname when creating nfsv4 ds connection	2014-07-08 14:30:03 -04:00
nfs4file.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2014-06-12 10:30:18 -07:00
nfs4getroot.c	NFSv4: Fix security auto-negotiation	2013-09-07 16:18:30 -04:00
nfs4namespace.c	NFSv4: test SECINFO RPC_AUTH_GSS pseudoflavors for support	2014-06-24 18:46:58 -04:00
nfs4proc.c	NFSv4: Don't clear the open state when we just did an OPEN_DOWNGRADE	2014-08-26 16:17:48 -04:00
nfs4renewd.c	workqueue: use mod_delayed_work() instead of cancel + queue	2012-08-13 16:27:37 -07:00
nfs4session.c	NFSv4.1: nfs4_destroy_session must call rpc_destroy_waitqueue	2014-02-01 15:13:39 -05:00
nfs4session.h	NFSv4.1: nfs4_destroy_session must call rpc_destroy_waitqueue	2014-02-01 15:13:39 -05:00
nfs4state.c	nfs: revert "nfs4: queue free_lock_state job submission to nfsiod"	2014-09-08 17:00:32 -07:00
nfs4super.c	mm + fs: store shadow entries in page cache	2014-04-03 16:21:01 -07:00
nfs4sysctl.c	nfs: convert use of typedef ctl_table to struct ctl_table	2014-06-06 16:08:16 -07:00
nfs4trace.c	NFSv4.1: Add tracepoints for debugging slot table operations	2013-08-22 08:58:27 -04:00
nfs4trace.h	nfs: merge nfs_pgio_data into _header	2014-06-24 18:47:00 -04:00
nfs4xdr.c	NFSv4: Drop cast	2014-07-12 18:43:47 -04:00
nfs.h	NFS: Convert v4 into a module	2012-07-30 19:06:52 -04:00
nfsroot.c	SUNRPC/NFS: Add Kbuild dependencies for NFS_DEBUG/RPC_DEBUG	2012-03-20 13:08:26 -04:00
nfstrace.c	NFS: Add event tracing for generic NFS lookups	2013-08-22 08:58:18 -04:00
nfstrace.h	NFS: fix the handling of NFS_INO_INVALID_DATA flag in nfs_revalidate_mapping	2014-01-27 15:35:56 -05:00
pagelist.c	nfs: Don't busy-wait on SIGKILL in __nfs_iocounter_wait	2014-08-22 18:04:44 -04:00
pnfs_dev.c	hlist: drop the node parameter from iterators	2013-02-27 19:10:24 -08:00
pnfs.c	NFS client updates for Linux 3.17	2014-08-13 18:13:19 -06:00
pnfs.h	pnfs: add pnfs_put_lseg_async	2014-08-03 17:05:25 -04:00
proc.c	nfs: merge nfs_pgio_data into _header	2014-06-24 18:47:00 -04:00
read.c	nfs: get rid of duplicate dprintk	2014-06-25 19:01:27 -04:00
super.c	nfs: reject changes to resvport and sharecache during remount	2014-08-04 17:41:52 -04:00
symlink.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	2010-03-30 22:02:32 +09:00
sysctl.c	nfs: convert use of typedef ctl_table to struct ctl_table	2014-06-06 16:08:16 -07:00
unlink.c	nfs: emit a fsnotify_nameremove call in sillyrename codepath	2014-03-17 15:14:17 -04:00
write.c	nfs: don't sleep with inode lock in lock_and_join_requests	2014-08-22 18:04:43 -04:00