Sebastian Andrzej Siewior 0aa525d118 tty: serial: 8250_core: read only RX if there is something in the FIFO ... The serial8250_do_startup() function unconditionally clears the interrupts and for that it reads from the RX-FIFO without checking if there is a byte in the FIFO or not. This works fine on OMAP4+ HW like AM335x or DRA7. OMAP3630 ES1.1 (which means probably all OMAP3 and earlier) does not like this: |Unhandled fault: external abort on non-linefetch (0x1028) at 0xfb020000 |Internal error: : 1028 [#1] ARM |Modules linked in: |CPU: 0 PID: 1 Comm: swapper Not tainted 3.16.0-00022-g7edcb57-dirty #1213 |task: de0572c0 ti: de058000 task.ti: de058000 |PC is at mem32_serial_in+0xc/0x1c |LR is at serial8250_do_startup+0x220/0x85c |Flags: nzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment kernel |Control: 10c5387d Table: 80004019 DAC: 00000015 |[<c03051d4>] (mem32_serial_in) from [<c0307fe8>] (serial8250_do_startup+0x220/0x85c) |[<c0307fe8>] (serial8250_do_startup) from [<c0309e00>] (omap_8250_startup+0x5c/0xe0) |[<c0309e00>] (omap_8250_startup) from [<c030863c>] (serial8250_startup+0x18/0x2c) |[<c030863c>] (serial8250_startup) from [<c030394c>] (uart_startup+0x78/0x1d8) |[<c030394c>] (uart_startup) from [<c0304678>] (uart_open+0xe8/0x114) |[<c0304678>] (uart_open) from [<c02e9e10>] (tty_open+0x1a8/0x5a4) Reviewed-by: Tony Lindgren <tony@atomide.com> Tested-by: Tony Lindgren <tony@atomide.com> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2014-09-26 18:01:56 +02:00
..
hvc	tty: Update hypervisor tty drivers to use core stdout parsing code.	2014-06-26 17:12:23 +01:00
ipwireless	tty: ipwireless: Remove tty->closing abort from ipw_open()	2014-07-10 16:06:49 -07:00
serial	tty: serial: 8250_core: read only RX if there is something in the FIFO	2014-09-26 18:01:56 +02:00
vt	tty/vt/keyboard: Resolve many shadow warnings	2014-09-08 16:30:43 -07:00
amiserial.c	tty/amiserial: avoid interruptible_sleep_on	2014-01-07 17:05:21 -08:00
bfin_jtag_comm.c	TTY: bfin_jtag_comm: fix incorrect placement of __initdata tag	2013-09-30 19:09:37 -07:00
cyclades.c	tty: Remove tty_hung_up_p() tests from tty drivers' open()	2014-07-10 16:06:49 -07:00
ehv_bytechan.c	tty: Update hypervisor tty drivers to use core stdout parsing code.	2014-06-26 17:12:23 +01:00
goldfish.c	goldfish: clean up the checkpatch warnings	2014-05-15 13:20:42 -07:00
isicom.c	TTY: switch tty_flip_buffer_push	2013-01-15 22:30:15 -08:00
Kconfig	drivers/tty: ehv_bytechan fails to build as a module	2014-01-09 17:52:12 -06:00
Makefile	tty: Add timed, writer-prioritized rw semaphore	2013-05-20 12:30:32 -07:00
metag_da.c	tree-wide: use reinit_completion instead of INIT_COMPLETION	2013-11-15 09:32:21 +09:00
moxa.c	TTY: fix decimal printf format specifiers prefixed with 0x	2014-09-08 15:51:35 -07:00
moxa.h
mxser.c	tty: mxser: Fix build warning introduced by dfc7b837c7 (Re: linux-next: build warning after merge of the tty.current tree)	2013-05-22 10:26:02 -07:00
mxser.h
n_gsm.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2014-08-06 09:38:14 -07:00
n_hdlc.c	drivers/tty/n_hdlc.c: replace kmalloc/memset by kzalloc	2014-05-28 13:33:18 -07:00
n_r3964.c	tty: Always handle NULL flag ptr	2013-12-08 16:56:05 -08:00
n_tracerouter.c
n_tracesink.c
n_tracesink.h
n_tty.c	tty: Fix spurious poll() wakeups	2014-09-08 15:55:25 -07:00
nozomi.c	drivers/tty/nozomi.c: Use 'nozomi_setup_memory' instead of 'setup_memory'	2014-09-08 16:09:23 -07:00
pty.c	tty: Move packet mode flow control notifications to pty driver	2014-09-23 21:19:35 -07:00
rocket_int.h
rocket.c	tty: remove DEFINE_PCI_DEVICE_TABLE macro	2013-12-08 17:09:07 -08:00
rocket.h
synclink_gt.c	synclink_gt: use pci_zalloc_consistent	2014-08-08 15:57:30 -07:00
synclink.c	tty: Remove tty_hung_up_p() tests from tty drivers' open()	2014-07-10 16:06:49 -07:00
synclinkmp.c	tty: Remove tty_hung_up_p() tests from tty drivers' open()	2014-07-10 16:06:49 -07:00
sysrq.c	mm, oom: ensure memoryless node zonelist always includes zones	2014-08-06 18:01:21 -07:00
tty_audit.c	audit: anchor all pid references in the initial pid namespace	2014-03-20 10:11:55 -04:00
tty_buffer.c	Staging: speakup: Update __speakup_paste_selection() tty (ab)usage to match vt	2014-05-24 02:25:11 +09:00
tty_io.c	tty: Move and rename send_prio_char() as tty_send_xchar()	2014-09-23 21:19:35 -07:00
tty_ioctl.c	tty: Hold termios_rwsem for tcflow(TCIxxx)	2014-09-23 21:19:36 -07:00
tty_ldisc.c	tty: delete non-required instances of include <linux/init.h>	2014-01-07 17:05:21 -08:00
tty_ldsem.c	lockdep: Make held_lock->check and "int check" argument bool	2014-02-09 21:18:54 +01:00
tty_mutex.c
tty_port.c	tty: Remove tty_hung_up_p() tests from tty drivers' open()	2014-07-10 16:06:49 -07:00