linux_dsm_epyc7002/drivers/net/wireless
Christian Lamparter 05e7ba24b1 ath10k: implement set_base_macaddr to fix rx-bssid mask in multiple APs conf
Many integrated QCA9984 WiFis in various IPQ806x platform routers
from various vendors (Netgear R7800, ZyXEL NBG6817, TP-LINK C2600,
etc.) have either blank, bogus or non-unique MAC-addresses in
their calibration data.

As a result, OpenWrt utilizes a discouraged binary calibration data
patching method that allows to modify the device's MAC-addresses right
at the source. This is because the ath10k' firmware extracts the MAC
address from the supplied radio/calibration data and issues a response
to the ath10k linux driver. Which was designed to take the main MAC in
ath10k_wmi_event_ready().

Part of the "setting an alternate MAC" issue was already tackled by a
patch from Brian Norris:
commit 9d5804662c
("ath10k: retrieve MAC address from system firmware if provided")
by allowing the option to specify an alternate MAC-address with the
established device_get_mac_address() function which extracts the right
address from DeviceTree/fwnode mac-address or local-mac-address
properties and saves it for later.

However, Ben Greear noted that the Qualcomm's ath10k firmware is liable
to not properly calculate its rx-bssid mask in this case. This can cause
issues in the popluar "multiple AP with a single ath10k instance"
configurations.

To improve MAC address handling, Felix Fietkau suggested to call
pdev_set_base_macaddr_cmdid before bringing up the first vif and
use the first vif MAC address there. Which is in ath10k_core_start().

This patch implement Felix Fietkau's request to
"call pdev_set_base_macaddr_cmdid before bringing up the first vif".
The pdev_set_base_macaddr_cmdid is already declared for all devices
and version. The driver just needed the support code for this
function.

Tested on:
QCA9880/CUS223, firmwares: 10.2.4.13-2, 10.2.4.70.44, 10.2.4-1.0-00041
QCA9887/MR33 firmware:10.2.4-1.0-00033
QCA4019/RT-AC58U firmware: 10.4-3.4-00104, 10.4-3.5.3-00057
QCA9984/R7800 firmware: Candela Technologies (CT) Firmware

BugLink: https://lists.openwrt.org/pipermail/openwrt-devel/2018-November/014595.html
Fixes: 9d5804662c ("ath10k: retrieve MAC address from system firmware if provided")
Cc: Brian Norris <briannorris@chromium.org>
Cc: Ben Greear <greearb@candelatech.com>
Cc: Felix Fietkau <nbd@nbd.name>
Cc: Mathias Kresin <dev@kresin.me>
Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
Tested-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
2019-02-11 18:27:49 +02:00
..
admtek
ath ath10k: implement set_base_macaddr to fix rx-bssid mask in multiple APs conf 2019-02-11 18:27:49 +02:00
atmel atmel: Replace mdelay() with msleep() in probe_atmel_card() 2018-07-31 10:25:33 +03:00
broadcom wireless-drivers-next patches for 5.1 2019-02-06 09:36:36 -08:00
cisco Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6 2018-12-27 13:53:32 -08:00
intel Merge git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git 2019-02-08 14:14:35 +02:00
intersil Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6 2018-12-27 13:53:32 -08:00
marvell mwifiex: no need to check return value of debugfs_create functions 2019-02-01 14:39:57 +02:00
mediatek Merge git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git 2019-02-08 14:14:35 +02:00
quantenna qtnfmac: no need to check return value of debugfs_create functions 2019-02-01 14:34:13 +02:00
ralink wireless-drivers-next patches for 5.1 2019-02-06 09:36:36 -08:00
realtek wireless: prefix header search paths with $(srctree)/ 2019-02-01 14:42:25 +02:00
rsi rsi: no need to check return value of debugfs_create functions 2019-02-01 14:38:21 +02:00
st cw1200: no need to check return value of debugfs_create functions 2019-02-01 14:34:56 +02:00
ti Merge git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git 2019-02-08 14:14:35 +02:00
zydas zd1201: mark expected switch fall-through 2018-11-06 19:00:12 +02:00
Kconfig mac80211-next: rtnetlink wifi simulation device 2018-12-05 15:31:31 +01:00
mac80211_hwsim.c mac80211_hwsim: check that n_limits makes sense 2019-01-19 09:10:30 +01:00
mac80211_hwsim.h mac80211_hwsim: allow configurable cipher types 2018-11-09 11:36:15 +01:00
Makefile mac80211-next: rtnetlink wifi simulation device 2018-12-05 15:31:31 +01:00
ray_cs.c wireless: remove unneeded semicolon 2019-02-01 14:25:41 +02:00
ray_cs.h
rayctl.h
rndis_wlan.c wireless-drivers: use BIT_ULL for NL80211_STA_INFO_ attribute types 2018-06-27 19:07:39 +03:00
virt_wifi.c Merge remote-tracking branch 'net-next/master' into mac80211-next 2019-02-01 11:05:35 +01:00
wl3501_cs.c
wl3501.h