linux_dsm_epyc7002/drivers/net/ethernet/intel/e1000
Vladimir Davydov 74a1b1ea8a e1000: fix possible reset_task running after adapter down
On e1000_down(), we should ensure every asynchronous work is canceled
before proceeding. Since the watchdog_task can schedule other works
apart from itself, it should be stopped first, but currently it is
stopped after the reset_task. This can result in the following race
leading to the reset_task running after the module unload:

e1000_down_and_stop():			e1000_watchdog():
----------------------			-----------------

cancel_work_sync(reset_task)
					schedule_work(reset_task)
cancel_delayed_work_sync(watchdog_task)

The patch moves cancel_delayed_work_sync(watchdog_task) at the beginning
of e1000_down_and_stop() thus ensuring the race is impossible.

Cc: Tushar Dave <tushar.n.dave@intel.com>
Cc: Patrick McHardy <kaber@trash.net>
Signed-off-by: Vladimir Davydov <vdavydov@parallels.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
2013-11-30 00:02:12 -08:00
..
e1000_ethtool.c drivers:net: Convert dma_alloc_coherent(...__GFP_ZERO) to dma_zalloc_coherent 2013-08-29 21:55:23 -04:00
e1000_hw.c e1000: fix whitespace issues and multi-line comments 2013-02-15 21:46:37 -08:00
e1000_hw.h
e1000_main.c e1000: fix possible reset_task running after adapter down 2013-11-30 00:02:12 -08:00
e1000_osdep.h
e1000_param.c e1000: fix whitespace issues and multi-line comments 2013-02-15 21:46:37 -08:00
e1000.h e1000: fix lockdep warning in e1000_reset_task 2013-11-29 23:55:40 -08:00
Makefile