linux_dsm_epyc7002/drivers/net/ethernet/ibm
David Gibson 4fce14820c ibmveth: Fix off-by-one error in ibmveth_change_mtu()
AFAIK the PAPR document which defines the virtual device interface used by
the ibmveth driver doesn't specify a specific maximum MTU.  So, in the
ibmveth driver, the maximum allowed MTU is determined by the maximum
allocated buffer size of 64k (corresponding to one page in the common case)
minus the per-buffer overhead IBMVETH_BUFF_OH (which has value 22 for 14
bytes of ethernet header, plus 8 bytes for an opaque handle).

This suggests a maximum allowable MTU of 65514 bytes, but in fact the
driver only permits a maximum MTU of 65513.  This is because there is a <
instead of an <= in ibmveth_change_mtu(), which only permits an MTU which
is strictly smaller than the buffer size, rather than allowing the buffer
to be completely filled.

This patch fixes the buglet.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Acked-by: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2015-04-23 11:42:19 -04:00
..
ehea ehea: constify of_device_id array 2015-03-17 15:00:23 -04:00
emac powerpc updates for 4.1 2015-04-16 13:53:32 -05:00
ibmveth.c ibmveth: Fix off-by-one error in ibmveth_change_mtu() 2015-04-23 11:42:19 -04:00
ibmveth.h ibmveth: Fix endian issues with MAC addresses 2014-03-06 16:26:41 -05:00
Kconfig ibm-ethernet: delete stale MCA and duplicate PSERIES dependency 2013-06-03 00:24:31 -07:00
Makefile net: powerpc: remove the legacy iSeries ethernet driver 2012-03-09 23:41:26 -05:00