Oleg Nesterov 013b2deba9 uprobes: ensure that uprobe->offset and ->ref_ctr_offset are properly aligned ... uprobe_write_opcode() must not cross page boundary; prepare_uprobe() relies on arch_uprobe_analyze_insn() which should validate "vaddr" but some architectures (csky, s390, and sparc) don't do this. We can remove the BUG_ON() check in prepare_uprobe() and validate the offset early in __uprobe_register(). The new IS_ALIGNED() check matches the alignment check in arch_prepare_kprobe() on supported architectures, so I think that all insns must be aligned to UPROBE_SWBP_INSN_SIZE. Another problem is __update_ref_ctr() which was wrong from the very beginning, it can read/write outside of kmap'ed page unless "vaddr" is aligned to sizeof(short), __uprobe_register() should check this too. Reported-by: Linus Torvalds <torvalds@linux-foundation.org> Suggested-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Oleg Nesterov <oleg@redhat.com> Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com> Tested-by: Sven Schnelle <svens@linux.ibm.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: stable@vger.kernel.org Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2020-06-09 09:49:24 -07:00
..
callchain.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next	2020-06-03 16:27:18 -07:00
core.c	mm/gup.c: convert to use get_user_{page|pages}_fast_only()	2020-06-08 11:05:56 -07:00
hw_breakpoint.c	powerpc/watchpoint: Don't allow concurrent perf and ptrace events	2020-05-19 00:14:45 +10:00
internal.h	perf/core: Replace zero-length array with flexible-array	2020-05-19 20:34:16 +02:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ring_buffer.c	perf: Make struct ring_buffer less ambiguous	2020-01-13 13:19:38 -05:00
uprobes.c	uprobes: ensure that uprobe->offset and ->ref_ctr_offset are properly aligned	2020-06-09 09:49:24 -07:00