Chase Southwood
571845c6f4
staging: comedi: s626: use comedi_timeout() on remaining loops
...
There were just a handful of more while loops in this file that needed
timeouts, and this patch takes care of them. One new callback is
introduced, and all of the proper comedi_timeout() calls are then used.
The return type of s626_i2c_handshake() has been changed from uint32_t to
int so that a negative error code from comedi_timeout() can be propagated
if necessary.
Signed-off-by: Chase Southwood <chase.southwood@yahoo.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:25 -07:00
Yves Deweerdt
1e4742df19
staging: comedi: drivers.c: Fix missing a blank line, after declarations warning
...
Signed-off-by: Yves Deweerdt <yves.deweerdt.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:25 -07:00
Yves Deweerdt
b2f4874174
staging: comedi: comedy_fops.c: fix line over 80, characters warnings
...
Signed-off-by: Yves Deweerdt <yves.deweerdt.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:25 -07:00
Dan Carpenter
f619621f40
staging: comedi: remove an unneeded variable
...
"chanlist" was left over, we don't need it any more.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:24 -07:00
Jes Sorensen
94b080bc70
staging: rtl8723au: Simplify retrieving the ether_type in portctrl()
...
This renders the last element in include/ethernet.h unnecessary, so
remove it as well.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:24 -07:00
Jes Sorensen
7d0d2b15a0
staging: rtl8723au: Calling rtw_get_stainfo() with a NULL sta_addr will return NULL
...
This makes the follow-on check for psta != NULL pointless and makes
the whole exercise rather pointless. This is another case of why
blindly zero-initializing variables when they are declared is bad.
This bug seems to be present in multiple drivers provided by Realtek.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:23 -07:00
Jes Sorensen
514c485c01
staging: rtl8723au: Fix case where ethtype was never obtained and always be checked against 0
...
Zero-initializing ether_type masked that the ether type would never be
obtained for 8021x packets and the comparition against eapol_type
would always fail.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:23 -07:00
Jes Sorensen
7dd1e72025
staging: rtl8723au: Use proper ETH_P_* types in rtw_recv.c
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:23 -07:00
Jes Sorensen
f4337aa31d
staging: rtl8723au: Call do_div() directly and get rid of unnecessary wrapper functions
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:22 -07:00
Larry Finger
88cdc943c5
staging: rtl8723au: Fix build error due to bad commit 6c89f82
...
Two routines are missing includes of a necessary header.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:22 -07:00
Jes Sorensen
6484767b93
staging: rtl8723au: Remove unused bitshift() function
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:21 -07:00
Jes Sorensen
9cd81fa609
staging: rtl8723au: Remove a couple of unused prototypes
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:21 -07:00
Jes Sorensen
8000d1c413
staging: rtl8723au: No need to include header files for unused circ_buf and old iwpriv bits
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:21 -07:00
Jes Sorensen
458dc03913
staging: rtl8723au: Remove unnecessary forward struct declarations from xmit_osdep.h
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:20 -07:00
Jes Sorensen
4c9c5700d6
staging: rtl8723au: Remove ugly pktfile interface
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:20 -07:00
Jes Sorensen
3e689a9ff5
staging: rtl8723au: Don't use pktfile interface in rtw_xmitframe_coalesce23a()
...
The pktfil interface is horrible, no idea where it came from, but not
using it is a win.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:19 -07:00
Jes Sorensen
69a0f9745c
staging: rtl8723au: Make rtw_xmitframe_coalesce23a() more readable
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:19 -07:00
Jes Sorensen
e59cb424d7
staging: rtl8723au: Fix update_attrib() and set_qos() to not use pktfile nonsense
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:19 -07:00
Jes Sorensen
3483b8ae77
staging: rtl8723au: Use proper ETH_P_* types instead of hard coded constants in rtw_xmit.c
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:18 -07:00
Jes Sorensen
f4f1cb92ae
staging: rtl8723au: Fold rtw_remainder_len23a() into _rtw_open_pktfile23a()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:18 -07:00
Jes Sorensen
41ed2cb92e
staging: rtl8723au: Remove last remnants of CONFIG_BR_EXT
...
Reported-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:18 -07:00
Jes Sorensen
814a1d900e
staging: rtl8723au: rtw_report_sec_ie23a() is only called from rtw_mlme.c
...
Move it there and declare it static
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:17 -07:00
Jes Sorensen
1eb663227f
staging: rtl8723au: Remove unused functions rtw_indicate_sta_{dis,}assoc_event23a()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:17 -07:00
Jes Sorensen
90102edc28
staging: rtl8723au: Fix hopeless brackets for declaring a variable mid-function
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:16 -07:00
Jes Sorensen
b319c6a35d
staging: rtl8723au: Remove unnecessary memset() followed by a memcpy() into the same space
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:16 -07:00
Jes Sorensen
483557be8e
staging: rtl8723au: rtw_os_indicate_connect23a() is only called from one place - fold it in
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:16 -07:00
Jes Sorensen
ce16d2f189
staging: rtl8723au: Don't wrap kill_pid() in an unnecessary macro
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:15 -07:00
Jes Sorensen
810c832f5d
staging: rtl8723au: Remove two layers of wrappers around rtw_cfg80211_indicate_scan_done()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:15 -07:00
Jes Sorensen
141bd353c5
staging: rtl8723au: Remove #ifdef CONFIG_DEBUG_CFG80211
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:15 -07:00
Jes Sorensen
3f58bf2ec0
staging: rtl8723au: Remove unused is_boot_from_eeprom() macro
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:14 -07:00
Jes Sorensen
ec21da4696
staging: rtl8723au: Remove obsolete HW_VARIABLES enum
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:14 -07:00
Jes Sorensen
0a44991073
staging: rtl8723au: Kill off ugly GetHwReg*() interface
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:13 -07:00
Jes Sorensen
8d3fd6145b
staging: rtl8723au: Eliminate HW_WAR_CHK_HI_QUEUE_EMPTY usage
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:13 -07:00
Jes Sorensen
0cee8101d8
staging: rtl8723au: Eliminate HW_VAR_FWLPS_RF_ON usage
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:13 -07:00
Jes Sorensen
c2370e83ab
staging: rtl8723au: Eliminate HW_VAR_RF_TYPE usage
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:12 -07:00
Jes Sorensen
b54e880440
staging: rtl8723au: Improve some bad switch() formatting
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:12 -07:00
Jes Sorensen
f075870605
staging: rtl8723au: Remove empty function rtw_stassoc_hw_rpt23a()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:11 -07:00
Jes Sorensen
891d3decbb
staging: rtl8723au: Remove SetHwReg*() related code
...
Remove all references to this odd mux/demux pseudo hw register
handling code.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:11 -07:00
Jes Sorensen
3d577f60da
staging: rtl8723au: Remove calls to HW_VAR_H2C_MEDIA_STATUS
...
This call was unhandled, so these calls were effectively a no-op
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:11 -07:00
Jes Sorensen
4b03eb73ca
staging: rtl8723au: Eliminate unused HW_VAR_TRIGGER_GPIO_0
...
... and related functions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:10 -07:00
Jes Sorensen
aafb8684a8
staging: rtl8723au: Remove HW_VAR_TXPAUSE
...
This wasn't used at all
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:10 -07:00
Jes Sorensen
a2342292e5
staging: rtl8723au: Remove HW_VAR_EFUSE_{BT_,}BYTES
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:09 -07:00
Jes Sorensen
441ffea706
staging: rtl8723au: Remove HW_VAR_APFM_ON_MAC
...
None of this was ever used, so pull it out together with related variables
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:09 -07:00
Jes Sorensen
df09df24d0
staging: rtl8723au: Eliminate HW_VAR_DM_FLAG
...
Both the read and write calls were never used
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:09 -07:00
Jes Sorensen
585eefb453
staging: rtl8723au: Eliminate HW_VAR_DM_FUNC_{SET,CLR}
...
Unroll two layers of mux/demux in the call chain for each.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:08 -07:00
Jes Sorensen
a945bf3012
staging: rtl8723au: Eliminate HW_VAR_DM_FUNC_OP calls
...
Demux the code and remove multiple call layers
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:08 -07:00
Jes Sorensen
6883e7c720
staging: rtl8723au: Make direct calls for HW_VAR_NAV_UPPER
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:08 -07:00
Jes Sorensen
a3252966e1
staging: rtl8723au: Remove commented out set_hwreg calls
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:07 -07:00
Jes Sorensen
9ff3513cb4
staging: rtl8723au: Make direct calls for HW_VAR_SET_RPWM
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:07 -07:00
Jes Sorensen
c6d921c580
staging: rtl8723au: Make direct calls for HW_VAR_H2C_P2P_PS_OFFLOAD
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:06 -07:00