Commit Graph

440969 Commits

Author SHA1 Message Date
Mark Hounschell
20fe4ae19d staging: dgap: fix/change a pr_info
This patch just fixes a pr_info. brd->state is not proper
at this point in time.

Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:49:12 -07:00
Mark Hounschell
70dc23361d staging: dgap: remove volatiles from dgap.h
This patch fixes checkpatch warnings about using volatiles in dgap.h

Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:49:11 -07:00
Mark Hounschell
77c9976fa6 staging: dgap: Macros with complex values should be enclosed in parenthesis
This patch fixes a checkpatch warning
"Macros with complex values should be enclosed in parenthesis"

Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:49:11 -07:00
Mark Hounschell
9e84401638 staging: dgap: Only read config file dgap.conf once
The config file is currently read for each board found.
It only needs to be read one time. The buffer it is read
into can now be freed immediately after it is parsed
instead of at driver unload time.

Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:49:10 -07:00
Mark Hounschell
559edcb73a staging: dgap: Removes excessive empty lines from dgap.h
This patch removes excessive empty lines from dgap.h
not previously caught.

Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:49:10 -07:00
Mark Hounschell
cb873994a7 staging: dgap: remove some unused code in dgap.h
This patch removes some unused code in dgap.h

Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:45:50 -07:00
Mark Hounschell
d68dcfc180 staging: dgap: Fix several 80+ line warnings in dgap.h
This patch fixes several 80+ char line warnings as reported
by checkpatch in dgap.h

Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:45:49 -07:00
Mark Hounschell
084eb9d75b staging: dgap: fix some whitespace warnings in dgap.h
This patch fixes some whitespace warnings as reported
by checkpatch in dgap.h.

Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:45:49 -07:00
Mark Hounschell
35ed972362 staging: dgap: Remove some unneeded comments
This patch removes some unneeded comments from dgap.c

Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:45:49 -07:00
Mark Hounschell
2c44ef7526 staging: dgap: Remove some unused code in dgap.c
This patch removes some unused code in dgap.c.

Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:45:48 -07:00
Mark Einon
bd2715f6e7 staging: rtl8821ae: Fix rtl8821ae/hw.h pointer declaration style
Fix all occurences of the checkpatch error:

ERROR: "foo* bar" should be "foo *bar"

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:30 -07:00
Mark Einon
f6d49cb0ff staging: rtl8821ae: Remove FSF mailing address from rtl8821ae/hw.h header
Fix checkpatch check:

CHECK: Do not include the paragraph about writing to the Free Software
Foundation's mailing address from the sample GPL notice. The FSF has
changed addresses in the past, and may do so again. Linux already
includes a copy of the GPL.

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:30 -07:00
Mark Einon
dab3775c6c staging: rtl8821ae: Fix whitespace in rtl8821ae/hw.h
Fix checkpatch warnings, lines over 80 chars using tabs where possible.

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:30 -07:00
Michael Welling
7fe704ce6a Staging: iio: Switch from msleep to usleep range per timers-howto.txt
Signed-off-by: Michael Welling <mwelling@ieee.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:29 -07:00
Michael Welling
b47b894c60 Staging: iio: Remove quoted string split across lines warnings
Signed-off-by: Michael Welling <mwelling@ieee.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:29 -07:00
Michael Welling
8f2150dd8e Staging: iio: Removes unwanted space before semicolon
Signed-off-by: Michael Welling <mwelling@ieee.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:29 -07:00
Joel Porquet
9f9e1e0ff3 staging: iio: fix coding style
As suggested by checkpatch.pl, use dev_info() instead of
printk(KERN_INFO ...) to print message.

Signed-off-by: Joel Porquet <joel@porquet.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:28 -07:00
Luis Ortega
2315e49e78 Staging: bcm: Qos: fixed braces' coding style
Fixed badly placed and unnecessary braces.

PS: Performed as task 10 of the Eudyptula Challenge.

Signed-off-by: Luis Ortega <luiorpe1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:28 -07:00
Jake Edge
32f21cee85 staging/bcm fix hostmibs.c checkpatch problems
Fix 4 checkpatch errors, many warnings in bcm/hostmibs.c

Signed-off-by: Jake Edge <jake@edge2.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:28 -07:00
Gary Rookard
a47a0f5064 Staging: bcm: CmHost: remove temp bracing from switch/cases.
Remove the temp bracing afixed to case labels.

Properly indent switch/case breaks.

Signed-off-by: Gary Alan Rookard <garyrookard@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:27 -07:00
Michele Curti
bee2d6a82c staging: comedi: declare das6402_boards as static
das6402_boards array is used in das6402.c only, so declare it as static.

Signed-off-by: Michele Curti <michele.curti@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:27 -07:00
Richard Leitner
110775bd5d staging: comedi: adl_pci9118: fix whitespace issues
Removed not needed spaces and fixed too long lines

Signed-off-by: Richard Leitner <me@g0hl1n.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:26 -07:00
Georg Gast
b5ebcaa8d3 staging: comedi: more descriptive names for addi-data drivers
- more descriptive module description for following boards:
  ADDI-DATA APCI 1032/1500/1564/2032/3120

Signed-off-by: Georg Gast <georg@schorsch-tech.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:26 -07:00
Kumar Amit Mehta
6425b1c2d2 staging: comedi: drivers: pcl812.c: add curly braces for checkpatch
Kernel style is that if one side of the if else statement gets has curly
braces then both side should have them.

Signed-off-by: Kumar Amit Mehta <gmate.amit@gmail.com>
Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:26 -07:00
Chase Southwood
571845c6f4 staging: comedi: s626: use comedi_timeout() on remaining loops
There were just a handful of more while loops in this file that needed
timeouts, and this patch takes care of them.  One new callback is
introduced, and all of the proper comedi_timeout() calls are then used.
The return type of s626_i2c_handshake() has been changed from uint32_t to
int so that a negative error code from comedi_timeout() can be propagated
if necessary.

Signed-off-by: Chase Southwood <chase.southwood@yahoo.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:25 -07:00
Yves Deweerdt
1e4742df19 staging: comedi: drivers.c: Fix missing a blank line, after declarations warning
Signed-off-by: Yves Deweerdt <yves.deweerdt.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:25 -07:00
Yves Deweerdt
b2f4874174 staging: comedi: comedy_fops.c: fix line over 80, characters warnings
Signed-off-by: Yves Deweerdt <yves.deweerdt.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:25 -07:00
Dan Carpenter
f619621f40 staging: comedi: remove an unneeded variable
"chanlist" was left over, we don't need it any more.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:24 -07:00
Jes Sorensen
94b080bc70 staging: rtl8723au: Simplify retrieving the ether_type in portctrl()
This renders the last element in include/ethernet.h unnecessary, so
remove it as well.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:24 -07:00
Jes Sorensen
7d0d2b15a0 staging: rtl8723au: Calling rtw_get_stainfo() with a NULL sta_addr will return NULL
This makes the follow-on check for psta != NULL pointless and makes
the whole exercise rather pointless. This is another case of why
blindly zero-initializing variables when they are declared is bad.

This bug seems to be present in multiple drivers provided by Realtek.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:23 -07:00
Jes Sorensen
514c485c01 staging: rtl8723au: Fix case where ethtype was never obtained and always be checked against 0
Zero-initializing ether_type masked that the ether type would never be
obtained for 8021x packets and the comparition against eapol_type
would always fail.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:23 -07:00
Jes Sorensen
7dd1e72025 staging: rtl8723au: Use proper ETH_P_* types in rtw_recv.c
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:23 -07:00
Jes Sorensen
f4337aa31d staging: rtl8723au: Call do_div() directly and get rid of unnecessary wrapper functions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:22 -07:00
Larry Finger
88cdc943c5 staging: rtl8723au: Fix build error due to bad commit 6c89f82
Two routines are missing includes of a necessary header.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:22 -07:00
Jes Sorensen
6484767b93 staging: rtl8723au: Remove unused bitshift() function
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:21 -07:00
Jes Sorensen
9cd81fa609 staging: rtl8723au: Remove a couple of unused prototypes
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:21 -07:00
Jes Sorensen
8000d1c413 staging: rtl8723au: No need to include header files for unused circ_buf and old iwpriv bits
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:21 -07:00
Jes Sorensen
458dc03913 staging: rtl8723au: Remove unnecessary forward struct declarations from xmit_osdep.h
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:20 -07:00
Jes Sorensen
4c9c5700d6 staging: rtl8723au: Remove ugly pktfile interface
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:20 -07:00
Jes Sorensen
3e689a9ff5 staging: rtl8723au: Don't use pktfile interface in rtw_xmitframe_coalesce23a()
The pktfil interface is horrible, no idea where it came from, but not
using it is a win.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:19 -07:00
Jes Sorensen
69a0f9745c staging: rtl8723au: Make rtw_xmitframe_coalesce23a() more readable
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:19 -07:00
Jes Sorensen
e59cb424d7 staging: rtl8723au: Fix update_attrib() and set_qos() to not use pktfile nonsense
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:19 -07:00
Jes Sorensen
3483b8ae77 staging: rtl8723au: Use proper ETH_P_* types instead of hard coded constants in rtw_xmit.c
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:18 -07:00
Jes Sorensen
f4f1cb92ae staging: rtl8723au: Fold rtw_remainder_len23a() into _rtw_open_pktfile23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:18 -07:00
Jes Sorensen
41ed2cb92e staging: rtl8723au: Remove last remnants of CONFIG_BR_EXT
Reported-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:18 -07:00
Jes Sorensen
814a1d900e staging: rtl8723au: rtw_report_sec_ie23a() is only called from rtw_mlme.c
Move it there and declare it static

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:17 -07:00
Jes Sorensen
1eb663227f staging: rtl8723au: Remove unused functions rtw_indicate_sta_{dis,}assoc_event23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:17 -07:00
Jes Sorensen
90102edc28 staging: rtl8723au: Fix hopeless brackets for declaring a variable mid-function
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:16 -07:00
Jes Sorensen
b319c6a35d staging: rtl8723au: Remove unnecessary memset() followed by a memcpy() into the same space
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:16 -07:00
Jes Sorensen
483557be8e staging: rtl8723au: rtw_os_indicate_connect23a() is only called from one place - fold it in
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-14 08:29:16 -07:00