AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2024-12-18 19:47:49 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

staging: unisys: cleanup rc -1 in create_visor_device()

Browse Source 
Get rid of the rc = -1 initialization. Return a meaningful error on
failure in the function, or, the rc from a called function if it fails.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Benjamin Romer 2016-02-23 12:44:16 -05:00 committed by Greg Kroah-Hartman
parent f748f64f06
commit f99d3308c5
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/staging/unisys/visorbus/visorbus_main.c
View File

@ -973,7 +973,7 @@ EXPORT_SYMBOL_GPL(visorbus_disable_channel_interrupts);
static int static int
create_visor_device(struct visor_device *dev) create_visor_device(struct visor_device *dev)
{ {
int rc = -1; int rc;
u32 chipset_bus_no = dev->chipset_bus_no; u32 chipset_bus_no = dev->chipset_bus_no;
u32 chipset_dev_no = dev->chipset_dev_no; u32 chipset_dev_no = dev->chipset_dev_no;
@ -995,6 +995,7 @@ create_visor_device(struct visor_device *dev)
if (!dev->periodic_work) { if (!dev->periodic_work) {
POSTCODE_LINUX_3(DEVICE_CREATE_FAILURE_PC, chipset_dev_no, POSTCODE_LINUX_3(DEVICE_CREATE_FAILURE_PC, chipset_dev_no,
DIAG_SEVERITY_ERR); DIAG_SEVERITY_ERR);
rc = -EINVAL;
goto away; goto away;
} }
@ -1032,14 +1033,15 @@ create_visor_device(struct visor_device *dev)
if (rc < 0) { if (rc < 0) {
POSTCODE_LINUX_3(DEVICE_REGISTER_FAILURE_PC, chipset_dev_no, POSTCODE_LINUX_3(DEVICE_REGISTER_FAILURE_PC, chipset_dev_no,
DIAG_SEVERITY_ERR); DIAG_SEVERITY_ERR);
goto away_register; goto away_unregister;
} }
list_add_tail(&dev->list_all, &list_all_device_instances); list_add_tail(&dev->list_all, &list_all_device_instances);
return 0; return 0;
away_register: away_unregister:
device_unregister(&dev->device); device_unregister(&dev->device);
away: away:
put_device(&dev->device); put_device(&dev->device);
return rc; return rc;