AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2025-04-14 04:27:33 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

s390/kprobes: fix instruction copy for out of line execution

Browse Source 
When we generate the instruction for out of line execution the length
of the to be copied instruction was evaluated from a not initialized
memory location.
Therefore we ended up with a random (2, 4 or 6) number of bytes being
copied instead of taking the real instruction length into account.
This works surprisingly well most of the time, but still not always.

Reported-by: Ursula Braun <ursula.braun@de.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
This commit is contained in:
Heiko Carstens 2014-11-28 12:36:48 +01:00 committed by Martin Schwidefsky
parent 57f2ffe14f
commit ed7d56e174
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
arch/s390/kernel/kprobes.c
View File

@ -74,7 +74,7 @@ static void copy_instruction(struct kprobe *p)
ftrace_generate_nop_insn((struct ftrace_insn *)p->ainsn.insn); ftrace_generate_nop_insn((struct ftrace_insn *)p->ainsn.insn);
p->ainsn.is_ftrace_insn = 1; p->ainsn.is_ftrace_insn = 1;
} else } else
memcpy(p->ainsn.insn, p->addr, insn_length(p->opcode >> 8)); memcpy(p->ainsn.insn, p->addr, insn_length(*p->addr >> 8));
p->opcode = p->ainsn.insn[0]; p->opcode = p->ainsn.insn[0];
if (!probe_is_insn_relative_long(p->ainsn.insn)) if (!probe_is_insn_relative_long(p->ainsn.insn))
return; return;