AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2024-12-19 18:58:48 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

infiniband: hfi1: no need to check return value of debugfs_create functions

Browse Source 
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
This commit is contained in:
Greg Kroah-Hartman 2019-01-22 16:17:55 +01:00 committed by Jason Gunthorpe
parent 5c43276499
commit e775118025
2 changed files with 18 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/infiniband/hw/hfi1/debugfs.c
View File

@ -1339,8 +1339,6 @@ DEBUGFS_FILE_OPS(driver_stats);
void hfi1_dbg_init(void) void hfi1_dbg_init(void)
{ {
hfi1_dbg_root = debugfs_create_dir(DRIVER_NAME, NULL); hfi1_dbg_root = debugfs_create_dir(DRIVER_NAME, NULL);
if (!hfi1_dbg_root)
pr_warn("init of debugfs failed\n");
debugfs_create_file("driver_stats_names", 0444, hfi1_dbg_root, NULL, debugfs_create_file("driver_stats_names", 0444, hfi1_dbg_root, NULL,
&_driver_stats_names_file_ops); &_driver_stats_names_file_ops);
debugfs_create_file("driver_stats", 0444, hfi1_dbg_root, NULL, debugfs_create_file("driver_stats", 0444, hfi1_dbg_root, NULL,

50
drivers/infiniband/hw/hfi1/fault.c
View File

@ -250,6 +250,7 @@ void hfi1_fault_exit_debugfs(struct hfi1_ibdev *ibd)
int hfi1_fault_init_debugfs(struct hfi1_ibdev *ibd) int hfi1_fault_init_debugfs(struct hfi1_ibdev *ibd)
{ {
struct dentry *parent = ibd->hfi1_ibdev_dbg; struct dentry *parent = ibd->hfi1_ibdev_dbg;
struct dentry *fault_dir;
ibd->fault = kzalloc(sizeof(*ibd->fault), GFP_KERNEL); ibd->fault = kzalloc(sizeof(*ibd->fault), GFP_KERNEL);
if (!ibd->fault) if (!ibd->fault)
@ -269,46 +270,31 @@ int hfi1_fault_init_debugfs(struct hfi1_ibdev *ibd)
bitmap_zero(ibd->fault->opcodes, bitmap_zero(ibd->fault->opcodes,
sizeof(ibd->fault->opcodes) * BITS_PER_BYTE); sizeof(ibd->fault->opcodes) * BITS_PER_BYTE);
ibd->fault->dir = fault_dir =
fault_create_debugfs_attr("fault", parent, fault_create_debugfs_attr("fault", parent, &ibd->fault->attr);
&ibd->fault->attr); if (IS_ERR(fault_dir)) {
if (IS_ERR(ibd->fault->dir)) {
kfree(ibd->fault); kfree(ibd->fault);
ibd->fault = NULL; ibd->fault = NULL;
return -ENOENT; return -ENOENT;
} }
ibd->fault->dir = fault_dir;
debugfs_create_file("fault_stats", 0444, ibd->fault->dir, ibd, debugfs_create_file("fault_stats", 0444, fault_dir, ibd,
&_fault_stats_file_ops); &_fault_stats_file_ops);
if (!debugfs_create_bool("enable", 0600, ibd->fault->dir, debugfs_create_bool("enable", 0600, fault_dir, &ibd->fault->enable);
&ibd->fault->enable)) debugfs_create_bool("suppress_err", 0600, fault_dir,
goto fail; &ibd->fault->suppress_err);
if (!debugfs_create_bool("suppress_err", 0600, debugfs_create_bool("opcode_mode", 0600, fault_dir,
ibd->fault->dir, &ibd->fault->opcode);
&ibd->fault->suppress_err)) debugfs_create_file("opcodes", 0600, fault_dir, ibd->fault,
goto fail; &__fault_opcodes_fops);
if (!debugfs_create_bool("opcode_mode", 0600, ibd->fault->dir, debugfs_create_u64("skip_pkts", 0600, fault_dir,
&ibd->fault->opcode)) &ibd->fault->fault_skip);
goto fail; debugfs_create_u64("skip_usec", 0600, fault_dir,
if (!debugfs_create_file("opcodes", 0600, ibd->fault->dir, &ibd->fault->fault_skip_usec);
ibd->fault, &__fault_opcodes_fops)) debugfs_create_u8("direction", 0600, fault_dir, &ibd->fault->direction);
goto fail;
if (!debugfs_create_u64("skip_pkts", 0600,
ibd->fault->dir,
&ibd->fault->fault_skip))
goto fail;
if (!debugfs_create_u64("skip_usec", 0600,
ibd->fault->dir,
&ibd->fault->fault_skip_usec))
goto fail;
if (!debugfs_create_u8("direction", 0600, ibd->fault->dir,
&ibd->fault->direction))
goto fail;
return 0; return 0;
fail:
hfi1_fault_exit_debugfs(ibd);
return -ENOMEM;
} }
bool hfi1_dbg_fault_suppress_err(struct hfi1_ibdev *ibd) bool hfi1_dbg_fault_suppress_err(struct hfi1_ibdev *ibd)