rcu: code cleanups in TINY_RCU priority boosting.

Extraneous semicolon, bad comment, and fold INIT_LIST_HEAD() into
list_del() to get list_del_init().

Signed-off-by: Paul E. McKenney <paul.mckenney@linaro.org>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
This commit is contained in:
Paul E. McKenney 2011-02-23 17:03:06 -08:00 committed by Paul E. McKenney
parent f0a07aeaf8
commit ddeb75814f

View File

@ -339,7 +339,7 @@ static void rcu_initiate_expedited_boost(void)
raw_local_irq_restore(flags); raw_local_irq_restore(flags);
} }
#define RCU_BOOST_DELAY_JIFFIES DIV_ROUND_UP(CONFIG_RCU_BOOST_DELAY * HZ, 1000); #define RCU_BOOST_DELAY_JIFFIES DIV_ROUND_UP(CONFIG_RCU_BOOST_DELAY * HZ, 1000)
/* /*
* Do priority-boost accounting for the start of a new grace period. * Do priority-boost accounting for the start of a new grace period.
@ -418,7 +418,7 @@ static void rcu_preempt_cpu_qs(void)
if (!rcu_preempt_gp_in_progress()) if (!rcu_preempt_gp_in_progress())
return; return;
/* /*
* Check up on boosting. If there are no readers blocking the * Check up on boosting. If there are readers blocking the
* current grace period, leave. * current grace period, leave.
*/ */
if (rcu_initiate_boost()) if (rcu_initiate_boost())
@ -578,7 +578,7 @@ static void rcu_read_unlock_special(struct task_struct *t)
empty = !rcu_preempt_blocked_readers_cgp(); empty = !rcu_preempt_blocked_readers_cgp();
empty_exp = rcu_preempt_ctrlblk.exp_tasks == NULL; empty_exp = rcu_preempt_ctrlblk.exp_tasks == NULL;
np = rcu_next_node_entry(t); np = rcu_next_node_entry(t);
list_del(&t->rcu_node_entry); list_del_init(&t->rcu_node_entry);
if (&t->rcu_node_entry == rcu_preempt_ctrlblk.gp_tasks) if (&t->rcu_node_entry == rcu_preempt_ctrlblk.gp_tasks)
rcu_preempt_ctrlblk.gp_tasks = np; rcu_preempt_ctrlblk.gp_tasks = np;
if (&t->rcu_node_entry == rcu_preempt_ctrlblk.exp_tasks) if (&t->rcu_node_entry == rcu_preempt_ctrlblk.exp_tasks)
@ -587,7 +587,6 @@ static void rcu_read_unlock_special(struct task_struct *t)
if (&t->rcu_node_entry == rcu_preempt_ctrlblk.boost_tasks) if (&t->rcu_node_entry == rcu_preempt_ctrlblk.boost_tasks)
rcu_preempt_ctrlblk.boost_tasks = np; rcu_preempt_ctrlblk.boost_tasks = np;
#endif /* #ifdef CONFIG_RCU_BOOST */ #endif /* #ifdef CONFIG_RCU_BOOST */
INIT_LIST_HEAD(&t->rcu_node_entry);
/* /*
* If this was the last task on the current list, and if * If this was the last task on the current list, and if