AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2024-12-14 04:46:46 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

scsi: lpfc: fix missing spin_unlock on sql_list_lock

Browse Source 
From: Colin Ian King <colin.king@canonical.com>

In the case where sglq is null, the current code just returns without
unlocking the spinlock sql_list_lock. Fix this by breaking out of the
while loop and the exit path will then unlock and return NULL as was
the original intention.

Detected by CoverityScan, CID#1411635 ("Missing unlock")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
James Smart 2017-03-04 09:30:24 -08:00 committed by Martin K. Petersen
parent 332ba3b5d6
commit d11f54b7d1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/scsi/lpfc/lpfc_sli.c
View File

@ -952,7 +952,7 @@ __lpfc_sli_get_els_sglq(struct lpfc_hba *phba, struct lpfc_iocbq *piocbq)
start_sglq = sglq; start_sglq = sglq;
while (!found) { while (!found) {
if (!sglq) if (!sglq)
return NULL; break;
if (ndlp && ndlp->active_rrqs_xri_bitmap && if (ndlp && ndlp->active_rrqs_xri_bitmap &&
test_bit(sglq->sli4_lxritag, test_bit(sglq->sli4_lxritag,
ndlp->active_rrqs_xri_bitmap)) { ndlp->active_rrqs_xri_bitmap)) {