AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2024-11-25 18:10:50 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

iio: adc: xadc: Fix coding style violations

Browse Source 
This patch fix following checkpatch warnings in xadc driver
1. prefer 'unsigned int' to bare use of 'unsigned'.
2. else is not generally useful after a break or return.
3. fill all function definition arguments with identifier name

Signed-off-by: Sai Krishna Potthuri <lakshmis@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Sai Krishna Potthuri 2017-08-10 08:30:20 +02:00 committed by Jonathan Cameron
parent b24d10976e
commit ce0d376140
2 changed files with 23 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/iio/adc/xilinx-xadc-events.c
View File

@ -68,7 +68,7 @@ void xadc_handle_events(struct iio_dev *indio_dev, unsigned long events)
xadc_handle_event(indio_dev, i); xadc_handle_event(indio_dev, i);
} }
static unsigned xadc_get_threshold_offset(const struct iio_chan_spec *chan, static unsigned int xadc_get_threshold_offset(const struct iio_chan_spec *chan,
enum iio_event_direction dir) enum iio_event_direction dir)
{ {
unsigned int offset; unsigned int offset;
@ -90,9 +90,8 @@ static unsigned xadc_get_threshold_offset(const struct iio_chan_spec *chan,
static unsigned int xadc_get_alarm_mask(const struct iio_chan_spec *chan) static unsigned int xadc_get_alarm_mask(const struct iio_chan_spec *chan)
{ {
if (chan->type == IIO_TEMP) { if (chan->type == IIO_TEMP)
return XADC_ALARM_OT_MASK; return XADC_ALARM_OT_MASK;
} else {
switch (chan->channel) { switch (chan->channel) {
case 0: case 0:
return XADC_ALARM_VCCINT_MASK; return XADC_ALARM_VCCINT_MASK;
@ -111,7 +110,6 @@ static unsigned int xadc_get_alarm_mask(const struct iio_chan_spec *chan)
return 0; return 0;
} }
} }
}
int xadc_read_event_config(struct iio_dev *indio_dev, int xadc_read_event_config(struct iio_dev *indio_dev,
const struct iio_chan_spec *chan, enum iio_event_type type, const struct iio_chan_spec *chan, enum iio_event_type type,

10
drivers/iio/adc/xilinx-xadc.h
View File

@ -71,13 +71,13 @@ struct xadc {
}; };
struct xadc_ops { struct xadc_ops {
int (*read)(struct xadc *, unsigned int, uint16_t *); int (*read)(struct xadc *xadc, unsigned int reg, uint16_t *val);
int (*write)(struct xadc *, unsigned int, uint16_t); int (*write)(struct xadc *xadc, unsigned int reg, uint16_t val);
int (*setup)(struct platform_device *pdev, struct iio_dev *indio_dev, int (*setup)(struct platform_device *pdev, struct iio_dev *indio_dev,
int irq); int irq);
void (*update_alarm)(struct xadc *, unsigned int); void (*update_alarm)(struct xadc *xadc, unsigned int alarm);
unsigned long (*get_dclk_rate)(struct xadc *); unsigned long (*get_dclk_rate)(struct xadc *xadc);
irqreturn_t (*interrupt_handler)(int, void *); irqreturn_t (*interrupt_handler)(int irq, void *devid);
unsigned int flags; unsigned int flags;
}; };