mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-11 22:56:40 +07:00
V4L/DVB (8790): saa7115: call i2c_set_clientdata only when state != NULL
Not a bug as such, but it looks really strange doing this before checking whether the state structure could be allocated. Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
parent
dc60de338f
commit
c5bf204f42
@ -1489,10 +1489,9 @@ static int saa7115_probe(struct i2c_client *client,
|
||||
client->addr << 1, client->adapter->name);
|
||||
|
||||
state = kzalloc(sizeof(struct saa711x_state), GFP_KERNEL);
|
||||
i2c_set_clientdata(client, state);
|
||||
if (state == NULL) {
|
||||
if (state == NULL)
|
||||
return -ENOMEM;
|
||||
}
|
||||
i2c_set_clientdata(client, state);
|
||||
state->input = -1;
|
||||
state->output = SAA7115_IPORT_ON;
|
||||
state->enable = 1;
|
||||
|
Loading…
Reference in New Issue
Block a user