mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-28 00:56:33 +07:00
rtw88: 8723d: fix incorrect setting of ldo_pwr
Currently ldo_pwr has the LDO25 voltage bits set to zero and then
it is overwritten with the new voltage setting. The assignment
looks incorrect, it should be bit-wise or'ing in the new voltage
setting rather than a direct assignment.
Addresses-Coverity: ("Unused value")
Fixes: 1afb5eb7a0
("rtw88: 8723d: Add cfg_ldo25 to control LDO25")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200514181329.16292-1-colin.king@canonical.com
This commit is contained in:
parent
6b684282af
commit
c5457559b6
@ -562,7 +562,7 @@ static void rtw8723d_cfg_ldo25(struct rtw_dev *rtwdev, bool enable)
|
||||
ldo_pwr = rtw_read8(rtwdev, REG_LDO_EFUSE_CTRL + 3);
|
||||
if (enable) {
|
||||
ldo_pwr &= ~BIT_MASK_LDO25_VOLTAGE;
|
||||
ldo_pwr = (BIT_LDO25_VOLTAGE_V25 << 4) | BIT_LDO25_EN;
|
||||
ldo_pwr |= (BIT_LDO25_VOLTAGE_V25 << 4) | BIT_LDO25_EN;
|
||||
} else {
|
||||
ldo_pwr &= ~BIT_LDO25_EN;
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user