mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-11-27 00:20:58 +07:00
HID: prodikeys: make sysfs permissions more strict
It's not really dangerous in this driver, but it's against general practice and worth fixing. Proper place for handling this correctly is udev. Reported-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
parent
e9229faf92
commit
c311598b29
@ -130,7 +130,7 @@ static ssize_t store_channel(struct device *dev,
|
|||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
}
|
}
|
||||||
|
|
||||||
static DEVICE_ATTR(channel, S_IRUGO | S_IWUGO, show_channel,
|
static DEVICE_ATTR(channel, S_IRUGO | S_IWUSR | S_IWGRP , show_channel,
|
||||||
store_channel);
|
store_channel);
|
||||||
|
|
||||||
static struct device_attribute *sysfs_device_attr_channel = {
|
static struct device_attribute *sysfs_device_attr_channel = {
|
||||||
@ -169,7 +169,7 @@ static ssize_t store_sustain(struct device *dev,
|
|||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
}
|
}
|
||||||
|
|
||||||
static DEVICE_ATTR(sustain, S_IRUGO | S_IWUGO, show_sustain,
|
static DEVICE_ATTR(sustain, S_IRUGO | S_IWUSR | S_IWGRP, show_sustain,
|
||||||
store_sustain);
|
store_sustain);
|
||||||
|
|
||||||
static struct device_attribute *sysfs_device_attr_sustain = {
|
static struct device_attribute *sysfs_device_attr_sustain = {
|
||||||
@ -207,7 +207,7 @@ static ssize_t store_octave(struct device *dev,
|
|||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
}
|
}
|
||||||
|
|
||||||
static DEVICE_ATTR(octave, S_IRUGO | S_IWUGO, show_octave,
|
static DEVICE_ATTR(octave, S_IRUGO | S_IWUSR | S_IWGRP, show_octave,
|
||||||
store_octave);
|
store_octave);
|
||||||
|
|
||||||
static struct device_attribute *sysfs_device_attr_octave = {
|
static struct device_attribute *sysfs_device_attr_octave = {
|
||||||
|
Loading…
Reference in New Issue
Block a user