mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-14 23:46:53 +07:00
mce, amd: Add helper functions to setup APIC
This patch reworks and cleans up mce_amd_feature_init() by introducing helper functions to setup and check the LVT offset. It also fixes line endings in pr_err() calls. Signed-off-by: Robert Richter <robert.richter@amd.com> Acked-by: Borislav Petkov <borislav.petkov@amd.com> LKML-Reference: <1288015419-29543-4-git-send-email-robert.richter@amd.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
parent
7203a04940
commit
bbaff08dca
@ -31,8 +31,6 @@
|
||||
#include <asm/mce.h>
|
||||
#include <asm/msr.h>
|
||||
|
||||
#define PFX "mce_threshold: "
|
||||
#define VERSION "version 1.1.1"
|
||||
#define NR_BANKS 6
|
||||
#define NR_BLOCKS 9
|
||||
#define THRESHOLD_MAX 0xFFF
|
||||
@ -88,6 +86,27 @@ struct thresh_restart {
|
||||
u16 old_limit;
|
||||
};
|
||||
|
||||
static int lvt_off_valid(struct threshold_block *b, int apic, u32 lo, u32 hi)
|
||||
{
|
||||
int msr = (hi & MASK_LVTOFF_HI) >> 20;
|
||||
|
||||
if (apic < 0) {
|
||||
pr_err(FW_BUG "cpu %d, failed to setup threshold interrupt "
|
||||
"for bank %d, block %d (MSR%08X=0x%x%08x)\n", b->cpu,
|
||||
b->bank, b->block, b->address, hi, lo);
|
||||
return 0;
|
||||
}
|
||||
|
||||
if (apic != msr) {
|
||||
pr_err(FW_BUG "cpu %d, invalid threshold interrupt offset %d "
|
||||
"for bank %d, block %d (MSR%08X=0x%x%08x)\n",
|
||||
b->cpu, apic, b->bank, b->block, b->address, hi, lo);
|
||||
return 0;
|
||||
}
|
||||
|
||||
return 1;
|
||||
};
|
||||
|
||||
/* must be called with correct cpu affinity */
|
||||
/* Called via smp_call_function_single() */
|
||||
static void threshold_restart_bank(void *_tr)
|
||||
@ -113,9 +132,11 @@ static void threshold_restart_bank(void *_tr)
|
||||
}
|
||||
|
||||
if (tr->set_lvt_off) {
|
||||
/* set new lvt offset */
|
||||
hi &= ~MASK_LVTOFF_HI;
|
||||
hi |= tr->lvt_off << 20;
|
||||
if (lvt_off_valid(tr->b, tr->lvt_off, lo, hi)) {
|
||||
/* set new lvt offset */
|
||||
hi &= ~MASK_LVTOFF_HI;
|
||||
hi |= tr->lvt_off << 20;
|
||||
}
|
||||
}
|
||||
|
||||
tr->b->interrupt_enable ?
|
||||
@ -138,6 +159,15 @@ static void mce_threshold_block_init(struct threshold_block *b, int offset)
|
||||
threshold_restart_bank(&tr);
|
||||
};
|
||||
|
||||
static int setup_APIC_mce(int reserved, int new)
|
||||
{
|
||||
if (reserved < 0 && !setup_APIC_eilvt(new, THRESHOLD_APIC_VECTOR,
|
||||
APIC_EILVT_MSG_FIX, 0))
|
||||
return new;
|
||||
|
||||
return reserved;
|
||||
}
|
||||
|
||||
/* cpu init entry point, called from mce.c with preempt off */
|
||||
void mce_amd_feature_init(struct cpuinfo_x86 *c)
|
||||
{
|
||||
@ -145,8 +175,7 @@ void mce_amd_feature_init(struct cpuinfo_x86 *c)
|
||||
unsigned int cpu = smp_processor_id();
|
||||
u32 low = 0, high = 0, address = 0;
|
||||
unsigned int bank, block;
|
||||
int lvt_off = -1;
|
||||
u8 offset;
|
||||
int offset = -1;
|
||||
|
||||
for (bank = 0; bank < NR_BANKS; ++bank) {
|
||||
for (block = 0; block < NR_BLOCKS; ++block) {
|
||||
@ -177,28 +206,8 @@ void mce_amd_feature_init(struct cpuinfo_x86 *c)
|
||||
if (shared_bank[bank] && c->cpu_core_id)
|
||||
break;
|
||||
#endif
|
||||
offset = (high & MASK_LVTOFF_HI) >> 20;
|
||||
if (lvt_off < 0) {
|
||||
if (setup_APIC_eilvt(offset,
|
||||
THRESHOLD_APIC_VECTOR,
|
||||
APIC_EILVT_MSG_FIX, 0)) {
|
||||
pr_err(FW_BUG "cpu %d, failed to "
|
||||
"setup threshold interrupt "
|
||||
"for bank %d, block %d "
|
||||
"(MSR%08X=0x%x%08x)",
|
||||
smp_processor_id(), bank, block,
|
||||
address, high, low);
|
||||
continue;
|
||||
}
|
||||
lvt_off = offset;
|
||||
} else if (lvt_off != offset) {
|
||||
pr_err(FW_BUG "cpu %d, invalid threshold "
|
||||
"interrupt offset %d for bank %d,"
|
||||
"block %d (MSR%08X=0x%x%08x)",
|
||||
smp_processor_id(), lvt_off, bank,
|
||||
block, address, high, low);
|
||||
continue;
|
||||
}
|
||||
offset = setup_APIC_mce(offset,
|
||||
(high & MASK_LVTOFF_HI) >> 20);
|
||||
|
||||
memset(&b, 0, sizeof(b));
|
||||
b.cpu = cpu;
|
||||
|
Loading…
Reference in New Issue
Block a user