AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2024-11-27 01:40:56 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

iscsi-target: Fix memory corruption in iscsit_logout_post_handler_diffcid

Browse Source 
This patch fixes a bug in iscsit_logout_post_handler_diffcid() where
a pointer used as storage for list_for_each_entry() was incorrectly
being used to determine if no matching entry had been found.

This patch changes iscsit_logout_post_handler_diffcid() to key off
bool conn_found to determine if the function needs to exit early.

Reported-by: Joern Engel <joern@logfs.org>
Cc: <stable@vger.kernel.org> # v3.1+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
This commit is contained in:
Nicholas Bellinger 2014-09-17 11:45:17 -07:00
parent 1f0b030c45
commit b53b0d99d6
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/target/iscsi/iscsi_target.c
View File

@ -4540,6 +4540,7 @@ static void iscsit_logout_post_handler_diffcid(
{ {
struct iscsi_conn *l_conn; struct iscsi_conn *l_conn;
struct iscsi_session *sess = conn->sess; struct iscsi_session *sess = conn->sess;
bool conn_found = false;
if (!sess) if (!sess)
return; return;
@ -4548,12 +4549,13 @@ static void iscsit_logout_post_handler_diffcid(
list_for_each_entry(l_conn, &sess->sess_conn_list, conn_list) { list_for_each_entry(l_conn, &sess->sess_conn_list, conn_list) {
if (l_conn->cid == cid) { if (l_conn->cid == cid) {
iscsit_inc_conn_usage_count(l_conn); iscsit_inc_conn_usage_count(l_conn);
conn_found = true;
break; break;
} }
} }
spin_unlock_bh(&sess->conn_lock); spin_unlock_bh(&sess->conn_lock);
if (!l_conn) if (!conn_found)
return; return;
if (l_conn->sock) if (l_conn->sock)