AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2024-11-24 19:20:50 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

hpsa: performance tweak for hpsa_scatter_gather()

Browse Source 
Divide the loop in hpsa_scatter_gather() into two, one for the initial SG list
and a second one for the chained list, if any.  This allows the conditional
check which resets the indicies for the chained list to be performed outside
the loop instead of being done on every iteration inside the loop.

Reviewed-by: Scott Teel <scott.teel@pmcs.com>
Reviewed-by: Kevin Barnett <kevin.barnett@pmcs.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Reviewed-by: Hannes Reinecke <hare@Suse.de>
Signed-off-by: Webb Scales <webbnh@hp.com>
Signed-off-by: Don Brace <don.brace@pmcs.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: James Bottomley <JBottomley@Odin.com>
This commit is contained in:
Webb Scales 2015-04-23 09:34:27 -05:00 committed by James Bottomley
parent b69324ff93
commit b3a7ba7c94
1 changed files with 28 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
drivers/scsi/hpsa.c
View File

@ -3674,7 +3674,7 @@ static int hpsa_scatter_gather(struct ctlr_info *h,
struct scsi_cmnd *cmd) struct scsi_cmnd *cmd)
{ {
struct scatterlist *sg; struct scatterlist *sg;
int use_sg, i, sg_index, chained; int use_sg, i, sg_limit, chained, last_sg;
struct SGDescriptor *curr_sg; struct SGDescriptor *curr_sg;
BUG_ON(scsi_sg_count(cmd) > h->maxsgentries); BUG_ON(scsi_sg_count(cmd) > h->maxsgentries);
@ -3686,22 +3686,39 @@ static int hpsa_scatter_gather(struct ctlr_info *h,
if (!use_sg) if (!use_sg)
goto sglist_finished; goto sglist_finished;
/*
* If the number of entries is greater than the max for a single list,
* then we have a chained list; we will set up all but one entry in the
* first list (the last entry is saved for link information);
* otherwise, we don't have a chained list and we'll set up at each of
* the entries in the one list.
*/
curr_sg = cp->SG; curr_sg = cp->SG;
chained = 0; chained = use_sg > h->max_cmd_sg_entries;
sg_index = 0; sg_limit = chained ? h->max_cmd_sg_entries - 1 : use_sg;
scsi_for_each_sg(cmd, sg, use_sg, i) { last_sg = scsi_sg_count(cmd) - 1;
if (i == h->max_cmd_sg_entries - 1 && scsi_for_each_sg(cmd, sg, sg_limit, i) {
use_sg > h->max_cmd_sg_entries) {
chained = 1;
curr_sg = h->cmd_sg_list[cp->cmdindex];
sg_index = 0;
}
hpsa_set_sg_descriptor(curr_sg, sg); hpsa_set_sg_descriptor(curr_sg, sg);
curr_sg++; curr_sg++;
} }
if (chained) {
/*
* Continue with the chained list. Set curr_sg to the chained
* list. Modify the limit to the total count less the entries
* we've already set up. Resume the scan at the list entry
* where the previous loop left off.
*/
curr_sg = h->cmd_sg_list[cp->cmdindex];
sg_limit = use_sg - sg_limit;
for_each_sg(sg, sg, sg_limit, i) {
hpsa_set_sg_descriptor(curr_sg, sg);
curr_sg++;
}
}
/* Back the pointer up to the last entry and mark it as "last". */ /* Back the pointer up to the last entry and mark it as "last". */
(--curr_sg)->Ext = cpu_to_le32(HPSA_SG_LAST); (curr_sg - 1)->Ext = cpu_to_le32(HPSA_SG_LAST);
if (use_sg + chained > h->maxSG) if (use_sg + chained > h->maxSG)
h->maxSG = use_sg + chained; h->maxSG = use_sg + chained;