netpoll: Use skb_irq_freeable to make zap_completion_queue safe.

Replace the test in zap_completion_queue to test when it is safe to
free skbs in hard irq context with skb_irq_freeable ensuring we only
free skbs when it is safe, and removing the possibility of subtle
problems.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Eric W. Biederman 2014-04-01 12:21:02 -07:00 committed by David S. Miller
parent 574f7194f6
commit b1586f099b

View File

@ -270,7 +270,7 @@ static void zap_completion_queue(void)
while (clist != NULL) { while (clist != NULL) {
struct sk_buff *skb = clist; struct sk_buff *skb = clist;
clist = clist->next; clist = clist->next;
if (skb->destructor) { if (!skb_irq_freeable(skb)) {
atomic_inc(&skb->users); atomic_inc(&skb->users);
dev_kfree_skb_any(skb); /* put this one back */ dev_kfree_skb_any(skb); /* put this one back */
} else { } else {