AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2024-11-25 01:30:52 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

fpga: dfl: afu: convert platform_driver to use dev_groups

Browse Source 
This patch takes advantage of driver core which helps to create
and remove sysfs attribute files, so there is no need to register
sysfs entries manually in dfl-afu platform river code.

Signed-off-by: Wu Hao <hao.wu@intel.com>
Acked-by: Moritz Fischer <mdf@kernel.org>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
This commit is contained in:
Wu Hao 2019-08-12 10:49:58 +08:00 committed by Moritz Fischer
parent 084c3ff1b1
commit a80a4b82e7
1 changed files with 38 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

71
drivers/fpga/dfl-afu-main.c
View File

@ -282,24 +282,17 @@ static struct attribute *port_hdr_attrs[] = {
&dev_attr_power_state.attr, &dev_attr_power_state.attr,
NULL, NULL,
}; };
ATTRIBUTE_GROUPS(port_hdr);
static const struct attribute_group port_hdr_group = {
.attrs = port_hdr_attrs,
};
static int port_hdr_init(struct platform_device *pdev, static int port_hdr_init(struct platform_device *pdev,
struct dfl_feature *feature) struct dfl_feature *feature)
{ {
dev_dbg(&pdev->dev, "PORT HDR Init.\n");
port_reset(pdev); port_reset(pdev);
return device_add_groups(&pdev->dev, port_hdr_groups); return 0;
}
static void port_hdr_uinit(struct platform_device *pdev,
struct dfl_feature *feature)
{
dev_dbg(&pdev->dev, "PORT HDR UInit.\n");
device_remove_groups(&pdev->dev, port_hdr_groups);
} }
static long static long
@ -330,7 +323,6 @@ static const struct dfl_feature_id port_hdr_id_table[] = {
static const struct dfl_feature_ops port_hdr_ops = { static const struct dfl_feature_ops port_hdr_ops = {
.init = port_hdr_init, .init = port_hdr_init,
.uinit = port_hdr_uinit,
.ioctl = port_hdr_ioctl, .ioctl = port_hdr_ioctl,
}; };
@ -361,32 +353,37 @@ static struct attribute *port_afu_attrs[] = {
&dev_attr_afu_id.attr, &dev_attr_afu_id.attr,
NULL NULL
}; };
ATTRIBUTE_GROUPS(port_afu);
static umode_t port_afu_attrs_visible(struct kobject *kobj,
struct attribute *attr, int n)
{
struct device *dev = kobj_to_dev(kobj);
/*
* sysfs entries are visible only if related private feature is
* enumerated.
*/
if (!dfl_get_feature_by_id(dev, PORT_FEATURE_ID_AFU))
return 0;
return attr->mode;
}
static const struct attribute_group port_afu_group = {
.attrs = port_afu_attrs,
.is_visible = port_afu_attrs_visible,
};
static int port_afu_init(struct platform_device *pdev, static int port_afu_init(struct platform_device *pdev,
struct dfl_feature *feature) struct dfl_feature *feature)
{ {
struct resource *res = &pdev->resource[feature->resource_index]; struct resource *res = &pdev->resource[feature->resource_index];
int ret;
dev_dbg(&pdev->dev, "PORT AFU Init.\n"); return afu_mmio_region_add(dev_get_platdata(&pdev->dev),
DFL_PORT_REGION_INDEX_AFU,
ret = afu_mmio_region_add(dev_get_platdata(&pdev->dev), resource_size(res), res->start,
DFL_PORT_REGION_INDEX_AFU, resource_size(res), DFL_PORT_REGION_MMAP | DFL_PORT_REGION_READ |
res->start, DFL_PORT_REGION_READ | DFL_PORT_REGION_WRITE);
DFL_PORT_REGION_WRITE | DFL_PORT_REGION_MMAP);
if (ret)
return ret;
return device_add_groups(&pdev->dev, port_afu_groups);
}
static void port_afu_uinit(struct platform_device *pdev,
struct dfl_feature *feature)
{
dev_dbg(&pdev->dev, "PORT AFU UInit.\n");
device_remove_groups(&pdev->dev, port_afu_groups);
} }
static const struct dfl_feature_id port_afu_id_table[] = { static const struct dfl_feature_id port_afu_id_table[] = {
@ -396,7 +393,6 @@ static const struct dfl_feature_id port_afu_id_table[] = {
static const struct dfl_feature_ops port_afu_ops = { static const struct dfl_feature_ops port_afu_ops = {
.init = port_afu_init, .init = port_afu_init,
.uinit = port_afu_uinit,
}; };
static struct dfl_feature_driver port_feature_drvs[] = { static struct dfl_feature_driver port_feature_drvs[] = {
@ -748,9 +744,16 @@ static int afu_remove(struct platform_device *pdev)
return 0; return 0;
} }
static const struct attribute_group *afu_dev_groups[] = {
&port_hdr_group,
&port_afu_group,
NULL
};
static struct platform_driver afu_driver = { static struct platform_driver afu_driver = {
.driver = { .driver = {
.name = DFL_FPGA_FEATURE_DEV_PORT, .name = DFL_FPGA_FEATURE_DEV_PORT,
.dev_groups = afu_dev_groups,
}, },
.probe = afu_probe, .probe = afu_probe,
.remove = afu_remove, .remove = afu_remove,