mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-11-25 05:50:52 +07:00
[SCSI] qla2xxx: Micro optimization in queuecommand handler
Optimized queuecommand handler's to eliminate double head-room checks. The checks are moved inside the 1st if-loop otherwise you would end up checking twice when there is enough head room. Signed-off-by: Chetan Loke <loke.chetan@gmail.com> Reviewed-by: Andrew Vasquez <andrew.vasquez@qlogic.com> Reviewed-by: Giridhar Malavali <giridhar.malavali@qlogic.com> Signed-off-by: Chad Dupuis <chad.dupuis@qlogic.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
This commit is contained in:
parent
9e336520c5
commit
a6eb3c9f73
@ -385,9 +385,10 @@ qla2x00_start_scsi(srb_t *sp)
|
||||
else
|
||||
req->cnt = req->length -
|
||||
(req->ring_index - cnt);
|
||||
/* If still no head room then bail out */
|
||||
if (req->cnt < (req_cnt + 2))
|
||||
goto queuing_error;
|
||||
}
|
||||
if (req->cnt < (req_cnt + 2))
|
||||
goto queuing_error;
|
||||
|
||||
/* Build command packet */
|
||||
req->current_outstanding_cmd = handle;
|
||||
@ -1502,9 +1503,9 @@ qla24xx_start_scsi(srb_t *sp)
|
||||
else
|
||||
req->cnt = req->length -
|
||||
(req->ring_index - cnt);
|
||||
if (req->cnt < (req_cnt + 2))
|
||||
goto queuing_error;
|
||||
}
|
||||
if (req->cnt < (req_cnt + 2))
|
||||
goto queuing_error;
|
||||
|
||||
/* Build command packet. */
|
||||
req->current_outstanding_cmd = handle;
|
||||
@ -1717,11 +1718,10 @@ qla24xx_dif_start_scsi(srb_t *sp)
|
||||
else
|
||||
req->cnt = req->length -
|
||||
(req->ring_index - cnt);
|
||||
if (req->cnt < (req_cnt + 2))
|
||||
goto queuing_error;
|
||||
}
|
||||
|
||||
if (req->cnt < (req_cnt + 2))
|
||||
goto queuing_error;
|
||||
|
||||
status |= QDSS_GOT_Q_SPACE;
|
||||
|
||||
/* Build header part of command packet (excluding the OPCODE). */
|
||||
@ -2343,11 +2343,10 @@ qla82xx_start_scsi(srb_t *sp)
|
||||
else
|
||||
req->cnt = req->length -
|
||||
(req->ring_index - cnt);
|
||||
if (req->cnt < (req_cnt + 2))
|
||||
goto queuing_error;
|
||||
}
|
||||
|
||||
if (req->cnt < (req_cnt + 2))
|
||||
goto queuing_error;
|
||||
|
||||
ctx = sp->u.scmd.ctx =
|
||||
mempool_alloc(ha->ctx_mempool, GFP_ATOMIC);
|
||||
if (!ctx) {
|
||||
|
Loading…
Reference in New Issue
Block a user