AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2024-12-18 21:06:44 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

selftests/bpf: Fix sample_cnt shared between two threads

Browse Source 
Make sample_cnt volatile to fix possible selftests failure due to compiler
optimization preventing latest sample_cnt value to be visible to main thread.
sample_cnt is incremented in background thread, which is then joined into main
thread. So in terms of visibility sample_cnt update is ok. But because it's
not volatile, compiler might make optimizations that would prevent main thread
to see latest updated value. Fix this by marking global variable volatile.

Fixes: cb1c9ddd55 ("selftests/bpf: Add BPF ringbuf selftests")
Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Song Liu <songliubraving@fb.com>
Link: https://lore.kernel.org/bpf/20200602050349.215037-1-andriin@fb.com
This commit is contained in:
Andrii Nakryiko 2020-06-01 22:03:49 -07:00 committed by Alexei Starovoitov
parent f371c92350
commit 9a5f25ad30
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/testing/selftests/bpf/prog_tests/ringbuf.c
View File

@ -25,7 +25,7 @@ struct sample {
char comm[16];
};
static int sample_cnt;
static volatile int sample_cnt;
static int process_sample(void *ctx, void *data, size_t len)
{