atmel_lcdfb: move lcdcon2 register access to compute_hozval

Pass atmel_lcd_info structure to compute_hozval and only do the register
access on SOCs that actually use it.

This will also simplify the removal of the cpu_is macros.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
This commit is contained in:
Johan Hovold 2013-02-07 16:31:57 +01:00 committed by Nicolas Ferre
parent 557b7d5d07
commit 934a50bd08

View File

@ -193,14 +193,17 @@ static struct fb_fix_screeninfo atmel_lcdfb_fix __initdata = {
.accel = FB_ACCEL_NONE, .accel = FB_ACCEL_NONE,
}; };
static unsigned long compute_hozval(unsigned long xres, unsigned long lcdcon2) static unsigned long compute_hozval(struct atmel_lcdfb_info *sinfo,
unsigned long xres)
{ {
unsigned long lcdcon2;
unsigned long value; unsigned long value;
if (!(cpu_is_at91sam9261() || cpu_is_at91sam9g10() if (!(cpu_is_at91sam9261() || cpu_is_at91sam9g10()
|| cpu_is_at32ap7000())) || cpu_is_at32ap7000()))
return xres; return xres;
lcdcon2 = lcdc_readl(sinfo, ATMEL_LCDC_LCDCON2);
value = xres; value = xres;
if ((lcdcon2 & ATMEL_LCDC_DISTYPE) != ATMEL_LCDC_DISTYPE_TFT) { if ((lcdcon2 & ATMEL_LCDC_DISTYPE) != ATMEL_LCDC_DISTYPE_TFT) {
/* STN display */ /* STN display */
@ -591,8 +594,7 @@ static int atmel_lcdfb_set_par(struct fb_info *info)
lcdc_writel(sinfo, ATMEL_LCDC_TIM2, value); lcdc_writel(sinfo, ATMEL_LCDC_TIM2, value);
/* Horizontal value (aka line size) */ /* Horizontal value (aka line size) */
hozval_linesz = compute_hozval(info->var.xres, hozval_linesz = compute_hozval(sinfo, info->var.xres);
lcdc_readl(sinfo, ATMEL_LCDC_LCDCON2));
/* Display size */ /* Display size */
value = (hozval_linesz - 1) << ATMEL_LCDC_HOZVAL_OFFSET; value = (hozval_linesz - 1) << ATMEL_LCDC_HOZVAL_OFFSET;